[GitHub] trafficserver issue #1210: Create log_requests plugin

2017-03-21 Thread danobi
Github user danobi commented on the issue: https://github.com/apache/trafficserver/pull/1210 Closing. I'm in the process of creating new log fields to do the same thing here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] trafficserver issue #1210: Create log_requests plugin

2016-11-16 Thread danobi
Github user danobi commented on the issue: https://github.com/apache/trafficserver/pull/1210 I'm just going to start adding ideas of names to this comment as I come up with them. `dump_errors`, `log_bad`, `log_errors` --- If your project is set up for it, you can reply to

[GitHub] trafficserver issue #1210: Create log_requests plugin

2016-11-10 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1210 I have to agree with @jpeach that `log_requests` is a bad name. `error_header_log` maybe? I don't much like any alternatives I can think up. There's also the possibility of putting

[GitHub] trafficserver issue #1210: Create log_requests plugin

2016-11-07 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1210 Not sure what happened with my final review message, but I'd suggest looking at dump_headers() in e.g. plugins/background_fetch/headers.cc. It cleanly dumps all headers into a buffer, which

[GitHub] trafficserver issue #1210: Create log_requests plugin

2016-11-07 Thread danobi
Github user danobi commented on the issue: https://github.com/apache/trafficserver/pull/1210 Created under @SolidWallOfCode 's orders. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this