[GitHub] trafficserver issue #1210: Create log_requests plugin
Github user danobi commented on the issue: https://github.com/apache/trafficserver/pull/1210 Closing. I'm in the process of creating new log fields to do the same thing here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1210: Create log_requests plugin
Github user danobi commented on the issue: https://github.com/apache/trafficserver/pull/1210 I'm just going to start adding ideas of names to this comment as I come up with them. `dump_errors`, `log_bad`, `log_errors` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1210: Create log_requests plugin
Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1210 I have to agree with @jpeach that `log_requests` is a bad name. `error_header_log` maybe? I don't much like any alternatives I can think up. There's also the possibility of putting this functionality in `kitchen_sink`, I mean `header_rewrite` although that has some ugly as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1210: Create log_requests plugin
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1210 Not sure what happened with my final review message, but I'd suggest looking at dump_headers() in e.g. plugins/background_fetch/headers.cc. It cleanly dumps all headers into a buffer, which you can then do whatever you want with (including dumping with TSError()). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1210: Create log_requests plugin
Github user danobi commented on the issue: https://github.com/apache/trafficserver/pull/1210 Created under @SolidWallOfCode 's orders. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
