[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-20 Thread jrushford 
Github user jrushford commented on the issue:

https://github.com/apache/trafficserver/pull/1548
  

Should backport it to 7.1.0.  Submitted an issue to refactor the duplicated 
code into a base class and will merge this pr.

Thanks
--
John J. Rushford
IPCDN Engineering
1400 Wewatta Street, Denver Colorado 80202
john_rushf...@cable.comcast.com











From: Leif Hedstrom 
Reply-To: apache/trafficserver 
Date: Thursday, March 16, 2017 at 1:24 PM
To: apache/trafficserver 
Cc: John Rushford , Mention 

Subject: Re: [apache/trafficserver] Insure that parent health stats are 
updated properly on a markdown (#1548)


@jrushford I assume we don't want this for 
7.1.0 ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on 
GitHub,
 or mute the 
thread.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-16 Thread jrushford 
Github user jrushford commented on the issue:

https://github.com/apache/trafficserver/pull/1548
  
@zwoop you're right of course.  I'm going to take a closer look at 
refactoring this into a base class. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-16 Thread zwoop 
Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1548
  
@jrushford I assume we don't want this for 7.1.0 ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-16 Thread zwoop 
Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1548
  
I'm fine with this. However, seeing that the two policy implementations has 
virtually identical implementations here, it begs the question as to why this 
is not in a base class? It seems fragile to have two (or more) places 
implementation the same thing. Maybe file a new Issue on refactoring some of 
this into the base class?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-15 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1548
  
clang-analyzer build *successful*! 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/325/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-15 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1548
  
Intel CC build *successful*! 
https://ci.trafficserver.apache.org/job/icc-github/193/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-15 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1548
  
Linux build *successful*! 
https://ci.trafficserver.apache.org/job/linux-github/1656/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-15 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1548
  
FreeBSD11 build *successful*! 
https://ci.trafficserver.apache.org/job/freebsd-github/1762/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-15 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1548
  
AU check *successful*! 
https://ci.trafficserver.apache.org/job/autest-github/64/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-15 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1548
  
RAT check *successful*! 
https://ci.trafficserver.apache.org/job/RAT-github/80/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-15 Thread jrushford 
Github user jrushford commented on the issue:

https://github.com/apache/trafficserver/pull/1548
  
@PSUdaemon, @vmamidi, @zwoop - is this one okay to merge?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-15 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1548
  
clang format *successful*! 
https://ci.trafficserver.apache.org/job/clang-format-github/67/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-14 Thread zwoop 
Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1548
  
@jrushford Do you want this in 7.1.0? If not, move it out to 7.2.0 please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-07 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1548
  
AU check *successful*! See 
https://ci.trafficserver.apache.org/job/autest-github/1/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-07 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1548
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/255/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-07 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1548
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1587/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-07 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1548
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/123/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-07 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1548
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1691/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---