[jira] [Work logged] (TS-4705) Proposal: NetVC Context
[ https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=29515&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29515 ] ASF GitHub Bot logged work on TS-4705: -- Author: ASF GitHub Bot Created on: 22/Sep/16 17:56 Start Date: 22/Sep/16 17:56 Worklog Time Spent: 10m Work Description: Github user oknet closed the pull request at: https://github.com/apache/trafficserver/pull/753 Issue Time Tracking --- Worklog Id: (was: 29515) Time Spent: 3h 40m (was: 3.5h) > Proposal: NetVC Context > --- > > Key: TS-4705 > URL: https://issues.apache.org/jira/browse/TS-4705 > Project: Traffic Server > Issue Type: Improvement > Components: Core >Reporter: Oknet Xu >Assignee: Oknet Xu > Fix For: 7.1.0 > > Time Spent: 3h 40m > Remaining Estimate: 0h > > Goal 1st: > In the NetVConnection, we have get_local_addr() and get_remote_addr() methods. > Also have members local_addr, remote_addr and netvc->con.addr. > Thus, we should using netvc->con.addr or remote_addr to replace member > server_addr in UnixNetVConnection. > Goal 2nd: > SSLNetVConnection has member sslClientConnection with 2 methods > setSSLClientConnection() and getSSLClientConnection() to indictor ATS is a > client or server in a SSL session. > To abstract above two goals, I'm design the netvc context function. > As a proxy, there has two side: client side ( Client <-> Proxy ) and server > side ( Proxy <-> Server ). With the netvc context funtion to indicate which > side the NetVC working on. > Goal 3rd: > Fix a minor bug in NetAccept::do_blocking_accept, call to > check_emergency_throttle(con) first then allocate vc. > Goal 4th: > NetAccept Optimize, remove dup code, etc... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4705) Proposal: NetVC Context
[ https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=29445&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29445 ] ASF GitHub Bot logged work on TS-4705: -- Author: ASF GitHub Bot Created on: 21/Sep/16 15:18 Start Date: 21/Sep/16 15:18 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/753 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/844/ for details. Issue Time Tracking --- Worklog Id: (was: 29445) Time Spent: 3.5h (was: 3h 20m) > Proposal: NetVC Context > --- > > Key: TS-4705 > URL: https://issues.apache.org/jira/browse/TS-4705 > Project: Traffic Server > Issue Type: Improvement > Components: Core >Reporter: Oknet Xu >Assignee: Oknet Xu > Fix For: 7.1.0 > > Time Spent: 3.5h > Remaining Estimate: 0h > > Goal 1st: > In the NetVConnection, we have get_local_addr() and get_remote_addr() methods. > Also have members local_addr, remote_addr and netvc->con.addr. > Thus, we should using netvc->con.addr or remote_addr to replace member > server_addr in UnixNetVConnection. > Goal 2nd: > SSLNetVConnection has member sslClientConnection with 2 methods > setSSLClientConnection() and getSSLClientConnection() to indictor ATS is a > client or server in a SSL session. > To abstract above two goals, I'm design the netvc context function. > As a proxy, there has two side: client side ( Client <-> Proxy ) and server > side ( Proxy <-> Server ). With the netvc context funtion to indicate which > side the NetVC working on. > Goal 3rd: > Fix a minor bug in NetAccept::do_blocking_accept, call to > check_emergency_throttle(con) first then allocate vc. > Goal 4th: > NetAccept Optimize, remove dup code, etc... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4705) Proposal: NetVC Context
[ https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=29444&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29444 ] ASF GitHub Bot logged work on TS-4705: -- Author: ASF GitHub Bot Created on: 21/Sep/16 15:14 Start Date: 21/Sep/16 15:14 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/753 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/739/ for details. Issue Time Tracking --- Worklog Id: (was: 29444) Time Spent: 3h 20m (was: 3h 10m) > Proposal: NetVC Context > --- > > Key: TS-4705 > URL: https://issues.apache.org/jira/browse/TS-4705 > Project: Traffic Server > Issue Type: Improvement > Components: Core >Reporter: Oknet Xu >Assignee: Oknet Xu > Fix For: 7.1.0 > > Time Spent: 3h 20m > Remaining Estimate: 0h > > Goal 1st: > In the NetVConnection, we have get_local_addr() and get_remote_addr() methods. > Also have members local_addr, remote_addr and netvc->con.addr. > Thus, we should using netvc->con.addr or remote_addr to replace member > server_addr in UnixNetVConnection. > Goal 2nd: > SSLNetVConnection has member sslClientConnection with 2 methods > setSSLClientConnection() and getSSLClientConnection() to indictor ATS is a > client or server in a SSL session. > To abstract above two goals, I'm design the netvc context function. > As a proxy, there has two side: client side ( Client <-> Proxy ) and server > side ( Proxy <-> Server ). With the netvc context funtion to indicate which > side the NetVC working on. > Goal 3rd: > Fix a minor bug in NetAccept::do_blocking_accept, call to > check_emergency_throttle(con) first then allocate vc. > Goal 4th: > NetAccept Optimize, remove dup code, etc... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4705) Proposal: NetVC Context
[
https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=29366&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29366
]
ASF GitHub Bot logged work on TS-4705:
--
Author: ASF GitHub Bot
Created on: 20/Sep/16 03:44
Start Date: 20/Sep/16 03:44
Worklog Time Spent: 10m
Work Description: Github user oknet commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/753#discussion_r79531880
--- Diff: iocore/net/UnixNetAccept.cc ---
@@ -281,29 +280,30 @@ NetAccept::do_blocking_accept(EThread *t)
return -1;
}
+if (check_emergency_throttle(con)) {
+ // `con' could be closed if there is hyper emergency
+ if (con.fd == NO_FD) {
+return 0;
+ }
+}
+
--- End diff --
@jpeach , Here is a similar bug as PR #1033
Issue Time Tracking
---
Worklog Id: (was: 29366)
Time Spent: 3h 10m (was: 3h)
> Proposal: NetVC Context
> ---
>
> Key: TS-4705
> URL: https://issues.apache.org/jira/browse/TS-4705
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.1.0
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Goal 1st:
> In the NetVConnection, we have get_local_addr() and get_remote_addr() methods.
> Also have members local_addr, remote_addr and netvc->con.addr.
> Thus, we should using netvc->con.addr or remote_addr to replace member
> server_addr in UnixNetVConnection.
> Goal 2nd:
> SSLNetVConnection has member sslClientConnection with 2 methods
> setSSLClientConnection() and getSSLClientConnection() to indictor ATS is a
> client or server in a SSL session.
> To abstract above two goals, I'm design the netvc context function.
> As a proxy, there has two side: client side ( Client <-> Proxy ) and server
> side ( Proxy <-> Server ). With the netvc context funtion to indicate which
> side the NetVC working on.
> Goal 3rd:
> Fix a minor bug in NetAccept::do_blocking_accept, call to
> check_emergency_throttle(con) first then allocate vc.
> Goal 4th:
> NetAccept Optimize, remove dup code, etc...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4705) Proposal: NetVC Context
[ https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=29289&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29289 ] ASF GitHub Bot logged work on TS-4705: -- Author: ASF GitHub Bot Created on: 19/Sep/16 06:37 Start Date: 19/Sep/16 06:37 Worklog Time Spent: 10m Work Description: Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/753 bugfix: In do_blocking_accept(), we should check the con.fd == NO_FD while we get return from check_emergency_throttle(). Issue Time Tracking --- Worklog Id: (was: 29289) Time Spent: 3h (was: 2h 50m) > Proposal: NetVC Context > --- > > Key: TS-4705 > URL: https://issues.apache.org/jira/browse/TS-4705 > Project: Traffic Server > Issue Type: Improvement > Components: Core >Reporter: Oknet Xu >Assignee: Oknet Xu > Fix For: 7.1.0 > > Time Spent: 3h > Remaining Estimate: 0h > > Goal 1st: > In the NetVConnection, we have get_local_addr() and get_remote_addr() methods. > Also have members local_addr, remote_addr and netvc->con.addr. > Thus, we should using netvc->con.addr or remote_addr to replace member > server_addr in UnixNetVConnection. > Goal 2nd: > SSLNetVConnection has member sslClientConnection with 2 methods > setSSLClientConnection() and getSSLClientConnection() to indictor ATS is a > client or server in a SSL session. > To abstract above two goals, I'm design the netvc context function. > As a proxy, there has two side: client side ( Client <-> Proxy ) and server > side ( Proxy <-> Server ). With the netvc context funtion to indicate which > side the NetVC working on. > Goal 3rd: > Fix a minor bug in NetAccept::do_blocking_accept, call to > check_emergency_throttle(con) first then allocate vc. > Goal 4th: > NetAccept Optimize, remove dup code, etc... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4705) Proposal: NetVC Context
[ https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=29285&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29285 ] ASF GitHub Bot logged work on TS-4705: -- Author: ASF GitHub Bot Created on: 19/Sep/16 06:00 Start Date: 19/Sep/16 06:00 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/753 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/830/ for details. Issue Time Tracking --- Worklog Id: (was: 29285) Time Spent: 2h 50m (was: 2h 40m) > Proposal: NetVC Context > --- > > Key: TS-4705 > URL: https://issues.apache.org/jira/browse/TS-4705 > Project: Traffic Server > Issue Type: Improvement > Components: Core >Reporter: Oknet Xu >Assignee: Oknet Xu > Fix For: 7.1.0 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > Goal 1st: > In the NetVConnection, we have get_local_addr() and get_remote_addr() methods. > Also have members local_addr, remote_addr and netvc->con.addr. > Thus, we should using netvc->con.addr or remote_addr to replace member > server_addr in UnixNetVConnection. > Goal 2nd: > SSLNetVConnection has member sslClientConnection with 2 methods > setSSLClientConnection() and getSSLClientConnection() to indictor ATS is a > client or server in a SSL session. > To abstract above two goals, I'm design the netvc context function. > As a proxy, there has two side: client side ( Client <-> Proxy ) and server > side ( Proxy <-> Server ). With the netvc context funtion to indicate which > side the NetVC working on. > Goal 3rd: > Fix a minor bug in NetAccept::do_blocking_accept, call to > check_emergency_throttle(con) first then allocate vc. > Goal 4th: > NetAccept Optimize, remove dup code, etc... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4705) Proposal: NetVC Context
[ https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=29284&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29284 ] ASF GitHub Bot logged work on TS-4705: -- Author: ASF GitHub Bot Created on: 19/Sep/16 06:00 Start Date: 19/Sep/16 06:00 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/753 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/726/ for details. Issue Time Tracking --- Worklog Id: (was: 29284) Time Spent: 2h 40m (was: 2.5h) > Proposal: NetVC Context > --- > > Key: TS-4705 > URL: https://issues.apache.org/jira/browse/TS-4705 > Project: Traffic Server > Issue Type: Improvement > Components: Core >Reporter: Oknet Xu >Assignee: Oknet Xu > Fix For: 7.1.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > Goal 1st: > In the NetVConnection, we have get_local_addr() and get_remote_addr() methods. > Also have members local_addr, remote_addr and netvc->con.addr. > Thus, we should using netvc->con.addr or remote_addr to replace member > server_addr in UnixNetVConnection. > Goal 2nd: > SSLNetVConnection has member sslClientConnection with 2 methods > setSSLClientConnection() and getSSLClientConnection() to indictor ATS is a > client or server in a SSL session. > To abstract above two goals, I'm design the netvc context function. > As a proxy, there has two side: client side ( Client <-> Proxy ) and server > side ( Proxy <-> Server ). With the netvc context funtion to indicate which > side the NetVC working on. > Goal 3rd: > Fix a minor bug in NetAccept::do_blocking_accept, call to > check_emergency_throttle(con) first then allocate vc. > Goal 4th: > NetAccept Optimize, remove dup code, etc... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4705) Proposal: NetVC Context
[ https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=28748&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28748 ] ASF GitHub Bot logged work on TS-4705: -- Author: ASF GitHub Bot Created on: 11/Sep/16 15:42 Start Date: 11/Sep/16 15:42 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/753 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/777/ for details. Issue Time Tracking --- Worklog Id: (was: 28748) Time Spent: 2.5h (was: 2h 20m) > Proposal: NetVC Context > --- > > Key: TS-4705 > URL: https://issues.apache.org/jira/browse/TS-4705 > Project: Traffic Server > Issue Type: Improvement > Components: Core >Reporter: Oknet Xu >Assignee: Oknet Xu > Fix For: 7.0.0 > > Time Spent: 2.5h > Remaining Estimate: 0h > > Goal 1st: > In the NetVConnection, we have get_local_addr() and get_remote_addr() methods. > Also have members local_addr, remote_addr and netvc->con.addr. > Thus, we should using netvc->con.addr or remote_addr to replace member > server_addr in UnixNetVConnection. > Goal 2nd: > SSLNetVConnection has member sslClientConnection with 2 methods > setSSLClientConnection() and getSSLClientConnection() to indictor ATS is a > client or server in a SSL session. > To abstract above two goals, I'm design the netvc context function. > As a proxy, there has two side: client side ( Client <-> Proxy ) and server > side ( Proxy <-> Server ). With the netvc context funtion to indicate which > side the NetVC working on. > Goal 3rd: > Fix a minor bug in NetAccept::do_blocking_accept, call to > check_emergency_throttle(con) first then allocate vc. > Goal 4th: > NetAccept Optimize, remove dup code, etc... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4705) Proposal: NetVC Context
[ https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=28747&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28747 ] ASF GitHub Bot logged work on TS-4705: -- Author: ASF GitHub Bot Created on: 11/Sep/16 15:39 Start Date: 11/Sep/16 15:39 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/753 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/673/ for details. Issue Time Tracking --- Worklog Id: (was: 28747) Time Spent: 2h 20m (was: 2h 10m) > Proposal: NetVC Context > --- > > Key: TS-4705 > URL: https://issues.apache.org/jira/browse/TS-4705 > Project: Traffic Server > Issue Type: Improvement > Components: Core >Reporter: Oknet Xu >Assignee: Oknet Xu > Fix For: 7.0.0 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > Goal 1st: > In the NetVConnection, we have get_local_addr() and get_remote_addr() methods. > Also have members local_addr, remote_addr and netvc->con.addr. > Thus, we should using netvc->con.addr or remote_addr to replace member > server_addr in UnixNetVConnection. > Goal 2nd: > SSLNetVConnection has member sslClientConnection with 2 methods > setSSLClientConnection() and getSSLClientConnection() to indictor ATS is a > client or server in a SSL session. > To abstract above two goals, I'm design the netvc context function. > As a proxy, there has two side: client side ( Client <-> Proxy ) and server > side ( Proxy <-> Server ). With the netvc context funtion to indicate which > side the NetVC working on. > Goal 3rd: > Fix a minor bug in NetAccept::do_blocking_accept, call to > check_emergency_throttle(con) first then allocate vc. > Goal 4th: > NetAccept Optimize, remove dup code, etc... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4705) Proposal: NetVC Context
[ https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=27697&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27697 ] ASF GitHub Bot logged work on TS-4705: -- Author: ASF GitHub Bot Created on: 01/Sep/16 06:06 Start Date: 01/Sep/16 06:06 Worklog Time Spent: 10m Work Description: Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/753 Depend on @jpeach's suggestion: - the return type of set_context is void now. - add ink_assert inside set_context() Also: - set NET_VCONNECTION_UNSET to 0 in the enum definition. - add comments for set_context() and get_context(). Issue Time Tracking --- Worklog Id: (was: 27697) Time Spent: 2h 10m (was: 2h) > Proposal: NetVC Context > --- > > Key: TS-4705 > URL: https://issues.apache.org/jira/browse/TS-4705 > Project: Traffic Server > Issue Type: Improvement > Components: Core >Reporter: Oknet Xu >Assignee: Oknet Xu > Fix For: 7.0.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Goal 1st: > In the NetVConnection, we have get_local_addr() and get_remote_addr() methods. > Also have members local_addr, remote_addr and netvc->con.addr. > Thus, we should using netvc->con.addr or remote_addr to replace member > server_addr in UnixNetVConnection. > Goal 2nd: > SSLNetVConnection has member sslClientConnection with 2 methods > setSSLClientConnection() and getSSLClientConnection() to indictor ATS is a > client or server in a SSL session. > To abstract above two goals, I'm design the netvc context function. > As a proxy, there has two side: client side ( Client <-> Proxy ) and server > side ( Proxy <-> Server ). With the netvc context funtion to indicate which > side the NetVC working on. > Goal 3rd: > Fix a minor bug in NetAccept::do_blocking_accept, call to > check_emergency_throttle(con) first then allocate vc. > Goal 4th: > NetAccept Optimize, remove dup code, etc... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4705) Proposal: NetVC Context
[ https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=27687&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27687 ] ASF GitHub Bot logged work on TS-4705: -- Author: ASF GitHub Bot Created on: 01/Sep/16 03:34 Start Date: 01/Sep/16 03:34 Worklog Time Spent: 10m Work Description: Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/753#discussion_r77109780 --- Diff: iocore/net/I_NetVConnection.h --- @@ -566,6 +573,21 @@ class NetVConnection : public VConnection is_transparent = state; } + /// Set the context and return context value + NetVConnectionContext_t + set_context(NetVConnectionContext_t context) --- End diff -- The return value tells you whether it sets successful or not. Yes, the context is only set once and will not change. - Due to the VC is create by Allocator, It can not be set in the constructor. - Assert here and set return type to void. ( update later ) Issue Time Tracking --- Worklog Id: (was: 27687) Time Spent: 2h (was: 1h 50m) > Proposal: NetVC Context > --- > > Key: TS-4705 > URL: https://issues.apache.org/jira/browse/TS-4705 > Project: Traffic Server > Issue Type: Improvement > Components: Core >Reporter: Oknet Xu >Assignee: Oknet Xu > Fix For: 7.0.0 > > Time Spent: 2h > Remaining Estimate: 0h > > Goal 1st: > In the NetVConnection, we have get_local_addr() and get_remote_addr() methods. > Also have members local_addr, remote_addr and netvc->con.addr. > Thus, we should using netvc->con.addr or remote_addr to replace member > server_addr in UnixNetVConnection. > Goal 2nd: > SSLNetVConnection has member sslClientConnection with 2 methods > setSSLClientConnection() and getSSLClientConnection() to indictor ATS is a > client or server in a SSL session. > To abstract above two goals, I'm design the netvc context function. > As a proxy, there has two side: client side ( Client <-> Proxy ) and server > side ( Proxy <-> Server ). With the netvc context funtion to indicate which > side the NetVC working on. > Goal 3rd: > Fix a minor bug in NetAccept::do_blocking_accept, call to > check_emergency_throttle(con) first then allocate vc. > Goal 4th: > NetAccept Optimize, remove dup code, etc... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4705) Proposal: NetVC Context
[
https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=27685&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27685
]
ASF GitHub Bot logged work on TS-4705:
--
Author: ASF GitHub Bot
Created on: 01/Sep/16 03:16
Start Date: 01/Sep/16 03:16
Worklog Time Spent: 10m
Work Description: Github user oknet commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/753#discussion_r77108646
--- Diff: iocore/net/I_NetVConnection.h ---
@@ -566,6 +573,21 @@ class NetVConnection : public VConnection
is_transparent = state;
}
+ /// Set the context and return context value
+ NetVConnectionContext_t
+ set_context(NetVConnectionContext_t context)
+ {
+if (NET_VCONNECTION_UNSET == netvc_context)
+ netvc_context = context;
+return netvc_context;
+ }
+ /// Get the context.
+ NetVConnectionContext_t
+ get_context() const
+ {
--- End diff --
Actually, I did reference the existing functions to name these two
functions, such as "set_remote_addr" and "get_remote_addr".
Issue Time Tracking
---
Worklog Id: (was: 27685)
Time Spent: 1h 50m (was: 1h 40m)
> Proposal: NetVC Context
> ---
>
> Key: TS-4705
> URL: https://issues.apache.org/jira/browse/TS-4705
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Goal 1st:
> In the NetVConnection, we have get_local_addr() and get_remote_addr() methods.
> Also have members local_addr, remote_addr and netvc->con.addr.
> Thus, we should using netvc->con.addr or remote_addr to replace member
> server_addr in UnixNetVConnection.
> Goal 2nd:
> SSLNetVConnection has member sslClientConnection with 2 methods
> setSSLClientConnection() and getSSLClientConnection() to indictor ATS is a
> client or server in a SSL session.
> To abstract above two goals, I'm design the netvc context function.
> As a proxy, there has two side: client side ( Client <-> Proxy ) and server
> side ( Proxy <-> Server ). With the netvc context funtion to indicate which
> side the NetVC working on.
> Goal 3rd:
> Fix a minor bug in NetAccept::do_blocking_accept, call to
> check_emergency_throttle(con) first then allocate vc.
> Goal 4th:
> NetAccept Optimize, remove dup code, etc...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4705) Proposal: NetVC Context
[
https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=27684&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27684
]
ASF GitHub Bot logged work on TS-4705:
--
Author: ASF GitHub Bot
Created on: 01/Sep/16 03:02
Start Date: 01/Sep/16 03:02
Worklog Time Spent: 10m
Work Description: Github user oknet commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/753#discussion_r77107845
--- Diff: iocore/net/P_SSLNetVConnection.h ---
@@ -101,26 +101,13 @@ class SSLNetVConnection : public UnixNetVConnection
{
sslHandShakeComplete = state;
}
-
- virtual bool
- getSSLClientConnection() const
- {
-return sslClientConnection;
- }
-
virtual void
- setSSLClientConnection(bool state)
- {
-sslClientConnection = state;
- }
-
- void
setSSLSessionCacheHit(bool state)
{
sslSessionCacheHit = state;
}
- bool
+ virtual bool
--- End diff --
sorry, It is a rebase & merge mistaken.
Issue Time Tracking
---
Worklog Id: (was: 27684)
Time Spent: 1h 40m (was: 1.5h)
> Proposal: NetVC Context
> ---
>
> Key: TS-4705
> URL: https://issues.apache.org/jira/browse/TS-4705
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Goal 1st:
> In the NetVConnection, we have get_local_addr() and get_remote_addr() methods.
> Also have members local_addr, remote_addr and netvc->con.addr.
> Thus, we should using netvc->con.addr or remote_addr to replace member
> server_addr in UnixNetVConnection.
> Goal 2nd:
> SSLNetVConnection has member sslClientConnection with 2 methods
> setSSLClientConnection() and getSSLClientConnection() to indictor ATS is a
> client or server in a SSL session.
> To abstract above two goals, I'm design the netvc context function.
> As a proxy, there has two side: client side ( Client <-> Proxy ) and server
> side ( Proxy <-> Server ). With the netvc context funtion to indicate which
> side the NetVC working on.
> Goal 3rd:
> Fix a minor bug in NetAccept::do_blocking_accept, call to
> check_emergency_throttle(con) first then allocate vc.
> Goal 4th:
> NetAccept Optimize, remove dup code, etc...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4705) Proposal: NetVC Context
[
https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=27670&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27670
]
ASF GitHub Bot logged work on TS-4705:
--
Author: ASF GitHub Bot
Created on: 01/Sep/16 00:18
Start Date: 01/Sep/16 00:18
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/753#discussion_r77096654
--- Diff: iocore/net/P_SSLNetVConnection.h ---
@@ -101,26 +101,13 @@ class SSLNetVConnection : public UnixNetVConnection
{
sslHandShakeComplete = state;
}
-
- virtual bool
- getSSLClientConnection() const
- {
-return sslClientConnection;
- }
-
virtual void
- setSSLClientConnection(bool state)
- {
-sslClientConnection = state;
- }
-
- void
setSSLSessionCacheHit(bool state)
{
sslSessionCacheHit = state;
}
- bool
+ virtual bool
--- End diff --
Why did you add this?
Issue Time Tracking
---
Worklog Id: (was: 27670)
Time Spent: 1.5h (was: 1h 20m)
> Proposal: NetVC Context
> ---
>
> Key: TS-4705
> URL: https://issues.apache.org/jira/browse/TS-4705
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Goal 1st:
> In the NetVConnection, we have get_local_addr() and get_remote_addr() methods.
> Also have members local_addr, remote_addr and netvc->con.addr.
> Thus, we should using netvc->con.addr or remote_addr to replace member
> server_addr in UnixNetVConnection.
> Goal 2nd:
> SSLNetVConnection has member sslClientConnection with 2 methods
> setSSLClientConnection() and getSSLClientConnection() to indictor ATS is a
> client or server in a SSL session.
> To abstract above two goals, I'm design the netvc context function.
> As a proxy, there has two side: client side ( Client <-> Proxy ) and server
> side ( Proxy <-> Server ). With the netvc context funtion to indicate which
> side the NetVC working on.
> Goal 3rd:
> Fix a minor bug in NetAccept::do_blocking_accept, call to
> check_emergency_throttle(con) first then allocate vc.
> Goal 4th:
> NetAccept Optimize, remove dup code, etc...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4705) Proposal: NetVC Context
[
https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=27669&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27669
]
ASF GitHub Bot logged work on TS-4705:
--
Author: ASF GitHub Bot
Created on: 01/Sep/16 00:15
Start Date: 01/Sep/16 00:15
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/753#discussion_r77096388
--- Diff: iocore/net/I_NetVConnection.h ---
@@ -566,6 +573,21 @@ class NetVConnection : public VConnection
is_transparent = state;
}
+ /// Set the context and return context value
+ NetVConnectionContext_t
+ set_context(NetVConnectionContext_t context)
+ {
+if (NET_VCONNECTION_UNSET == netvc_context)
+ netvc_context = context;
+return netvc_context;
+ }
+ /// Get the context.
+ NetVConnectionContext_t
+ get_context() const
+ {
--- End diff --
I know we don't have strong conventions, but I'd prefer to aim for
``context()`` and ``set_context()`` as the member functions. The former reads
better than ``get_context()``. As noted above I'd like to try to eliminate
``set_context()``.
Issue Time Tracking
---
Worklog Id: (was: 27669)
Time Spent: 1h 20m (was: 1h 10m)
> Proposal: NetVC Context
> ---
>
> Key: TS-4705
> URL: https://issues.apache.org/jira/browse/TS-4705
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Goal 1st:
> In the NetVConnection, we have get_local_addr() and get_remote_addr() methods.
> Also have members local_addr, remote_addr and netvc->con.addr.
> Thus, we should using netvc->con.addr or remote_addr to replace member
> server_addr in UnixNetVConnection.
> Goal 2nd:
> SSLNetVConnection has member sslClientConnection with 2 methods
> setSSLClientConnection() and getSSLClientConnection() to indictor ATS is a
> client or server in a SSL session.
> To abstract above two goals, I'm design the netvc context function.
> As a proxy, there has two side: client side ( Client <-> Proxy ) and server
> side ( Proxy <-> Server ). With the netvc context funtion to indicate which
> side the NetVC working on.
> Goal 3rd:
> Fix a minor bug in NetAccept::do_blocking_accept, call to
> check_emergency_throttle(con) first then allocate vc.
> Goal 4th:
> NetAccept Optimize, remove dup code, etc...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4705) Proposal: NetVC Context
[
https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=27668&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27668
]
ASF GitHub Bot logged work on TS-4705:
--
Author: ASF GitHub Bot
Created on: 01/Sep/16 00:10
Start Date: 01/Sep/16 00:10
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/753#discussion_r77096002
--- Diff: iocore/net/I_NetVConnection.h ---
@@ -566,6 +573,21 @@ class NetVConnection : public VConnection
is_transparent = state;
}
+ /// Set the context and return context value
+ NetVConnectionContext_t
+ set_context(NetVConnectionContext_t context)
+ {
+if (NET_VCONNECTION_UNSET == netvc_context)
+ netvc_context = context;
+return netvc_context;
+ }
+ /// Get the context.
+ NetVConnectionContext_t
+ get_context() const
+ {
--- End diff --
Can we assert that the context is never NET_VCONNECTION_UNSET?
Issue Time Tracking
---
Worklog Id: (was: 27668)
Time Spent: 1h 10m (was: 1h)
> Proposal: NetVC Context
> ---
>
> Key: TS-4705
> URL: https://issues.apache.org/jira/browse/TS-4705
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Goal 1st:
> In the NetVConnection, we have get_local_addr() and get_remote_addr() methods.
> Also have members local_addr, remote_addr and netvc->con.addr.
> Thus, we should using netvc->con.addr or remote_addr to replace member
> server_addr in UnixNetVConnection.
> Goal 2nd:
> SSLNetVConnection has member sslClientConnection with 2 methods
> setSSLClientConnection() and getSSLClientConnection() to indictor ATS is a
> client or server in a SSL session.
> To abstract above two goals, I'm design the netvc context function.
> As a proxy, there has two side: client side ( Client <-> Proxy ) and server
> side ( Proxy <-> Server ). With the netvc context funtion to indicate which
> side the NetVC working on.
> Goal 3rd:
> Fix a minor bug in NetAccept::do_blocking_accept, call to
> check_emergency_throttle(con) first then allocate vc.
> Goal 4th:
> NetAccept Optimize, remove dup code, etc...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4705) Proposal: NetVC Context
[ https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=27667&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27667 ] ASF GitHub Bot logged work on TS-4705: -- Author: ASF GitHub Bot Created on: 01/Sep/16 00:10 Start Date: 01/Sep/16 00:10 Worklog Time Spent: 10m Work Description: Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/753#discussion_r77095956 --- Diff: iocore/net/I_NetVConnection.h --- @@ -566,6 +573,21 @@ class NetVConnection : public VConnection is_transparent = state; } + /// Set the context and return context value + NetVConnectionContext_t + set_context(NetVConnectionContext_t context) --- End diff -- The return value of this is never used, so can we remove it? If the expectation is that the context is only set once, can we either - do it in the constructor and remove this - assert that it is unset here. Issue Time Tracking --- Worklog Id: (was: 27667) Time Spent: 1h (was: 50m) > Proposal: NetVC Context > --- > > Key: TS-4705 > URL: https://issues.apache.org/jira/browse/TS-4705 > Project: Traffic Server > Issue Type: Improvement > Components: Core >Reporter: Oknet Xu >Assignee: Oknet Xu > Fix For: 7.0.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Goal 1st: > In the NetVConnection, we have get_local_addr() and get_remote_addr() methods. > Also have members local_addr, remote_addr and netvc->con.addr. > Thus, we should using netvc->con.addr or remote_addr to replace member > server_addr in UnixNetVConnection. > Goal 2nd: > SSLNetVConnection has member sslClientConnection with 2 methods > setSSLClientConnection() and getSSLClientConnection() to indictor ATS is a > client or server in a SSL session. > To abstract above two goals, I'm design the netvc context function. > As a proxy, there has two side: client side ( Client <-> Proxy ) and server > side ( Proxy <-> Server ). With the netvc context funtion to indicate which > side the NetVC working on. > Goal 3rd: > Fix a minor bug in NetAccept::do_blocking_accept, call to > check_emergency_throttle(con) first then allocate vc. > Goal 4th: > NetAccept Optimize, remove dup code, etc... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4705) Proposal: NetVC Context
[ https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=27554&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27554 ] ASF GitHub Bot logged work on TS-4705: -- Author: ASF GitHub Bot Created on: 31/Aug/16 05:47 Start Date: 31/Aug/16 05:47 Worklog Time Spent: 10m Work Description: Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/753 rebase after TS-4779 Issue Time Tracking --- Worklog Id: (was: 27554) Time Spent: 50m (was: 40m) > Proposal: NetVC Context > --- > > Key: TS-4705 > URL: https://issues.apache.org/jira/browse/TS-4705 > Project: Traffic Server > Issue Type: Improvement > Components: Core >Reporter: Oknet Xu >Assignee: Oknet Xu > Fix For: 7.0.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Goal 1st: > In the NetVConnection, we have get_local_addr() and get_remote_addr() methods. > Also have members local_addr, remote_addr and netvc->con.addr. > Thus, we should using netvc->con.addr or remote_addr to replace member > server_addr in UnixNetVConnection. > Goal 2nd: > SSLNetVConnection has member sslClientConnection with 2 methods > setSSLClientConnection() and getSSLClientConnection() to indictor ATS is a > client or server in a SSL session. > To abstract above two goals, I'm design the netvc context function. > As a proxy, there has two side: client side ( Client <-> Proxy ) and server > side ( Proxy <-> Server ). With the netvc context funtion to indicate which > side the NetVC working on. > Goal 3rd: > Fix a minor bug in NetAccept::do_blocking_accept, call to > check_emergency_throttle(con) first then allocate vc. > Goal 4th: > NetAccept Optimize, remove dup code, etc... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4705) Proposal: NetVC Context
[ https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=26357&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26357 ] ASF GitHub Bot logged work on TS-4705: -- Author: ASF GitHub Bot Created on: 12/Aug/16 16:02 Start Date: 12/Aug/16 16:02 Worklog Time Spent: 10m Work Description: Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/753 Looks good to me! Issue Time Tracking --- Worklog Id: (was: 26357) Time Spent: 40m (was: 0.5h) > Proposal: NetVC Context > --- > > Key: TS-4705 > URL: https://issues.apache.org/jira/browse/TS-4705 > Project: Traffic Server > Issue Type: Improvement > Components: Core >Reporter: Oknet Xu >Assignee: Oknet Xu > Fix For: 7.0.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Goal 1st: > In the NetVConnection, we have get_local_addr() and get_remote_addr() methods. > Also have members local_addr, remote_addr and netvc->con.addr. > Thus, we should using netvc->con.addr or remote_addr to replace member > server_addr in UnixNetVConnection. > Goal 2nd: > SSLNetVConnection has member sslClientConnection with 2 methods > setSSLClientConnection() and getSSLClientConnection() to indictor ATS is a > client or server in a SSL session. > To abstract above two goals, I'm design the netvc context function. > As a proxy, there has two side: client side ( Client <-> Proxy ) and server > side ( Proxy <-> Server ). With the netvc context funtion to indicate which > side the NetVC working on. > Goal 3rd: > Fix a minor bug in NetAccept::do_blocking_accept, call to > check_emergency_throttle(con) first then allocate vc. > Goal 4th: > NetAccept Optimize, remove dup code, etc... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4705) Proposal: NetVC Context
[ https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=26044&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26044 ] ASF GitHub Bot logged work on TS-4705: -- Author: ASF GitHub Bot Created on: 28/Jul/16 08:43 Start Date: 28/Jul/16 08:43 Worklog Time Spent: 10m Work Description: Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/753 @bryancall update the enums. ``` NET_VCONNECTION_UNSET, NET_VCONNECTION_IN, // Client <--> ATS, Client-Side NET_VCONNECTION_OUT, // ATS <--> Server, Server-Side ``` Issue Time Tracking --- Worklog Id: (was: 26044) Time Spent: 0.5h (was: 20m) > Proposal: NetVC Context > --- > > Key: TS-4705 > URL: https://issues.apache.org/jira/browse/TS-4705 > Project: Traffic Server > Issue Type: Improvement > Components: Core >Reporter: Oknet Xu > Time Spent: 0.5h > Remaining Estimate: 0h > > Goal 1st: > In the NetVConnection, we have get_local_addr() and get_remote_addr() methods. > Also have members local_addr, remote_addr and netvc->con.addr. > Thus, we should using netvc->con.addr or remote_addr to replace member > server_addr in UnixNetVConnection. > Goal 2nd: > SSLNetVConnection has member sslClientConnection with 2 methods > setSSLClientConnection() and getSSLClientConnection() to indictor ATS is a > client or server in a SSL session. > To abstract above two goals, I'm design the netvc context function. > As a proxy, there has two side: client side ( Client <-> Proxy ) and server > side ( Proxy <-> Server ). With the netvc context funtion to indicate which > side the NetVC working on. > Goal 3rd: > Fix a minor bug in NetAccept::do_blocking_accept, call to > check_emergency_throttle(con) first then allocate vc. > Goal 4th: > NetAccept Optimize, remove dup code, etc... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4705) Proposal: NetVC Context
[ https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=26043&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26043 ] ASF GitHub Bot logged work on TS-4705: -- Author: ASF GitHub Bot Created on: 28/Jul/16 08:32 Start Date: 28/Jul/16 08:32 Worklog Time Spent: 10m Work Description: Github user masaori335 commented on the issue: https://github.com/apache/trafficserver/pull/753 @oknet AFAIK, it's same. Please set type of JIRA 'improvement'. Currently all code changes are tracked by JIRA. Issue Time Tracking --- Worklog Id: (was: 26043) Time Spent: 20m (was: 10m) > Proposal: NetVC Context > --- > > Key: TS-4705 > URL: https://issues.apache.org/jira/browse/TS-4705 > Project: Traffic Server > Issue Type: Improvement > Components: Core >Reporter: Oknet Xu > Time Spent: 20m > Remaining Estimate: 0h > > Goal 1st: > In the NetVConnection, we have get_local_addr() and get_remote_addr() methods. > Also have members local_addr, remote_addr and netvc->con.addr. > Thus, we should using netvc->con.addr or remote_addr to replace member > server_addr in UnixNetVConnection. > Goal 2nd: > SSLNetVConnection has member sslClientConnection with 2 methods > setSSLClientConnection() and getSSLClientConnection() to indictor ATS is a > client or server in a SSL session. > To abstract above two goals, I'm design the netvc context function. > As a proxy, there has two side: client side ( Client <-> Proxy ) and server > side ( Proxy <-> Server ). With the netvc context funtion to indicate which > side the NetVC working on. > Goal 3rd: > Fix a minor bug in NetAccept::do_blocking_accept, call to > check_emergency_throttle(con) first then allocate vc. > Goal 4th: > NetAccept Optimize, remove dup code, etc... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4705) Proposal: NetVC Context
[ https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=26042&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26042 ] ASF GitHub Bot logged work on TS-4705: -- Author: ASF GitHub Bot Created on: 28/Jul/16 08:28 Start Date: 28/Jul/16 08:28 Worklog Time Spent: 10m Work Description: Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/753 @masaori335 JIRA issue created. BTW what is the proposal review progress ? Is it same as the bug report progress ? create JIRA issue then create PR ? Issue Time Tracking --- Worklog Id: (was: 26042) Time Spent: 10m Remaining Estimate: 0h > Proposal: NetVC Context > --- > > Key: TS-4705 > URL: https://issues.apache.org/jira/browse/TS-4705 > Project: Traffic Server > Issue Type: Improvement > Components: Core >Reporter: Oknet Xu > Time Spent: 10m > Remaining Estimate: 0h > > Goal 1st: > In the NetVConnection, we have get_local_addr() and get_remote_addr() methods. > Also have members local_addr, remote_addr and netvc->con.addr. > Thus, we should using netvc->con.addr or remote_addr to replace member > server_addr in UnixNetVConnection. > Goal 2nd: > SSLNetVConnection has member sslClientConnection with 2 methods > setSSLClientConnection() and getSSLClientConnection() to indictor ATS is a > client or server in a SSL session. > To abstract above two goals, I'm design the netvc context function. > As a proxy, there has two side: client side ( Client <-> Proxy ) and server > side ( Proxy <-> Server ). With the netvc context funtion to indicate which > side the NetVC working on. > Goal 3rd: > Fix a minor bug in NetAccept::do_blocking_accept, call to > check_emergency_throttle(con) first then allocate vc. > Goal 4th: > NetAccept Optimize, remove dup code, etc... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
