[jira] [Commented] (TRAFODION-3105) jdbcT4 meta.getColumns should return 24 columns

2018-06-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TRAFODION-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517428#comment-16517428
 ] 

ASF GitHub Bot commented on TRAFODION-3105:
---

Github user asfgit closed the pull request at:

https://github.com/apache/trafodion/pull/1606


> jdbcT4 meta.getColumns should return 24 columns
> ---
>
> Key: TRAFODION-3105
> URL: https://issues.apache.org/jira/browse/TRAFODION-3105
> Project: Apache Trafodion
>  Issue Type: Bug
>  Components: client-jdbc-t4
>Reporter: mashengchen
>Assignee: mashengchen
>Priority: Major
>
> jdbcT4 meta.getColumns should return 24 columns ,currently there return 18



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (TRAFODION-3105) jdbcT4 meta.getColumns should return 24 columns

2018-06-13 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TRAFODION-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510883#comment-16510883
 ] 

ASF GitHub Bot commented on TRAFODION-3105:
---

Github user mashengchen commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1606#discussion_r195020882
  
--- Diff: core/sqf/sqenvcom.sh ---
@@ -40,12 +40,12 @@ export 
TRAFODION_VER="${TRAFODION_VER_MAJOR}.${TRAFODION_VER_MINOR}.${TRAFODION_
 export PRODUCT_COPYRIGHT_HEADER="2015-2017 Apache Software Foundation"
 ##
 # Trafodion authentication:
-#Set TRAFODION_ENABLE_AUTHENTICATION to YES to enable
+#Set TRAFODION_ENABLE_AUTHENTICATION=NO
 # authentication in the Trafodion environment.
 # LDAP configuration must also be setup--see
 # $TRAF_HOME/sql/scripts/traf_authentication_config for details.
 ##
-export 
TRAFODION_ENABLE_AUTHENTICATION=${TRAFODION_ENABLE_AUTHENTICATION:-NO}
+export TRAFODION_ENABLE_AUTHENTICATION=NO
--- End diff --

sorry, wrong for git add


> jdbcT4 meta.getColumns should return 24 columns
> ---
>
> Key: TRAFODION-3105
> URL: https://issues.apache.org/jira/browse/TRAFODION-3105
> Project: Apache Trafodion
>  Issue Type: Bug
>  Components: client-jdbc-t4
>Reporter: mashengchen
>Assignee: mashengchen
>Priority: Major
>
> jdbcT4 meta.getColumns should return 24 columns ,currently there return 18



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (TRAFODION-3105) jdbcT4 meta.getColumns should return 24 columns

2018-06-13 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TRAFODION-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510681#comment-16510681
 ] 

ASF GitHub Bot commented on TRAFODION-3105:
---

Github user venkat1m commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1606#discussion_r194968081
  
--- Diff: core/sqf/sqenvcom.sh ---
@@ -40,12 +40,12 @@ export 
TRAFODION_VER="${TRAFODION_VER_MAJOR}.${TRAFODION_VER_MINOR}.${TRAFODION_
 export PRODUCT_COPYRIGHT_HEADER="2015-2017 Apache Software Foundation"
 ##
 # Trafodion authentication:
-#Set TRAFODION_ENABLE_AUTHENTICATION to YES to enable
+#Set TRAFODION_ENABLE_AUTHENTICATION=NO
 # authentication in the Trafodion environment.
 # LDAP configuration must also be setup--see
 # $TRAF_HOME/sql/scripts/traf_authentication_config for details.
 ##
-export 
TRAFODION_ENABLE_AUTHENTICATION=${TRAFODION_ENABLE_AUTHENTICATION:-NO}
+export TRAFODION_ENABLE_AUTHENTICATION=NO
--- End diff --

Was this an accidental commit for sqenvcom.sh where you disabled 
authentication to test your other changes?

export 
TRAFODION_ENABLE_AUTHENTICATION=${TRAFODION_ENABLE_AUTHENTICATION:-NO}  is what 
we need 


> jdbcT4 meta.getColumns should return 24 columns
> ---
>
> Key: TRAFODION-3105
> URL: https://issues.apache.org/jira/browse/TRAFODION-3105
> Project: Apache Trafodion
>  Issue Type: Bug
>  Components: client-jdbc-t4
>Reporter: mashengchen
>Assignee: mashengchen
>Priority: Major
>
> jdbcT4 meta.getColumns should return 24 columns ,currently there return 18



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (TRAFODION-3105) jdbcT4 meta.getColumns should return 24 columns

2018-06-13 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TRAFODION-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510677#comment-16510677
 ] 

ASF GitHub Bot commented on TRAFODION-3105:
---

GitHub user mashengchen opened a pull request:

https://github.com/apache/trafodion/pull/1606

[TRAFODION-3105] meta.getColumns should return 24 columns

odbc & jdbc have two rules, odbc return 18 columns while jdbc needs 24 
columns, so there use two case to separate.
also we don't support java.sql.types.REF, so value of the new added columns 
are just null.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mashengchen/trafodion getColumns

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1606.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1606


commit 0211325eb8ac59574d0cb0d77a3949bde9a03d08
Author: mashengchen 
Date:   2018-06-13T06:20:44Z

[TRAFODION-3105] meta.getColumns should return 24 columns




> jdbcT4 meta.getColumns should return 24 columns
> ---
>
> Key: TRAFODION-3105
> URL: https://issues.apache.org/jira/browse/TRAFODION-3105
> Project: Apache Trafodion
>  Issue Type: Bug
>  Components: client-jdbc-t4
>Reporter: mashengchen
>Assignee: mashengchen
>Priority: Major
>
> jdbcT4 meta.getColumns should return 24 columns ,currently there return 18



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)