[jira] [Commented] (TRAFODION-2823) some test case donot close connection

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TRAFODION-2823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290015#comment-16290015
 ] 

ASF GitHub Bot commented on TRAFODION-2823:
---

Github user DaveBirdsall commented on a diff in the pull request:


https://github.com/apache/incubator-trafodion/pull/1320#discussion_r156799988
  
--- Diff: 
dcs/src/test/jdbc_test/src/test/java/org/trafodion/jdbc_test/TestNetworkTimeout.java
 ---
@@ -64,10 +72,19 @@ public void testGetNetworkTimeout() {
Connection conn = null;
try {
System.out.println("Connecting to database...");
-   conn = Utils.getUserConnection();
+   conn = Utils.getUserConnection();S
--- End diff --

The extra "S" at the end of the line appears to be causing the JDBC build 
failure


> some test case donot close connection
> -
>
> Key: TRAFODION-2823
> URL: https://issues.apache.org/jira/browse/TRAFODION-2823
> Project: Apache Trafodion
>  Issue Type: Bug
>Reporter: Gong Pengju
>Priority: Minor
>
> some classes in 
> incubator-trafodion/dcs/src/test/jdbc_test/src/test/java/org/trafodion/jdbc_test
>  do not close statement and connection, which will lead to no connection can 
> be use.
> classes include : 
> PropTest.java
> TestNetworkTimeout.java
> TestWrap.java



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TRAFODION-2823) some test case donot close connection

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TRAFODION-2823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16286006#comment-16286006
 ] 

ASF GitHub Bot commented on TRAFODION-2823:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/1335


> some test case donot close connection
> -
>
> Key: TRAFODION-2823
> URL: https://issues.apache.org/jira/browse/TRAFODION-2823
> Project: Apache Trafodion
>  Issue Type: Bug
>Reporter: Gong Pengju
>Priority: Minor
>
> some classes in 
> incubator-trafodion/dcs/src/test/jdbc_test/src/test/java/org/trafodion/jdbc_test
>  do not close statement and connection, which will lead to no connection can 
> be use.
> classes include : 
> PropTest.java
> TestNetworkTimeout.java
> TestWrap.java



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TRAFODION-2823) some test case donot close connection

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TRAFODION-2823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285640#comment-16285640
 ] 

ASF GitHub Bot commented on TRAFODION-2823:
---

GitHub user gpj1987 opened a pull request:

https://github.com/apache/incubator-trafodion/pull/1335

TRAFODION-2823 add close to TestClientInfo.java

this is for that there cann't pass jenkins test
The test cases in  previous PR do not close conn, and other case could not 
get conn.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gpj1987/incubator-trafodion TRAFODION-2823-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/1335.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1335


commit 9c7b2aedcd32eb428c595b6b38263b4982708159
Author: gpj1987 
Date:   2017-12-11T08:27:18Z

add close to TestClientInfo.java




> some test case donot close connection
> -
>
> Key: TRAFODION-2823
> URL: https://issues.apache.org/jira/browse/TRAFODION-2823
> Project: Apache Trafodion
>  Issue Type: Bug
>Reporter: Gong Pengju
>Priority: Minor
>
> some classes in 
> incubator-trafodion/dcs/src/test/jdbc_test/src/test/java/org/trafodion/jdbc_test
>  do not close statement and connection, which will lead to no connection can 
> be use.
> classes include : 
> PropTest.java
> TestNetworkTimeout.java
> TestWrap.java



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TRAFODION-2823) some test case donot close connection

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TRAFODION-2823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276154#comment-16276154
 ] 

ASF GitHub Bot commented on TRAFODION-2823:
---

Github user DaveBirdsall commented on a diff in the pull request:


https://github.com/apache/incubator-trafodion/pull/1320#discussion_r154540542
  
--- Diff: 
dcs/src/test/jdbc_test/src/test/java/org/trafodion/jdbc_test/TestWrap.java ---
@@ -51,7 +51,11 @@ public void testIsWrapFor() {
 conn = Utils.getUserConnection();
 boolean result = conn.isWrapperFor(Connection.class);
 assertTrue("It is wrapper for this interface", result);
+conn.close();
 } catch (SQLException e) {
+if (conn !=null) {
+conn.close();
--- End diff --

The Jenkins builds are complaining that this code has an uncaught exception 
of some sort. Could you take a look? Thanks.


> some test case donot close connection
> -
>
> Key: TRAFODION-2823
> URL: https://issues.apache.org/jira/browse/TRAFODION-2823
> Project: Apache Trafodion
>  Issue Type: Bug
>Reporter: Gong Pengju
>Priority: Minor
>
> some classes in 
> incubator-trafodion/dcs/src/test/jdbc_test/src/test/java/org/trafodion/jdbc_test
>  do not close statement and connection, which will lead to no connection can 
> be use.
> classes include : 
> PropTest.java
> TestNetworkTimeout.java
> TestWrap.java



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TRAFODION-2823) some test case donot close connection

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TRAFODION-2823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272583#comment-16272583
 ] 

ASF GitHub Bot commented on TRAFODION-2823:
---

GitHub user gpj1987 opened a pull request:

https://github.com/apache/incubator-trafodion/pull/1320

TRAFODION-2823 some test case donot close connection

some classes in 
incubator-trafodion/dcs/src/test/jdbc_test/src/test/java/org/trafodion/jdbc_test
 do not close statement and connection, which will lead to no connection can be 
use.
classes include : 
PropTest.java
TestNetworkTimeout.java
TestWrap.java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gpj1987/incubator-trafodion TRAFODION-2823

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/1320.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1320


commit 47ec58764ffaa4381f65c5cf87a909b7f701b2f0
Author: gpj1987 
Date:   2017-11-30T12:10:37Z

TRAFODION-2823 some test case donot close connection




> some test case donot close connection
> -
>
> Key: TRAFODION-2823
> URL: https://issues.apache.org/jira/browse/TRAFODION-2823
> Project: Apache Trafodion
>  Issue Type: Bug
>Reporter: Gong Pengju
>Priority: Minor
>
> some classes in 
> incubator-trafodion/dcs/src/test/jdbc_test/src/test/java/org/trafodion/jdbc_test
>  do not close statement and connection, which will lead to no connection can 
> be use.
> classes include : 
> PropTest.java
> TestNetworkTimeout.java
> TestWrap.java



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)