Re: [PR] [#2229] feat(server,client): Introduce `OutputUtils` class to reduce log size [incubator-uniffle]
zuston commented on PR #2230: URL: https://github.com/apache/incubator-uniffle/pull/2230#issuecomment-2464189932 > > If having multi modules associated change, the style commit log could be unified as the `feat(server)(client)`. I have seen a lot of illegal different styles like `feat(server,client)` and `feat(server/client)` . @maobaolong > > A lot of projects adopt the style `feat(server,client)`, too. It's oK for me. Let's unify this style -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org For additional commands, e-mail: issues-h...@uniffle.apache.org
Re: [PR] [#2229] feat(server,client): Introduce `OutputUtils` class to reduce log size [incubator-uniffle]
jerqi commented on PR #2230: URL: https://github.com/apache/incubator-uniffle/pull/2230#issuecomment-2461536251 > If having multi modules associated change, the style commit log could be unified as the `feat(server)(client)`. I have seen a lot of illegal different styles like `feat(server,client)` and `feat(server/client)` . @maobaolong A lot of projects adopt the style `feat(server,client)`, too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org For additional commands, e-mail: issues-h...@uniffle.apache.org
Re: [PR] [#2229] feat(server,client): Introduce `OutputUtils` class to reduce log size [incubator-uniffle]
maobaolong commented on PR #2230: URL: https://github.com/apache/incubator-uniffle/pull/2230#issuecomment-2461410604 @maobaolong Sorry for this mistake, will check it before merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org For additional commands, e-mail: issues-h...@uniffle.apache.org
Re: [PR] [#2229] feat(server,client): Introduce `OutputUtils` class to reduce log size [incubator-uniffle]
zuston commented on PR #2230: URL: https://github.com/apache/incubator-uniffle/pull/2230#issuecomment-2461351104 If having multi modules associated change, the style commit log could be unified as the `feat(server)(client)`. I have seen a lot of different styles like `feat(server,client)` and `feat(server/client)` . @maobaolong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org For additional commands, e-mail: issues-h...@uniffle.apache.org
Re: [PR] [#2229] feat(server,client): Introduce `OutputUtils` class to reduce log size [incubator-uniffle]
maobaolong merged PR #2230: URL: https://github.com/apache/incubator-uniffle/pull/2230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org For additional commands, e-mail: issues-h...@uniffle.apache.org
Re: [PR] [#2229] feat(server,client): Introduce `OutputUtils` class to reduce log size [incubator-uniffle]
maobaolong commented on PR #2230: URL: https://github.com/apache/incubator-uniffle/pull/2230#issuecomment-2459429616 @jerqi Thanks for your review, merge it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org For additional commands, e-mail: issues-h...@uniffle.apache.org
Re: [PR] [#2229] feat(server,client): Introduce `OutputUtils` class to reduce log size [incubator-uniffle]
github-actions[bot] commented on PR #2230: URL: https://github.com/apache/incubator-uniffle/pull/2230#issuecomment-2451491947 ## Test Results 2 941 files +46 2 941 suites +46 6h 12m 27s ⏱️ + 15m 58s 1 089 tests + 1 1 087 ✅ + 2 2 💤 ±0 0 ❌ ±0 13 645 runs +75 13 615 ✅ +76 30 💤 ±0 0 ❌ ±0 Results for commit 3d20b96e. ± Comparison against base commit 680f96a1. [test-results]:data:application/gzip;base64,H4sIANiOJGcC/02Myw6DIBBFf8Ww7gIcxNKfaUaBhFSl4bEy/ffiC1meM3PPSoyddCCvppWcPRoSko01q+QxWrdspgXeZ5Xvcftg9CkvfIc0jofrb/ex321XhEE7ZUGL0N47fxqflr0KgncnlioIdrujCtemru5cR0c3zzZmIKBaOkihQdChYwZRGYGGUw1oYGCoEDQqScnvDxSu3acUAQAA -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org For additional commands, e-mail: issues-h...@uniffle.apache.org
