[jira] [Commented] (ZOOKEEPER-1998) C library calls getaddrinfo unconditionally from zookeeper_interest
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109504#comment-17109504 ] Damien Diederen commented on ZOOKEEPER-1998: Thank you! (And sorry for the nagging!) > C library calls getaddrinfo unconditionally from zookeeper_interest > --- > > Key: ZOOKEEPER-1998 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1998 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.5.0 >Reporter: Raúl Gutiérrez Segalés >Assignee: Damien Diederen >Priority: Major > Labels: pull-request-available > Fix For: 3.7.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > (commented this on ZOOKEEPER-338) > I've just noticed that we call getaddrinfo from zookeeper_interest... on > every call. So from zookeeper_interest we always call update_addrs: > https://github.com/apache/zookeeper/blob/trunk/src/c/src/zookeeper.c#L2082 > which in turns unconditionally calls resolve_hosts: > https://github.com/apache/zookeeper/blob/trunk/src/c/src/zookeeper.c#L787 > which does the unconditional calls to getaddrinfo: > https://github.com/apache/zookeeper/blob/trunk/src/c/src/zookeeper.c#L648 > We should fix this since it'll make 3.5.0 slower for people relying on DNS. I > think this is happened as part of ZOOKEEPER-107 in which the list of servers > can be updated. > cc: [~shralex], [~phunt], [~fpj] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-1998) C library calls getaddrinfo unconditionally from zookeeper_interest
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109474#comment-17109474 ] Enrico Olivelli commented on ZOOKEEPER-1998: [~ztzg] I have committed your patch. thank you very much ! thank you [~symat] for your review > C library calls getaddrinfo unconditionally from zookeeper_interest > --- > > Key: ZOOKEEPER-1998 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1998 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.5.0 >Reporter: Raúl Gutiérrez Segalés >Assignee: Enrico Olivelli >Priority: Major > Labels: pull-request-available > Fix For: 3.7.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > (commented this on ZOOKEEPER-338) > I've just noticed that we call getaddrinfo from zookeeper_interest... on > every call. So from zookeeper_interest we always call update_addrs: > https://github.com/apache/zookeeper/blob/trunk/src/c/src/zookeeper.c#L2082 > which in turns unconditionally calls resolve_hosts: > https://github.com/apache/zookeeper/blob/trunk/src/c/src/zookeeper.c#L787 > which does the unconditional calls to getaddrinfo: > https://github.com/apache/zookeeper/blob/trunk/src/c/src/zookeeper.c#L648 > We should fix this since it'll make 3.5.0 slower for people relying on DNS. I > think this is happened as part of ZOOKEEPER-107 in which the list of servers > can be updated. > cc: [~shralex], [~phunt], [~fpj] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-1998) C library calls getaddrinfo unconditionally from zookeeper_interest
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16918728#comment-16918728 ] Damien Diederen commented on ZOOKEEPER-1998: I have recently pushed a GitHub "pull request" which addresses this: https://github.com/apache/zookeeper/pull/1068 It passes all tests and (includes some new ones). Comments and/or suggestions are welcome. > C library calls getaddrinfo unconditionally from zookeeper_interest > --- > > Key: ZOOKEEPER-1998 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1998 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.5.0 >Reporter: Raul Gutierrez Segales >Assignee: Raul Gutierrez Segales >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 10m > Remaining Estimate: 0h > > (commented this on ZOOKEEPER-338) > I've just noticed that we call getaddrinfo from zookeeper_interest... on > every call. So from zookeeper_interest we always call update_addrs: > https://github.com/apache/zookeeper/blob/trunk/src/c/src/zookeeper.c#L2082 > which in turns unconditionally calls resolve_hosts: > https://github.com/apache/zookeeper/blob/trunk/src/c/src/zookeeper.c#L787 > which does the unconditional calls to getaddrinfo: > https://github.com/apache/zookeeper/blob/trunk/src/c/src/zookeeper.c#L648 > We should fix this since it'll make 3.5.0 slower for people relying on DNS. I > think this is happened as part of ZOOKEEPER-107 in which the list of servers > can be updated. > cc: [~shralex], [~phunt], [~fpj] -- This message was sent by Atlassian Jira (v8.3.2#803003)
