[commit] branch 'async' deleted

2012-09-01 Thread Oswald Buddenhagen
The branch 'async', previously at 63b3ff7, has been deleted. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respo

[commit] master: pre-release doc updates

2012-09-01 Thread Oswald Buddenhagen
commit cd09ffe72acd9f8c20f73442eee60caab6316b65 Author: Oswald Buddenhagen Date: Sun Aug 26 15:17:38 2012 +0200 pre-release doc updates NEWS | 12 README |2 +- TODO | 35 --- debian/control |

[commit] master: remove todo about case insensitive INBOX

2012-09-01 Thread Oswald Buddenhagen
commit 61c32c5c7e22001cafa021d9ec7f2acb399206b9 Author: Oswald Buddenhagen Date: Thu Jun 2 19:26:52 2011 +0200 remove todo about case insensitive INBOX this is *our* magic string, not IMAP's. ok, admittedly, we *also* send it to IMAP, but that's just convenience. actually m

[commit] master: update copyrights

2012-09-01 Thread Oswald Buddenhagen
commit 7a11bb7d5761a57a11b63b8df90c797542c40bde Author: Oswald Buddenhagen Date: Sun Apr 10 19:25:46 2011 +0200 update copyrights make the wrapper's help string also mention copyrights pertaining only to the actual syncer, as this is the only string many people will ever se

[commit] master: replace FSF address with something more ... contemporary

2012-09-01 Thread Oswald Buddenhagen
commit 8b790e74399143b7a6e47432a015e5ea7dbcf2a8 Author: Oswald Buddenhagen Date: Sun Apr 10 19:34:36 2011 +0200 replace FSF address with something more ... contemporary debian/copyright |3 +-- src/compat/config.c |3 +-- src/compat/convert.c |3 +-- src/compat/isync.1

[commit] master: install the config examples to docdir

2012-09-01 Thread Oswald Buddenhagen
commit f3fe7a41f6af410858416fe855fd90b0523a05ab Author: Oswald Buddenhagen Date: Sun Aug 26 16:29:37 2012 +0200 install the config examples to docdir src/Makefile.am|6 +- src/compat/Makefile.am |6 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a

[commit] master: update debian packaging

2012-09-01 Thread Oswald Buddenhagen
commit a206d294674ca9962b9dd350290b0561d7589f49 Author: Oswald Buddenhagen Date: Sun Aug 26 16:16:12 2012 +0200 update debian packaging Makefile.am | 14 ++-- debian/{.cvsignore => .gitignore} |2 +- debian/changelog | 141

[commit] master: fix rpm packaging

2012-09-01 Thread Oswald Buddenhagen
commit 06ebf085e4e5d38f8166c3f69b5c6d3da9806246 Author: Oswald Buddenhagen Date: Sun Aug 26 15:02:38 2012 +0200 fix rpm packaging Makefile.am |9 + isync.spec.in |4 ++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/Makefile.am b/Makefile.am index 87e9f

[commit] master: use a hash table for message => sync record lookup

2012-09-01 Thread Oswald Buddenhagen
commit d576755380080653a385ac474b34b082396fca66 Author: Oswald Buddenhagen Date: Sun Aug 26 13:36:12 2012 +0200 use a hash table for message => sync record lookup this removes the pathological O( * ) case at the cost of being a bit more cpu-intensive (but O()) for old messages.

[commit] master: make use of UID EXPUNGE

2012-09-01 Thread Oswald Buddenhagen
commit bdec3efbfbe8d28d5bee8b21d04f99ac094a4cc4 Author: Oswald Buddenhagen Date: Sat Aug 25 20:30:04 2012 +0200 make use of UID EXPUNGE src/drv_imap.c | 38 ++ src/mbsync.1 | 12 ++-- 2 files changed, 40 insertions(+), 10 deletions(-) dif

[commit] master: add support for hierarchical mailboxes

2012-09-01 Thread Oswald Buddenhagen
commit 4f17ae1c3dc738cd4da5c61c2d5e0789cb8315b5 Author: Oswald Buddenhagen Date: Sat Aug 11 18:34:46 2012 +0200 add support for hierarchical mailboxes configure.in |2 +- src/drv_imap.c| 142 + src/drv_maildir.c | 139

[commit] master: introduce ability to flatten the hierarchy of Stores

2012-09-01 Thread Oswald Buddenhagen
commit 46389fba6480163d673d0a8920387a11db971e36 Author: Oswald Buddenhagen Date: Sat Aug 18 13:58:14 2012 +0200 introduce ability to flatten the hierarchy of Stores src/config.c | 13 - src/isync.h |4 +++- src/main.c |9 + src/mbsync.1 | 12

[commit] master: calculate trash box path already in maildir_open_store()

2012-09-01 Thread Oswald Buddenhagen
commit 3316e812086551cc647ca06ba9f2b52d87473a9f Author: Oswald Buddenhagen Date: Sat Aug 11 17:11:57 2012 +0200 calculate trash box path already in maildir_open_store() this gives us some cleaner code paths later on, as we can treat the trash box like a regular mailbox. src/d

[commit] master: ensure that mailbox creation in maildir_store() is limited to trashing

2012-09-01 Thread Oswald Buddenhagen
commit 56401f00fd943832029ae4c078f68bd534055c38 Author: Oswald Buddenhagen Date: Sat Aug 11 17:05:22 2012 +0200 ensure that mailbox creation in maildir_store() is limited to trashing other mailboxes would have been maildir_select()ed already. src/drv_maildir.c |2 +- 1 files

[commit] master: refactor: imap_select2_p2 => imap_refcounted_done_box

2012-09-01 Thread Oswald Buddenhagen
commit fa09e3b0ffcb4dc859af66543622fa5a4c6e6ef2 Author: Oswald Buddenhagen Date: Mon Jun 13 12:13:31 2011 +0200 refactor: imap_select2_p2 => imap_refcounted_done_box soon, we'll use it for something different, too src/drv_imap.c | 37 ++--- 1 fil

[commit] master: don't crash when select() on master fails synchronously

2012-09-01 Thread Oswald Buddenhagen
commit 33484cfbd42690a9e980c9f4a7606b62830e1940 Author: Oswald Buddenhagen Date: Sat Aug 25 15:34:26 2012 +0200 don't crash when select() on master fails synchronously svars->drv[S] would not be initialized yet, so cancel_sync() would crash. src/sync.c |4 1 files ch

[commit] master: fix error handling of invalid SyncState *

2012-09-01 Thread Oswald Buddenhagen
commit afe44d4fdef3b9c592649917ddc16e9c74f5c371 Author: Oswald Buddenhagen Date: Sat Aug 18 12:48:08 2012 +0200 fix error handling of invalid SyncState * when we find that the store is incompatible with in-store sync state, we want to fail the whole channel. however, we must no

[commit] master: reject qualified mailboxes with the magic name INBOX

2012-09-01 Thread Oswald Buddenhagen
commit a91d7e4c28665e3944149aabcbb76f2e7205afea Author: Oswald Buddenhagen Date: Thu Jun 2 19:21:19 2011 +0200 reject qualified mailboxes with the magic name INBOX otherwise we couldn't tell them apart from the real INBOX after stripping away the Path. src/drv_imap.c|

[commit] master: suppress bdb complaints about unknown file format

2012-09-01 Thread Oswald Buddenhagen
commit 5cd1f29a89b6fa4e3fc41d5168926a47fbb68123 Author: Oswald Buddenhagen Date: Mon Jul 25 09:25:09 2011 +0200 suppress bdb complaints about unknown file format pass DB_TRUNCATE when creating databases. otherwise bdb will complain about the empty file we pass it (we have to cr

[commit] master: Revert "fix UIDNEXT handling"

2012-09-01 Thread Oswald Buddenhagen
commit c9f30c046a819edcdaa6552b50026fb147bc85d5 Author: Oswald Buddenhagen Date: Thu Jun 2 12:43:05 2011 +0200 Revert "fix UIDNEXT handling" in fact, UIDNEXT (and UIDVALIDITY) null is *not* allowed (see RFC3501 section 9). them popping up nonetheless was a dovecot bug (which wo

[commit] master: deal with concurrent maildir modifications during listing

2012-09-01 Thread Oswald Buddenhagen
commit d34a9b7468bc53b4a55d1b553676ba3ba5638c35 Author: Oswald Buddenhagen Date: Sat Aug 25 15:29:16 2012 +0200 deal with concurrent maildir modifications during listing files may be renamed (due to new -> cur transition or flag changes), which may lead to two effects if ignore

[commit] master: cleanup maildir error paths

2012-09-01 Thread Oswald Buddenhagen
commit 2e74fd9c37d13aaf56fe2ba936efca7c403b9ddc Author: Oswald Buddenhagen Date: Sun May 22 17:53:28 2011 +0200 cleanup maildir error paths don't try to unlock and close databases and files - this will happen a moment later anyway, through cancelation or re-selection. ironi

[commit] master: fix potential double free

2012-09-01 Thread Oswald Buddenhagen
commit e6ca381a4c8d95aa624acb1fbb7466d8de435a26 Author: Oswald Buddenhagen Date: Sun May 22 17:23:23 2011 +0200 fix potential double free the store may be discarded before we reach maildir_select() again, which will leave us with a dangling pointer. src/drv_maildir.c |1 +

[commit] master: make maildir uidvalidity change fatal

2012-09-01 Thread Oswald Buddenhagen
commit 576780f072e0f8c953b5e9936a271a383205f846 Author: Oswald Buddenhagen Date: Tue May 3 09:42:27 2011 +0200 make maildir uidvalidity change fatal it's best to give the user a chance to fix it rather than completely messing up the syncstate by re-enumerating the UIDs. src/d

[commit] master: employ alternative scheme to finding messages by TUID

2012-09-01 Thread Oswald Buddenhagen
commit e9152f606d1301442ee1bcc3f9197f7a9bfe339a Author: Oswald Buddenhagen Date: Sun Apr 10 13:06:07 2011 +0200 employ alternative scheme to finding messages by TUID instead of SEARCHing every single message (which is slow and happens to be unreliabe with M$ Exchange 2010), jus

[commit] master: plug memory leak in maildir_store_msg() upon failure to acquire UID

2012-09-01 Thread Oswald Buddenhagen
commit 96bf849c450b236b0509b8aa136c1bc8e9e34228 Author: Oswald Buddenhagen Date: Sun May 22 17:22:24 2011 +0200 plug memory leak in maildir_store_msg() upon failure to acquire UID src/drv_maildir.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/drv_maildir.c

[commit] master: clearer debug msg

2012-09-01 Thread Oswald Buddenhagen
commit a3b7a54792cd438af7a40170e4d31f26d94c2a33 Author: Oswald Buddenhagen Date: Sun Apr 3 11:29:33 2011 +0200 clearer debug msg src/sync.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/sync.c b/src/sync.c index f951a7c..250af21 100644 --- a/src/sync.c +++

[commit] master: use ATTR_PRINTFALIKE

2012-09-01 Thread Oswald Buddenhagen
commit 62cceaa176e18ce2b076b263ab015994ee74de51 Author: Oswald Buddenhagen AuthorDate: Mon Apr 11 10:46:25 2011 +0200 Commit: Oswald Buddenhagen CommitDate: Sat Sep 1 21:15:07 2012 +0200 use ATTR_PRINTFALIKE src/isync.h | 18 +- src/mdconvert.c |6 --

[commit] master: fix line wrapping before info messages

2012-09-01 Thread Oswald Buddenhagen
commit 827fdbdc5df38149edf11bdfc85ba555c0045af2 Author: Oswald Buddenhagen Date: Sat Sep 1 17:21:32 2012 +0200 fix line wrapping before info messages unless an info message is explictly marked as a continuation, it must terminate any pending line (typically the progress informa

[commit] master: unify error reporting

2012-09-01 Thread Oswald Buddenhagen
commit c19043a2a513c9638443dbc803089e205bdbbbef Author: Oswald Buddenhagen Date: Sun Apr 10 15:32:25 2011 +0200 unify error reporting - introduce sys_error() and use it instead of perror() and error(strerror()) in all expected error conditions - perror() is used only for

[commit] master: remove Ontty flag

2012-09-01 Thread Oswald Buddenhagen
commit 5d322414420bf4bb7138145ad42c9d942dad11be Author: Oswald Buddenhagen Date: Thu Jun 2 10:14:54 2011 +0200 remove Ontty flag i can't figure out why i added it in the first place. it doesn't seem to make any sense ... src/isync.h |2 +- src/main.c |1 - src/util.c

[commit] master: don't complain about disappearing temp files

2012-09-01 Thread Oswald Buddenhagen
commit f8c894297133c889bc97661f0a51d92bc92f6e12 Author: Oswald Buddenhagen Date: Sun Mar 27 20:39:53 2011 +0200 don't complain about disappearing temp files some other process might be cleaning up concurrently ... src/drv_maildir.c | 11 ++- 1 files changed, 6 insertion

[commit] master: centralize flushing of unfinished debug lines

2012-09-01 Thread Oswald Buddenhagen
commit c4b4aff0a402f90ca783f1c57da4f21185791019 Author: Oswald Buddenhagen AuthorDate: Mon Apr 11 10:45:46 2011 +0200 Commit: Oswald Buddenhagen CommitDate: Sat Sep 1 21:15:07 2012 +0200 centralize flushing of unfinished debug lines src/isync.h |1 + src/sync.c |2 +- src/

[commit] master: enlarge receive buffer considerably

2012-09-01 Thread Oswald Buddenhagen
commit 1ca0b4c9fbc5b7b1867f0e0a2b8b9d8540396209 Author: Oswald Buddenhagen Date: Sun Mar 27 17:50:13 2011 +0200 enlarge receive buffer considerably the tiny buffer makes no sense in the face of huge payloads and now additionally masses of replies from pipelined commands. src/

[commit] master: compile with -ansi -pedantic on gcc

2012-09-01 Thread Oswald Buddenhagen
commit 36a7682a20e7ae313734c8f31095da82cfa1 Author: Oswald Buddenhagen Date: Sun Mar 13 15:03:59 2011 +0100 compile with -ansi -pedantic on gcc greatly helps portability ... configure.in|2 +- src/drv_imap.c | 12 ++-- src/mdconvert.c |2 +- 3 files cha

[commit] master: define _GNU_SOURCE on the command line

2012-09-01 Thread Oswald Buddenhagen
commit 51f7f933ae46cca19dfb73d5a88655e3368ab733 Author: Oswald Buddenhagen Date: Sat Sep 1 21:14:53 2012 +0200 define _GNU_SOURCE on the command line that way it is already set in configure and can thus be used by tests. configure.in |2 ++ src/compat/isync.h |2 --

[commit] master: fully asynchronous IMAP operation

2012-09-01 Thread Oswald Buddenhagen
commit c84f4a8a5d00bba20caa1c6c672d3db2a3e9fb94 Author: Oswald Buddenhagen Date: Sat Aug 25 18:26:23 2012 +0200 fully asynchronous IMAP operation - asynchronous sockets using an event loop - connect & starttls have completion callback parameters - callbacks for notifica

[commit] master: centralize imap_cmd_refcounted_state refcount decrementing

2012-09-01 Thread Oswald Buddenhagen
commit 720de7760e51356380237ec3cada442005edf450 Author: Oswald Buddenhagen Date: Sun Mar 20 18:23:09 2011 +0100 centralize imap_cmd_refcounted_state refcount decrementing no else branches remain, so the if() can be put into imap_refcounted_done() src/drv_imap.c | 18 +++

[commit] master: get rid of redundant literal_pending state flag

2012-09-01 Thread Oswald Buddenhagen
commit c8b058b8d1a1249352d319ad1d0babc966c26d7c Author: Oswald Buddenhagen Date: Sat Mar 12 16:16:42 2011 +0100 get rid of redundant literal_pending state flag src/drv_imap.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/drv_imap.c b/src/drv_im

[commit] master: move responsibility for closing sockets on error to user

2012-09-01 Thread Oswald Buddenhagen
commit a6000c3ee18027abf15a97bd8eb986c4aafadf86 Author: Oswald Buddenhagen Date: Sat Mar 19 19:40:50 2011 +0100 move responsibility for closing sockets on error to user the only user being imap and the first thing in imap_cancel_store() being a call to socket_close(), this code

[commit] master: add simple mainloop implementation

2012-09-01 Thread Oswald Buddenhagen
commit 57a7ef438ce5febf231fa8adf88f9ed96aeb3bf3 Author: Oswald Buddenhagen Date: Sun Mar 13 14:29:12 2011 +0100 add simple mainloop implementation not used so far configure.in |2 +- src/isync.h | 14 src/main.c |1 + src/util.c | 167

[commit] master: make socket read/write error reporting callback-based

2012-09-01 Thread Oswald Buddenhagen
commit 55e75d98a8a15a25994df9dfd51af9a645d36cae Author: Oswald Buddenhagen Date: Sun Mar 27 16:50:32 2011 +0200 make socket read/write error reporting callback-based the functions still have synchronous return codes as well - this enables early error returns without having to r

[commit] master: decouple the filling of the read buffer from consuming it

2012-09-01 Thread Oswald Buddenhagen
commit 8ab42c2fc6e9b0e8a336538e6cff3f7be4a57f4d Author: Oswald Buddenhagen Date: Sun Apr 3 18:47:37 2011 +0200 decouple the filling of the read buffer from consuming it this prepares the code for being called from a callback. notably, this makes the imap list parser have a

[commit] master: centralize imap_cmd disposal

2012-09-01 Thread Oswald Buddenhagen
commit bd6987afad08b5a83e62015bbd100c6039554dff Author: Oswald Buddenhagen Date: Sun Mar 27 12:34:25 2011 +0200 centralize imap_cmd disposal src/drv_imap.c | 29 + 1 files changed, 13 insertions(+), 16 deletions(-) diff --git a/src/drv_imap.c b/src/drv_imap.

[commit] master: make socket_write() capable of taking ownership of the buffer

2012-09-01 Thread Oswald Buddenhagen
commit cfdc80c38ee94035813587922adef2cca865ed59 Author: Oswald Buddenhagen Date: Sun Mar 13 14:12:54 2011 +0100 make socket_write() capable of taking ownership of the buffer that way the user code doesn't have to free it any more. src/drv_imap.c | 30 +--

[commit] master: change socket_write() return code semantics

2012-09-01 Thread Oswald Buddenhagen
commit d867cfe2aa2bd6dbc1b9a5446f24c999fc1d2687 Author: Oswald Buddenhagen Date: Sun Mar 13 13:40:39 2011 +0100 change socket_write() return code semantics instead of returning a write()-like result, return only a binary status code - write errors are handled internally anyway,

[commit] master: make IMAP pipeline depth configurable

2012-09-01 Thread Oswald Buddenhagen
commit ffe872f1cf741ae9e4a97ce1f7d21026427e28bf Author: Oswald Buddenhagen Date: Sun Mar 27 16:58:23 2011 +0200 make IMAP pipeline depth configurable currently, this affects only "clustered" message listings and flag stores. src/drv_imap.c | 11 +-- src/mbsync.1 |

[commit] master: Socket_t + buffer_t => conn_t

2012-09-01 Thread Oswald Buddenhagen
commit 0c785b509ebc93fceb602da9e580362edaab9e00 Author: Oswald Buddenhagen Date: Sun Jan 23 14:06:03 2011 +0100 Socket_t + buffer_t => conn_t remove the layering, in favor of a "buffered connection" abstraction. src/drv_imap.c | 42 +- sr

[commit] master: cancel submitted commands when canceling store

2012-09-01 Thread Oswald Buddenhagen
commit b7d65a81dbb93318ed1132af307a5cadf49693ee Author: Oswald Buddenhagen Date: Sat Mar 19 22:12:55 2011 +0100 cancel submitted commands when canceling store we already have some minimal asynchronicity, so there might be commands in flight when a fatal error comes in. src/dr

[commit] master: security fix: failure to load the certificate file is *not* OK ...

2012-09-01 Thread Oswald Buddenhagen
commit 8d60732360ac8934050ab4eea636a26206c6 Author: Oswald Buddenhagen Date: Sun Apr 10 13:28:48 2011 +0200 security fix: failure to load the certificate file is *not* OK ... src/socket.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/socket.c b/src/sock

[commit] master: make imap_exec() result reporting callback-based

2012-09-01 Thread Oswald Buddenhagen
commit 6894a1fd0f0e5ebfc82a49d7530423609366a5fe Author: Oswald Buddenhagen Date: Sun Apr 3 18:15:36 2011 +0200 make imap_exec() result reporting callback-based this makes the IMAP command submission interface asynchronous. the functions still have synchronous return codes

[commit] master: move socket code to a separate file

2012-09-01 Thread Oswald Buddenhagen
commit d2b487f402ffec690da3468e02bd25112861dd05 Author: Oswald Buddenhagen Date: Sun Jan 23 13:43:00 2011 +0100 move socket code to a separate file this makes the layering more obvious src/Makefile.am |2 +- src/drv_imap.c | 541 +++--

[commit] master: move greeting response handling into get_cmd_result()

2012-09-01 Thread Oswald Buddenhagen
commit c7ceb56f6f78fb9f0981ea39cee5e8e4cd569539 Author: Oswald Buddenhagen Date: Sun Mar 13 12:06:49 2011 +0100 move greeting response handling into get_cmd_result() the primary purpose of this is getting rid of the "free-standing" buffer_gets() call. src/drv_imap.c | 54 ++

[commit] master: docs

2012-09-01 Thread Oswald Buddenhagen
commit ca179c534915f4ca57fc444b62cce0a93c190b6f Author: Oswald Buddenhagen Date: Sun Apr 3 18:21:46 2011 +0200 docs - insert "separator comments" between driver entry points - document driver API - document sync_vars_t parts that are stored in the sync state header src/dr

[commit] master: rely on the maildir's existence with "SyncState *"

2012-09-01 Thread Oswald Buddenhagen
commit 1b26cc3d9a611640fbcce697999035f1cca785e7 Author: Oswald Buddenhagen Date: Sun Jul 24 20:27:09 2011 +0200 rely on the maildir's existence with "SyncState *" now that we open the box first, we know that it will exist at this point. src/sync.c | 20 ++--

[commit] master: split out drv->load() from drv->select()

2012-09-01 Thread Oswald Buddenhagen
commit a4c513800b37d394b6c28866557fe886bb9ed4e6 Author: Oswald Buddenhagen Date: Sat Jul 23 16:06:32 2011 +0200 split out drv->load() from drv->select() src/drv_imap.c| 29 +++-- src/drv_maildir.c | 72 ++--- src/isync.h |8 ++-- src/s

[commit] master: validate maildirs more strictly

2012-09-01 Thread Oswald Buddenhagen
commit 5c75de7bd690ee7ad3aa5266f453a9f8aeb26861 Author: Oswald Buddenhagen Date: Sun Jul 24 20:26:10 2011 +0200 validate maildirs more strictly now that "SyncState *" won't create fake mailboxes any more, we can make a full validity check again. src/drv_maildir.c | 17 +

[commit] master: make creation of trash folder independent from -C option

2012-09-01 Thread Oswald Buddenhagen
commit 0018bb1d4bb38a644ebcd178f7d8836b139b8684 Author: Oswald Buddenhagen Date: Sat Jul 23 16:13:17 2011 +0200 make creation of trash folder independent from -C option the trash is not a box which is synced, but a "byproduct" of manipulating synced boxes, so it makes no sense

[commit] master: make callbacks return early when canceling

2012-09-01 Thread Oswald Buddenhagen
commit b37f28daecd6269935d43c744c016662a19779a3 Author: Oswald Buddenhagen Date: Sun Jul 29 23:15:12 2012 +0200 make callbacks return early when canceling even after driver->cancel() the store may complete commands successfully. return early in this case, so we don't attempt to

[commit] master: minor cleanup: use ctx->gen instead of gctx for consistency

2012-09-01 Thread Oswald Buddenhagen
commit 56e612eaa7087ade4837aa56205346543cbc3c3e Author: Oswald Buddenhagen Date: Mon Jul 30 01:07:31 2012 +0200 minor cleanup: use ctx->gen instead of gctx for consistency src/drv_imap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/drv_imap.c b/src/drv_ima

[commit] master: fix error paths wrt sync drivers, take 2

2012-09-01 Thread Oswald Buddenhagen
commit 57e48f0118bacf555ca7b361b6c5f7d44345d700 Author: Oswald Buddenhagen Date: Sun Jul 29 23:14:48 2012 +0200 fix error paths wrt sync drivers, take 2 synchronous error codes which are passed through callbacks aren't a particularly good idea, after all: latest when the callba

[commit] master: replace DRV_STORE_BAD with a separate bad_callback()

2012-09-01 Thread Oswald Buddenhagen
commit 5fc409ac86bd5bbfd611ee65494b1e282ae241d0 Author: Oswald Buddenhagen Date: Sun Jul 15 12:55:04 2012 +0200 replace DRV_STORE_BAD with a separate bad_callback() that way we don't have to piggy-back (possibly asynchronous) fatal errors to particular commands. intern

[commit] master: don't call cancel() repeatedly on a store

2012-09-01 Thread Oswald Buddenhagen
commit e4fb0f457faceb75fd7f3f4210f28ffdd5634850 Author: Oswald Buddenhagen Date: Sun Apr 3 16:29:18 2011 +0200 don't call cancel() repeatedly on a store erroring command replies will trickle in even after canceling src/sync.c |7 +-- 1 files changed, 5 insertions(+), 2 de

[commit] master: don't access free'd memory in cancel_sync()

2012-09-01 Thread Oswald Buddenhagen
commit 27427f4f56df8166fc59d2475eee1322c7f07f87 Author: Oswald Buddenhagen Date: Sun Jul 22 17:46:54 2012 +0200 don't access free'd memory in cancel_sync() as it happens, the 1st round *may* trash svars - if we get the cancelation request after the slave store has already died.

[commit] master: make drv->cancel()'s callback have no status code

2012-09-01 Thread Oswald Buddenhagen
commit a7ab3251581340e28ad72941247afc00a149deca Author: Oswald Buddenhagen Date: Sun Jul 22 17:32:32 2012 +0200 make drv->cancel()'s callback have no status code this function is not going to actually execute any commands, so it makes no sense for the callback to have a status

[commit] master: don't decode aux pointer on DRV_CANCELED

2012-09-01 Thread Oswald Buddenhagen
commit 08f5a625b0cbf26f11da63f08d51237d91b20516 Author: Oswald Buddenhagen Date: Sun Jun 17 14:52:46 2012 +0200 don't decode aux pointer on DRV_CANCELED the aux data was already free()d by the error callback by the time we get this status code. src/sync.c | 110 +

[commit] master: de-duplicate code a bit

2012-09-01 Thread Oswald Buddenhagen
commit 51de9ff7f7fbe328dffa5dc97dd8319955e915be Author: Oswald Buddenhagen Date: Sun Jul 15 12:50:41 2012 +0200 de-duplicate code a bit src/main.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/main.c b/src/main.c index 5156212..1c5f2e1 100644 --- a/s

[commit] master: make response code parse failure of untagged OK/NO/BYE/BAD non-fatal

2012-09-01 Thread Oswald Buddenhagen
commit 50d0fc3aa82b374a94e72ae6945cb2e5221f91d9 Author: Oswald Buddenhagen Date: Sun Dec 5 16:49:11 2010 +0100 make response code parse failure of untagged OK/NO/BYE/BAD non-fatal as such, it does not disrupt the data stream src/drv_imap.c |3 +-- 1 files changed, 1 insertion

[commit] master: always use return value from get_cmd_result()

2012-09-01 Thread Oswald Buddenhagen
commit 39142eb0e1589200f44775002f75a13f603a6b8e Author: Oswald Buddenhagen Date: Sun Mar 20 13:45:42 2011 +0100 always use return value from get_cmd_result() once we have callback-based error reporting, this will ensure that we don't operate on invalidated data structures. sr

[commit] master: remove redundant use_ssl variables

2012-09-01 Thread Oswald Buddenhagen
commit 0969c96d8545a40600d6d63b5b9ca54b8c47f76c Author: Oswald Buddenhagen Date: Wed Dec 15 19:01:27 2010 +0100 remove redundant use_ssl variables just use the presence of an SSL object as an indicator. if something goes wrong during the ssl handshake or certificate validation,

[commit] master: DRV_SERVER_BAD is and will probably stay unused => trash

2012-09-01 Thread Oswald Buddenhagen
commit a05e2646adf946029353e55c9bf7d43d6960c9c7 Author: Oswald Buddenhagen Date: Sat Nov 20 23:48:23 2010 +0100 DRV_SERVER_BAD is and will probably stay unused => trash src/isync.h |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/isync.h b/src/isync.h index 7

[commit] master: after [TRYCREATE], just resend the same command instead of cloning it

2012-09-01 Thread Oswald Buddenhagen
commit e12c4f563eed973d64ee2eedb1f24322c0fa5828 Author: Oswald Buddenhagen Date: Sat Nov 20 10:17:41 2010 +0100 after [TRYCREATE], just resend the same command instead of cloning it src/drv_imap.c | 18 +++--- 1 files changed, 7 insertions(+), 11 deletions(-) diff --git a/s

[commit] master: use return values from correct set in get_cmd_result()

2012-09-01 Thread Oswald Buddenhagen
commit 99b3288c4a0fee0ec12623777c9fb511dcc588c3 Author: Oswald Buddenhagen Date: Sun Mar 20 16:27:51 2011 +0100 use return values from correct set in get_cmd_result() DRV_OK == RESP_OK, so this worked by accident src/drv_imap.c |4 ++-- 1 files changed, 2 insertions(+), 2 del

[commit] master: do away with the dreaded rcaps hack

2012-09-01 Thread Oswald Buddenhagen
commit 62d39d0e6884caa6ac52867746572a64610fe032 Author: Oswald Buddenhagen Date: Mon Nov 15 10:38:50 2010 +0100 do away with the dreaded rcaps hack don't pretend that the server has no literal+ for the time of the first relevant command's synchronous execution. instead, enable

[commit] master: move setting of ctx->listed outside the drivers

2012-09-01 Thread Oswald Buddenhagen
commit 426d56b0bd6cec108800a7eb3c85b51072317c31 Author: Oswald Buddenhagen Date: Mon Jun 13 12:02:00 2011 +0200 move setting of ctx->listed outside the drivers it's essentially an external state flag src/drv_imap.c|5 + src/drv_maildir.c |1 - src/main.c|

[commit] master: purge imap_store_t::currentnc vestiges

2012-09-01 Thread Oswald Buddenhagen
commit 1e659c275425d6296a1dddbb48aad67a85ecf9f1 Author: Oswald Buddenhagen Date: Mon Nov 15 10:30:24 2010 +0100 purge imap_store_t::currentnc vestiges we always actually open the mailbox before appending to it, so we obviously know that it exists - that's why the code was alrea

[commit] master: check return value from close() after write()

2012-09-01 Thread Oswald Buddenhagen
commit 38828610d918e857a452da1f9e7f2e4407960419 Author: Oswald Buddenhagen Date: Sat Jul 23 12:49:08 2011 +0200 check return value from close() after write() otherwise we may lose data when quota is exceeded or nfs is in a bad mood. src/drv_maildir.c |6 +- 1 files ch

[commit] master: de-duplicate error paths

2012-09-01 Thread Oswald Buddenhagen
commit ffe569ce305c163201b2cf97772d515de9c0e025 Author: Oswald Buddenhagen Date: Sun Apr 10 09:58:41 2011 +0200 de-duplicate error paths makes the code more compact. yay for gotos. src/sync.c | 72 +--- 1 files changed, 18 inserti

[commit] master: fix a bunch of warnings

2012-09-01 Thread Oswald Buddenhagen
commit 378da8ad0d8865eac3ac690a34fa8a1ce40db8a3 Author: Oswald Buddenhagen Date: Sat Jul 7 17:19:17 2012 +0200 fix a bunch of warnings src/compat/convert.c |4 ++-- src/drv_imap.c |2 +- src/drv_maildir.c|2 +- src/sync.c |6 +++--- 4 files changed, 7 i