Re: [PATCH 3/3] drv_imap: avoid multiple invocations of pass/user command

2018-01-31 Thread Oswald Buddenhagen
On Tue, Jan 30, 2018 at 07:51:39AM +, Patrick Steinhardt wrote: > Unset the `pass_cmd` and `user_cmd` fields as soon as their respective > value have been computed. Besides being a bit more efficient as we will > now only ever invoke the respective command once, > no, this was a quite deliberat

[PATCH 3/3] drv_imap: avoid multiple invocations of pass/user command

2018-01-30 Thread Patrick Steinhardt
Unset the `pass_cmd` and `user_cmd` fields as soon as their respective value have been computed. Besides being a bit more efficient as we will now only ever invoke the respective command once, this also fixes a real issue: when calling `ensure_password` or `ensure_user` for a second time, the previ