Re: [Patch] Add OSX Keychain support

2020-06-04 Thread Oliver Runge
It's been over a year, amazingly. And I must've missed your update on this many moons ago. Thanks for that effort, it works as expected and using the IMAP specific entry is perfectly valid. I've reapplied your patch to the current master and tested it with and without the configuration flag and wit

Re: [Patch] Add OSX Keychain support

2019-11-27 Thread Oswald Buddenhagen
i dove into the matter myself and came up with the attached patch. please review, test, and fix as necessary (the patch is tested only on linux, where it obviously doesn't change much). note: the patch is at the top of wip/master-next and won't apply on top of current master. >From de0df019a31

Re: [Patch] Add OSX Keychain support

2019-04-21 Thread Oswald Buddenhagen
sorry for the delay, i'm kinda concentrating on another project. and even some real life. :D On Wed, Mar 27, 2019 at 10:03:03PM +0100, Oliver Runge wrote: > - PassCmd is run even if if the Keychain lookup is successful > huh? that's not what i asked for. the idea is to have clear precedence rules:

Re: [Patch] Add OSX Keychain support

2019-03-27 Thread Oliver Runge
- found and removed the TAB - removed the silent Keychain lookup entirely - PassCmd is run even if if the Keychain lookup is successful - removed check in configure.ac Cheerio OR On Wed, 13 Mar 2019 at 12:32, Oswald Buddenhagen wrote: > > On Mon, Mar 11, 2019 at 08:55:05PM +0100, Oliver Runge

Re: [Patch] Add OSX Keychain support

2019-03-13 Thread Oswald Buddenhagen
On Mon, Mar 11, 2019 at 08:55:05PM +0100, Oliver Runge wrote: > I've addressed: > - TABs instead of spaces > there is still one obvious tab glitch (i guess you use tab size 2 or something ...) > - bail out if the lookup based on explicit configuration fails, indeed > much better > you're still un

Re: [Patch] Add OSX Keychain support

2019-03-11 Thread Oliver Runge
On Mon, 11 Mar 2019 at 01:32, Oswald Buddenhagen wrote: > [...] > on an unrelated note, it occurred to me that i don't like the automatic > fallback you implemented - many users script the invocation, so you want > it to fail hard if the configuration doesn't work (anymore), rather than > suddenly

Re: [Patch] Add OSX Keychain support

2019-03-10 Thread Oswald Buddenhagen
On Sun, Mar 10, 2019 at 08:20:58PM +0100, Oliver Runge wrote: > On Sun, 10 Mar 2019 at 20:01, Oswald Buddenhagen > wrote: > > in principle it would be possible to do just that with a custom > > mbsync-keychain-client tool. > > Yes, I considered that initially. But if I wanted to do a proper > so

Re: [Patch] Add OSX Keychain support

2019-03-10 Thread Oliver Runge
On Sun, 10 Mar 2019 at 20:01, Oswald Buddenhagen wrote: > > [...] > > With the Keychain access directly from mbsync, however, Keychain can > > do the access control based on the process's binary, shutting down > > this particular attack possibility. > > > it's a pity the security command does not

Re: [Patch] Add OSX Keychain support

2019-03-10 Thread Oswald Buddenhagen
On Sun, Mar 10, 2019 at 06:50:23PM +0100, Oliver Runge wrote: > I used PassCmd, but neither `gpg -d .authinfo.gpg` nor `security > find-generic-password [...]` are a good choice in my eyes, because I'd > have to type in my local password (GPG or Keychain access) each time > or add a rule to cache i

[Patch] Add OSX Keychain support

2019-03-10 Thread Oliver Runge
Howdy, isync folks. I've attached a patch to support direct OSX Keychain access on OSX, which adds two things: - new config "KeychainName" and "KeychainAccount" to look up a specific generic password in the Keychain - an attempt to look up the Internet password for the account's host, user, and pr