Re: [Iup-users] NOT_WORKING is not defined in Windows port

2019-05-25 Thread Andrew Robinson
Wow! No wonder IUP is so good. You don't ignore or hide your flaws, you single them out as a constant reminder in a clever way (flag a flaw with an error), and that is something that is quite rare to see in this world. I wished you lived in America. On 2019-05-25 at 7:28 AM, Antonio Scuri

[Iup-users] IUP 3_27: msvc 2010 compiler warnings

2019-05-25 Thread Ranier VF
Hi, msvc 2010 compiler warnings: iupPlotDraw.cpp(322) : warning C4061: enumerator 'IUP_PLOT_XY' in switch of enum 'iupPlotLegendPosition' is not explicitly handled by a case label c:\dll\iup\iup\srcplot\iupPlot.h(21) : see declaration of 'iupPlotLegendPosition' iupPlotDraw.cpp(322) :

Re: [Iup-users] NOT_WORKING is not defined in Windows port

2019-05-25 Thread Antonio Scuri
NOT_WORKING isolates a code that is *not *working... It is there as a reminder. Best, Scuri Em sáb, 25 de mai de 2019 às 11:16, Ranier VF escreveu: > Hi, > When compiling iup_calendar.c in windows port, var NOT_WORKING is > not defined; > What is the correct definition? > > Best regards, >

[Iup-users] NOT_WORKING is not defined in Windows port

2019-05-25 Thread Ranier VF
Hi, When compiling iup_calendar.c in windows port, var NOT_WORKING is not defined; What is the correct definition? Best regards, Ranier Vilela ___ Iup-users mailing list Iup-users@lists.sourceforge.net

[Iup-users] Multiple fixes

2019-05-25 Thread Ranier VF
Hi, Multiple fixes in iupwin_newfiledlg.c: --- ..\..\a\srcfiledlg\iupwin_newfiledlg.cppFri Sep 14 17:33:33 2018 +++ iupwin_newfiledlg.cpp Sat May 25 10:43:31 2019 @@ -334,48 +334,25 @@ COMDLG_FILTERSPEC* filters = (COMDLG_FILTERSPEC*)malloc((buffSize)*sizeof(COMDLG_FILTERSPEC));

[Iup-users] CID 210694 (#1 of 1): Unchecked return value (CHECKED_RETURN)

2019-05-25 Thread Ranier VF
Hi, Should be return? Or is better check return value? --- \dll\iup\a\srccontrols\matrix\iupmat_key.c Mon Dec 11 14:52:46 2017 +++ iupmat_key.cSat May 25 10:26:47 2019 @@ -173,7 +173,7 @@ case K_CR: if (!ih->data->edit_hide_onfocus && ih->data->editing) -

[Iup-users] CID 259162 (#1 of 1): Array compared against 0 (NO_EFFECT)

2019-05-25 Thread Ranier VF
Hi, --- \dll\iup\a\src\win\iupwindows_info.cThu Apr 19 08:22:24 2018 +++ iupwindows_info.c Sat May 25 10:21:08 2019 @@ -87,7 +87,7 @@ sprintf(str, "%d.%d.%d", (int)osvi.dwMajorVersion, (int)osvi.dwMinorVersion, (int)osvi.dwBuildNumber); /* Display service pack (if any). */ - if

[Iup-users] CID 259158 (#1 of 1): Missing break in switch (MISSING_BREAK)

2019-05-25 Thread Ranier VF
Hi, --- \dll\iup\a\src\win\iupwin_toggle.c Mon Aug 20 06:57:56 2018 +++ iupwin_toggle.c Sat May 25 10:17:01 2019 @@ -578,6 +578,7 @@ case BN_DOUBLECLICKED: if (iupAttribGetBoolean(ih, "IGNOREDOUBLECLICK")) return 0; +/* FALLTHROUGH */ case BN_CLICKED: {

[Iup-users] CID 341010 (#1 of 1): 'Constant' variable guards dead code (DEADCODE)

2019-05-25 Thread Ranier VF
Hi, --- \dll\iup\a\src\win\iupwin_label.c Tue Nov 27 17:25:24 2018 +++ iupwin_label.c Sat May 25 10:09:27 2019 @@ -44,7 +44,7 @@ int xpad = ih->data->horiz_padding, ypad = ih->data->vert_padding; int x, y, width, height, bpp; - HBITMAP hBitmap, hMask = NULL; + HBITMAP

[Iup-users] CID 210510 (#2 of 2): Unused value (UNUSED_VALUE)

2019-05-25 Thread Ranier VF
Hi, iup_str.c: mm('®')= 96; mm('°')= 97; mm('µ')= 98; mm('¶')= 99; mm('…')=100; mm('†')=101; mm('‡')=102; mm('•')=103; mm('•')=104; mm('‰')=105; mm('0')=106; mm('¼')=107; mm('½')=108; mm('¾')=109; mm('1')=110; mm('¹')=111; mm('•')=103; mm('•')=104; /* value_overwrite: Overwriting previous

[Iup-users] CID 341020 (#1 of 1): Resource leak (RESOURCE_LEAK)

2019-05-25 Thread Ranier VF
Hi, --- \dll\iup\a\src\iup_globalsdlg.c Tue Apr 23 18:07:31 2019 +++ iup_globalsdlg.cSat May 25 09:56:52 2019 @@ -216,9 +216,8 @@ IupSetAttributeId(list2, "", i + 1, attr_names[i]); IupSetIntId(list2, "_IUP_READONLY", i + 1, 0); } - -free(attr_names); } +

[Iup-users] CID 259157 (#2 of 2): Division or modulo by zero (DIVIDE_BY_ZERO)

2019-05-25 Thread Ranier VF
Hi, --- \dll\iup\a\src\iup_expander.c Mon Oct 29 14:53:02 2018 +++ iup_expander.c Sat May 25 09:49:19 2019 @@ -384,9 +384,10 @@ int frame_time = iupAttribGetInt(ih, "FRAMETIME"); int num_frames = iupAttribGetInt(ih, "NUMFRAMES"); int time_delay = iupAttribGetInt(animate_timer,

[Iup-users] CID 259217 (#1 of 1): Dereference null return value (NULL_RETURNS)4. dereference: Dereferencing a null pointer cbDragDataSize.

2019-05-25 Thread Ranier VF
Hi, Fix iupwin_dragdrop.c: --- \dll\iup\a\src\win\iupwin_dragdrop.cWed Apr 24 17:12:36 2019 +++ iupwin_dragdrop.c Sat May 25 09:34:29 2019 @@ -391,7 +391,7 @@ { IFns cbDragDataSize; IFnsVi cbDragData; - int size; + int size = 0; void *pData; TCHAR type[256]; @@ -405,7

[Iup-users] CID 341005 (#1 of 1): Explicit null dereferenced (FORWARD_NULL)

2019-05-25 Thread Ranier VF
Hi, --- ..\..\a\srcfiledlg\iupwin_newfiledlg.cppFri Sep 14 17:33:33 2018 +++ iupwin_newfiledlg.cpp Sat May 25 09:09:00 2019 @@ -719,7 +719,7 @@ psiResult->Release(); } } -else +else if (opfd != NULL) { IShellItemArray *psiaResult; Best regards,

[Iup-users] CID 341015 (#1 of 1): Division or modulo by zero (DIVIDE_BY_ZERO)

2019-05-25 Thread Ranier VF
Hi, Fix iup_flatscrollbar.c: --- ..\..\a\src\iup_flatscrollbar.c Mon Jan 28 18:13:06 2019 +++ iup_flatscrollbar.c Sat May 25 08:53:03 2019 @@ -138,14 +138,19 @@ static void iFlatScrollBarCalcHandler(int size, int arrow_size, int max, int d, int sb_size, int pos, int* pos1, int* pos2) {

[Iup-users] CID 341016 (#1 of 1): Dereference after null check (FORWARD_NULL)

2019-05-25 Thread Ranier VF
Hi, Fix iup_globalattrib.c: --- ..\..\a\src\iup_globalattrib.c Tue Apr 23 14:33:33 2019 +++ iup_globalattrib.c Sat May 25 08:42:08 2019 @@ -133,7 +133,7 @@ iupdrvWarpPointer(x, y); return; } - if (iupStrEqual(name, "MOUSEBUTTON")) + if (value != NULL && iupStrEqual(name,

[Iup-users] CID 210676 (#1 of 1): Resource leak (RESOURCE_LEAK)

2019-05-25 Thread Ranier VF
Hi, Fix RESOURCE_LEAK at iup_attrib.c --- ..\..\a\src\iup_attrib.cSat Jan 26 16:02:13 2019 +++ iup_attrib.cSat May 25 08:25:17 2019 @@ -1499,6 +1499,11 @@ break; } } + if (name) + { + IupStoreAttribute(ih, name, value); + free(name); + } } Ihandle*

[Iup-users] ENC: New Defects reported by Coverity Scan for IUP - Portable User Interface

2019-05-25 Thread Ranier VF
Hi, This a new report by Coverity about IUP 3.27 Windows port. Best regards, Ranier Vilela De: scan-ad...@coverity.com Enviado: sábado, 25 de maio de 2019 03:02 Para: ranier_...@hotmail.com Assunto: New Defects reported by Coverity Scan for IUP - Portable