Re: [Iup-users] LuaBinaries and TecGraf IM/CD/IUP build tree [was: Trouble building ... under GNU/Linux]

2018-01-19 Thread Antonio Scuri
Yes, in tecmake.mak line 1040 states: BIN2C := $(LUA_BIN)/lua$(LUA_SFX) $(BIN2C_PATH)bin2c.lua The internal LUA_SFX is controlled by the LUA_SUFFIX variable. For non LuaBinaries this is empty. This is described in "Building Lua, IM, CD and IUP in Linux". LUA_BIN can be defined also

[Iup-users] CID 210590 (#1 of 1): Infinite loop (INFINITE_LOOP)

2018-01-19 Thread Ranier VF
Hi, Multiple issues found by Coverity Scan. CID 210502 (#1 of 1): Division or modulo by zero (DIVIDE_BY_ZERO) CID 210590 (#1 of 1): Infinite loop (INFINITE_LOOP) CID 210665 (#1 of 1): Division or modulo by zero (DIVIDE_BY_ZERO) --- a\srcscintilla\iup_scintilladlg.c Fri Jan 19 16:00:51 2018 +++

Re: [Iup-users] LuaBinaries and TecGraf IM/CD/IUP build tree [was: Trouble building ... under GNU/Linux]

2018-01-19 Thread sur-behoffski
On 01/20/18 03:57, Antonio Scuri wrote: No. The LuaBinaries is optional. Best, Scuri G'day Scuri, Thanks for the super-fast reply. Here's the problematic two paragraphs from the earlier message, where the Lua program uses an explicit path that seems to require the tree:

[Iup-users] CID 210500 (#1 of 1): Incorrect sizeof expression (BAD_SIZEOF)

2018-01-19 Thread Ranier VF
Hi, Issue found by Coverity Scan. CID 210500 (#1 of 1): Incorrect sizeof expression (BAD_SIZEOF) bad_sizeof: Taking the size of parameter list is suspicious because although it is declared as an array, it is actually a pointer. Sizeof will return the size of a pointer, which may not be intended.

[Iup-users] CID 210522 (#1 of 1): Unused value (UNUSED_VALUE)

2018-01-19 Thread Ranier VF
Hi, Issue found by Coverity Scan. CID 210522 (#1 of 1): Unused value (UNUSED_VALUE) assigned_value: Assigning value from temp to state here, but that stored value is overwritten before it can be used file: iup_maskmatch.c line: 482 state = temp; Best. Ranier

Re: [Iup-users] Trouble building local-lua-less {IM, CD, IUP} packages under GNU/Linux

2018-01-19 Thread Antonio Scuri
No. The LuaBinaries is optional. Best, Scuri 2018-01-19 15:14 GMT-02:00 sur-behoffski : > On 01/19/18 21:14, Antonio Scuri wrote: > >>The Lua bindings of the libraries do depends on Lua. >> >> Best, >> Scuri >> >> >> 2018-01-18 22:17 GMT-02:00 sur-behoffski

[Iup-users] CID 210632 (#1 of 1): Logically dead code (DEADCODE)

2018-01-19 Thread Ranier VF
Hi, Issue found by Coverity Scan. CID 210632 (#1 of 1): Logically dead code (DEADCODE) array_null: Comparing an array to null is not useful: ilex.name, since the test will always evaluate as true. --- a\src\iup_ledlex.c Sun Jul 26 03:10:06 2015 +++ b\src\iup_ledlex.c Fri Jan 19 15:20:27 2018

Re: [Iup-users] Trouble building local-lua-less {IM, CD, IUP} packages under GNU/Linux

2018-01-19 Thread sur-behoffski
On 01/19/18 21:14, Antonio Scuri wrote: The Lua bindings of the libraries do depends on Lua. Best, Scuri 2018-01-18 22:17 GMT-02:00 sur-behoffski : G'day, [All content here relates to GNU/Linux builds; I've tried to work on two separate Ubuntu-based

Re: [Iup-users] CID 210573 (#1 of 1): Dereference after null check (FORWARD_NULL)

2018-01-19 Thread Ranier VF
Hi, Well can be rarely but. If afunc->system_default is NOT NULL and afunc->default_value is NULL, and afunc->call_global_default IS NOT NULL: if ((!iupStrEqualNoCase(afunc->default_value, afunc->system_default)) || take false branch, and (afunc->call_global_default &&

[Iup-users] Preparing IUP 3.24

2018-01-19 Thread Antonio Scuri
Hi All, IUP 3.24 is ready on SVN. But I will release it only next week. I should start the build on Monday. So you still have a few days to send me the latest bug reports. Best, Scuri -- Check out the vibrant tech

Re: [Iup-users] CID 210649 (#2-4 of 4): Division or modulo by zero (DIVIDE_BY_ZERO)

2018-01-19 Thread Antonio Scuri
I mean the function were that happen is never called if sb_ymax=sb_ymin. Best, Scuri 2018-01-19 11:10 GMT-02:00 Ranier VF : > Hi, > line 391:sb_range = sb_ymax - sb_ymin; > line 393:posy = ((start_pos - sb_ymin) * range) / sb_range; > > and > > line 425:

Re: [Iup-users] CID 210573 (#1 of 1): Dereference after null check (FORWARD_NULL)

2018-01-19 Thread Antonio Scuri
No. I didn't change it. The logic is correct. You can not replace call_global_default by default_value. Best, Scuri 2018-01-19 11:15 GMT-02:00 Pete Lomax via Iup-users < iup-users@lists.sourceforge.net>: > On Fri, 19/1/18, Antonio Scuri wrote: > > >then they are

Re: [Iup-users] CID 210573 (#1 of 1): Dereference after null check (FORWARD_NULL)

2018-01-19 Thread Pete Lomax via Iup-users
On Fri, 19/1/18, Antonio Scuri wrote: >then they are equal and not NULL at: >       >     (afunc->call_global_default && > iupGlobalDefaultColorChanged(afunc->default_value))) By that logic you could/should/may as well change it to:     (afunc->default_value &&

Re: [Iup-users] CID 210649 (#2-4 of 4): Division or modulo by zero (DIVIDE_BY_ZERO)

2018-01-19 Thread Ranier VF
Hi, line 391:sb_range = sb_ymax - sb_ymin; line 393:posy = ((start_pos - sb_ymin) * range) / sb_range; and line 425: sb_range = sb_xmax - sb_xmin; line 427: posx = ((start_pos - sb_xmin) * range) / sb_range; If sb_ymax=sb_ymin then or sb_xmax=sb_xmin, sb_range == 0! How exaclty this

Re: [Iup-users] CID 210649 (#2-4 of 4): Division or modulo by zero (DIVIDE_BY_ZERO)

2018-01-19 Thread Antonio Scuri
If sb_range=0 then sb_ymax=sb_ymin then the scrollbar is not shown, then this code is not called. Best, Scuri 2018-01-19 0:29 GMT-02:00 Ranier VF : > Hi, > Issue found by Coverity Scan. > CID 210649 (#2-4 of 4): Division or modulo by zero (DIVIDE_BY_ZERO) >

Re: [Iup-users] CID 210519 (#1 of 1): Logically dead code (DEADCODE)

2018-01-19 Thread Antonio Scuri
Fixed and committed to SVN. Best, Scuri 2018-01-19 7:25 GMT-02:00 Pete Lomax via Iup-users < iup-users@lists.sourceforge.net>: > perhaps inNames should be made static? > > > On Fri, 19/1/18, Ranier VF wrote: > > Subject:

Re: [Iup-users] CID 210629 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS)

2018-01-19 Thread Antonio Scuri
Notice that the if is actually an assertion: if (!iupObjectCheck(ih)) return -1; If that fail, it means the IupFlatTabs handle is not valid anymore. And that can not occur at that point. Best, Scuri 2018-01-19 0:14 GMT-02:00 Ranier VF : > Hi, > Issue found

Re: [Iup-users] CID 210573 (#1 of 1): Dereference after null check (FORWARD_NULL)

2018-01-19 Thread Antonio Scuri
The first if tests for: (afunc->default_value || afunc->system_default) && So default_value can be NULL if system_default is not. Or they are equal and NOT NULL. The second if tests for: if ((!iupStrEqualNoCase(afunc->default_value, afunc->system_default)) || If they are not equal OR

Re: [Iup-users] Trouble building local-lua-less {IM, CD, IUP} packages under GNU/Linux

2018-01-19 Thread Antonio Scuri
The Lua bindings of the libraries do depends on Lua. Best, Scuri 2018-01-18 22:17 GMT-02:00 sur-behoffski : > G'day, > > [All content here relates to GNU/Linux builds; I've tried to work on two > separate Ubuntu-based distributions.] > > I've been trying to avoid

Re: [Iup-users] CID 210519 (#1 of 1): Logically dead code (DEADCODE)

2018-01-19 Thread Pete Lomax via Iup-users
perhaps inNames should be made static? On Fri, 19/1/18, Ranier VF wrote: Subject: [Iup-users] CID 210519 (#1 of 1): Logically dead code (DEADCODE) To: "IUP discussion list." Date: Friday,