Re: CyrusSASL broken in jabberd-2.3.[01]

2013-11-28 Thread Reinhard Max


On Thu, 28 Nov 2013 at 14:56, Tomasz Sterna wrote:


https://github.com/jabberd2/jabberd2/commit/3425223ae8 fixes it.


... almost. You replaced the two calls to strlcat by strncat without 
adjusting the 3rd argument, which needs to be


  sizeof(adjusted_user)-strlen(adjusted_user)-1

cu
Reinhard




Re: CyrusSASL broken in jabberd-2.3.[01]

2013-11-28 Thread Reinhard Max


On Thu, 28 Nov 2013 at 14:56, Tomasz Sterna wrote:


https://github.com/jabberd2/jabberd2/commit/3425223ae8 fixes it.


Thanks.


Out of curiosity - why do you still use CyrusSASL?


You asked this before. ;)

IIRC because this was the only option on openSUSE at the time I first 
built jabberd. Meanwhile openSUSE also has gsasl packages, but Cyrus 
still seems to be the default choice.


Would using gsasl have any advantages for my jabberd packages besides 
the fact that the Cyrus code in jabberd2 is unsupported/deprecated?



cu
Reinhard




Re: CyrusSASL broken in jabberd-2.3.[01]

2013-11-28 Thread Tomasz Sterna
Dnia 2013-11-28, czw o godzinie 13:58 +0100, Reinhard Max pisze:
> when trying to build 2.3.1 for openSUSE, I found that this change
> e134d30f broke CyrusSASL support:
> It adds three new local includes, which do not exist in the source 
> tree. Tomasz, could it be that you forgot to git-add them, before 
> committing that change?

While merging
http://www.opensource.apple.com/source/ChatServer/ChatServer-373.4/apple_patch/pre_configure/jabberd2/sx/sasl_cyrus.c.patch
 I didn't notice that it includes files from 
http://www.opensource.apple.com/source/ChatServer/ChatServer-373.4/jabber_od_auth/

https://github.com/jabberd2/jabberd2/commit/3425223ae8 fixes it.


Out of curiosity - why do you still use CyrusSASL?


-- 
Tomasz Sterna @ http://abadcafe.pl/ @ http://www.xiaoka.com/





CyrusSASL broken in jabberd-2.3.[01]

2013-11-28 Thread Reinhard Max

Hi,

when trying to build 2.3.1 for openSUSE, I found that this change 
broke CyrusSASL support:


https://github.com/jabberd2/jabberd2/commit/e134d30f4bb7d01e9674ef0338e9bc46e8cd2349

It adds three new local includes, which do not exist in the source 
tree. Tomasz, could it be that you forgot to git-add them, before 
committing that change?


cu
Reinhard




jabberd-2.3.1 release

2013-11-28 Thread Tomasz Sterna

Next jabberd2 release is available.

Get 2.3.1 release at GitHub: https://github.com/jabberd2/jabberd2/releases


This release deals with "TLS Everywhere" problems introduced in 2.3.0.
This feature was moved under EXPERIMENTAL umbrella.
If you want to enable it, you now need to ./configure --enable-experimental


Changes:
  * Marked "TLS-Everywhere" as EXPERIMENTAL feature
  * default EXPERIMENTAL to 'no'
  * default SUPERSEDED to 'no'
  * moved STANZA-ACK and MY-IP-ADDRESS XEPs and IQ-PRIVATE push out
of experimental status

For a full change log see: 
https://github.com/jabberd2/jabberd2/commits/jabberd-2.3.1






-- 
Tomasz Sterna @ http://abadcafe.pl/ @ http://www.xiaoka.com/