[ https://issues.apache.org/jira/browse/AXIS2-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Veithen resolved AXIS2-5856. ------------------------------------ Resolution: Fixed Fix Version/s: 1.8.0 > Wrong null checker > ------------------ > > Key: AXIS2-5856 > URL: https://issues.apache.org/jira/browse/AXIS2-5856 > Project: Axis2 > Issue Type: Bug > Components: XMPP transport > Reporter: JC > Priority: Trivial > Fix For: 1.8.0 > > > Hi > In a recent GitHub snapshot, I've found a following code smell. > Path: > modules/transport/xmpp/src/org/apache/axis2/transport/xmpp/XMPPListener.java > {code} > 165 public EndpointReference[] getEPRsForService(String serviceName, > String ip) throws AxisFault { > 166 String domainName = serverCredentials.getDomainName() == null? > serverCredentials.getDomainName() > 167 : serverCredentials.getServerUrl(); > 168 return new EndpointReference[]{new > EndpointReference(XMPPConstants.XMPP_PREFIX + > 169 serverCredentials.getAccountName() +"@"+ > domainName +"/services/" + serviceName)}; > 170 } > {code} > In Line 166, serverCredentials.getDomainName() == null should be > serverCredentials.getDomainName() != null ? This might be a trivial issue but > wanted to report just in case. > Thanks! -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@axis.apache.org For additional commands, e-mail: java-dev-h...@axis.apache.org