Re: [jira] Commented: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-07-12 Thread Ning Li
I'm not sure I understand your question you mean why would one want to stick to public APIs? No, that's not what I meant. I definitely agree that we should stick to publich APIs as much as we can. If it can be done in a separate class, using public APIs (or at least with a minimum of prote

Re: [jira] Commented: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-07-12 Thread Yonik Seeley
On 7/12/06, Ning Li <[EMAIL PROTECTED]> wrote: > I'll rephrase my original question: > When implementing NewIndexModifier, what type of efficiencies do we > get by using the new protected methods of IndexWriter vs using the > public APIs of IndexReader and IndexWriter? What do you think can be

Re: [jira] Commented: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-07-12 Thread robert engels
You are really starting to lose me here Ning... I think the sentiments are that there are better, less intrusive ways of doing what you are trying to do with the massive changes to IndexWriter. A higher level class that manages the updates can be just as efficient if not more so, and far

Re: [jira] Commented: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-07-12 Thread Ning Li
The current implementation makes some assumptions, such as the "unique key" is a single field, not any sort of compound key, and it doesn't allow deletes by query. That, coupled with a more complex implementation makes me wary of putting it in IndexWriter. By "current implementation", you meant

Re: [jira] Commented: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-07-12 Thread robert engels
The previous email spelled out the details pretty well. I don't have time to write the code at this time. I was only making a comment that I thought your patch was too involved for what it does and there are better ways of doing it (which it seems other have had the same sentiment). On Ju

Re: [jira] Commented: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-07-12 Thread Ning Li
I proposed a design of "BufferedWriter" in a previous email that would not have this limited. It is similar to what other have suggested, which is to handle the buffering in a higher-level class and level IndexWriter alone. Could you spell out the details, or better, submit the patch? So that we

Re: [jira] Commented: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-07-12 Thread robert engels
No, the code does not exist yet... I have a version that requires a unique identifier. I proposed a design of "BufferedWriter" in a previous email that would not have this limited. It is similar to what other have suggested, which is to handle the buffering in a higher-level class and lev

Re: [jira] Commented: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-07-12 Thread Ning Li
Then I submit hat my proposed "BufferedWriter" is far simpler and probably performs equally as well, if not better, especially for the case where a document can be uniquely identified. Can I find the patch for this already somewhere? Does it require an explicit unique identifier understandable b

query for search through lucene for BLOB

2006-07-12 Thread sudarshan angirash
hi all i have some PDF files stored in Oracle 9i as BLOB. now i want to search for a string in those pdf files using Lucene. then i want to show the selected PDF files which contains The String. if you can give me any pointers about how to do it, then it will be a gr8 help for me. regards sudar