[jira] Updated: (LUCENE-1482) Replace infoSteram by a logging framework (SLF4J)

2008-12-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-1482: --- Attachment: LUCENE-1482-2.patch I kept safeDebugMsg because it was used by a class which extended In

[jira] Commented: (LUCENE-831) Complete overhaul of FieldCache API/Implementation

2008-12-09 Thread Marvin Humphrey (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655081#action_12655081 ] Marvin Humphrey commented on LUCENE-831: > Marvin, does KS/Lucy have something like

RE: jira attachments ?

2008-12-09 Thread Andrew Myers
Hi Robert, I'm part of the JIRA support team and one of our devs brought this up so I've taken a quick look to see if i can try and replicate your problem. I just upgraded to Safari 3.2 on OS X 10.5 and tested on a couple of different versions of JIRA (3.12.2 and 3.13.2) and didn't have a

[jira] Issue Comment Edited: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655048#action_12655048 ] [EMAIL PROTECTED] edited comment on LUCENE-1483 at 12/9/08 6:15 PM:

[jira] Updated: (LUCENE-1484) Remove SegmentReader.document synchronization

2008-12-09 Thread Jason Rutherglen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Rutherglen updated LUCENE-1484: - Attachment: LUCENE-1484.patch LUCENE-1484.patch - FieldsReader implements Cloneable - f

[jira] Commented: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655048#action_12655048 ] Mark Miller commented on LUCENE-1483: - Doing a little profiling on the new code and of

[jira] Commented: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655036#action_12655036 ] Mark Miller commented on LUCENE-1483: - I also did a quick reopen alg. The speed gain o

[jira] Updated: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated LUCENE-1483: Attachment: LUCENE-1483.patch Here is what I've got. The final sort test still fails, but the rest

[jira] Commented: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655025#action_12655025 ] Michael McCandless commented on LUCENE-1483: bq. on first quick test, I still

[jira] Commented: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655005#action_12655005 ] Mark Miller commented on LUCENE-1483: - bq. make a HitCollector that gathers the result

[jira] Issue Comment Edited: (LUCENE-1478) Missing possibility to supply custom FieldParser when sorting search results

2008-12-09 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655002#action_12655002 ] thetaphi edited comment on LUCENE-1478 at 12/9/08 2:55 PM:

[jira] Commented: (LUCENE-1478) Missing possibility to supply custom FieldParser when sorting search results

2008-12-09 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655002#action_12655002 ] Uwe Schindler commented on LUCENE-1478: --- Just a note: For the FieldCache it is also

[jira] Commented: (LUCENE-1485) Use OpenBitSet instead of BitVector in SegmentReader

2008-12-09 Thread Jason Rutherglen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654994#action_12654994 ] Jason Rutherglen commented on LUCENE-1485: -- This above test was using the -client

Bounds checking in BItVector

2008-12-09 Thread Jason Rutherglen
I ran another test on the speed of BitVector vs. OpenBitSet. Unless the DocIdSetIterator is faster for OpenBitSet vs an equivalent for BitVector, BV is faster when it's bounds checking is removed. I'm trying to figure out a good way to allow a modified version of BitVector that does not do bounds

[jira] Commented: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654970#action_12654970 ] Doug Cutting commented on LUCENE-1483: -- > But for IndexSearcher(Multi*Reader).search

[jira] Commented: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654962#action_12654962 ] Michael McCandless commented on LUCENE-1483: {quote} >> make a HitCollector th

[jira] Commented: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654940#action_12654940 ] Doug Cutting commented on LUCENE-1483: -- > make a HitCollector that gathers the result

[jira] Updated: (LUCENE-1485) Use OpenBitSet instead of BitVector in SegmentReader

2008-12-09 Thread Jason Rutherglen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Rutherglen updated LUCENE-1485: - Attachment: TestDeletedDocsSpeed.java TestDeletedDocsSpeed.java Executes get on BitVect

[jira] Updated: (LUCENE-1485) Use OpenBitSet instead of BitVector in SegmentReader

2008-12-09 Thread Jason Rutherglen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Rutherglen updated LUCENE-1485: - Description: Tried out BitVector.get vs OpenBitSet.get here's the results which are abou

[jira] Created: (LUCENE-1485) Use OpenBitSet instead of BitVector in SegmentReader

2008-12-09 Thread Jason Rutherglen (JIRA)
Use OpenBitSet instead of BitVector in SegmentReader Key: LUCENE-1485 URL: https://issues.apache.org/jira/browse/LUCENE-1485 Project: Lucene - Java Issue Type: Improvement Compon

[jira] Commented: (LUCENE-1475) Expose sub-IndexReaders from MultiReader or MultiSegmentReader

2008-12-09 Thread robert engels (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654924#action_12654924 ] robert engels commented on LUCENE-1475: --- That is not correct. By returning a non-nul

[jira] Commented: (LUCENE-1475) Expose sub-IndexReaders from MultiReader or MultiSegmentReader

2008-12-09 Thread Jason Rutherglen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654923#action_12654923 ] Jason Rutherglen commented on LUCENE-1475: -- RE: "It should return an empty array,

[jira] Created: (LUCENE-1484) Remove SegmentReader.document synchronization

2008-12-09 Thread Jason Rutherglen (JIRA)
Remove SegmentReader.document synchronization - Key: LUCENE-1484 URL: https://issues.apache.org/jira/browse/LUCENE-1484 Project: Lucene - Java Issue Type: Improvement Components: Index

[jira] Commented: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654922#action_12654922 ] Michael McCandless commented on LUCENE-1483: Hmmm. OK I think I see what

[jira] Updated: (LUCENE-1314) IndexReader.clone

2008-12-09 Thread Jason Rutherglen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Rutherglen updated LUCENE-1314: - Summary: IndexReader.clone (was: IndexReader.reopen(boolean force)) > IndexReader.clone

[jira] Commented: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654895#action_12654895 ] Mark Miller commented on LUCENE-1483: - Ill bench again after this issue is polished up

[jira] Commented: (LUCENE-1482) Replace infoSteram by a logging framework (SLF4J)

2008-12-09 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654875#action_12654875 ] Doug Cutting commented on LUCENE-1482: -- safeDebugMsg is protected in a public class,

Re: [jira] Commented: (LUCENE-1473) Implement standard Serialization across Lucene versions

2008-12-09 Thread Grant Ingersoll
See http://lucene.markmail.org/message/fu34tuomnqejchfj?q=RemoteSearchable for just such a proposal On Dec 8, 2008, at 1:52 PM, Doug Cutting (JIRA) wrote: [ https://issues.apache.org/jira/browse/LUCENE-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedComme

[jira] Commented: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654842#action_12654842 ] Mark Miller commented on LUCENE-1483: - bq.I think there should be very little impact t

[jira] Commented: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654839#action_12654839 ] Michael McCandless commented on LUCENE-1483: I think there should be very litt

[jira] Commented: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654834#action_12654834 ] Mark Miller commented on LUCENE-1483: - Ignore those first results entirely. It turns o

[jira] Commented: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654828#action_12654828 ] Yonik Seeley commented on LUCENE-1483: -- bq. Okay, I straightened things out, and now

[jira] Commented: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654822#action_12654822 ] Mark Miller commented on LUCENE-1483: - Okay, I straightened things out, and now it loo

[jira] Commented: (LUCENE-831) Complete overhaul of FieldCache API/Implementation

2008-12-09 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654820#action_12654820 ] Michael McCandless commented on LUCENE-831: --- Marvin, does KS/Lucy have something

[jira] Updated: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated LUCENE-1483: Comment: was deleted > Change IndexSearcher to use MultiSearcher semantics for sorted searches > -

[jira] Issue Comment Edited: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654812#action_12654812 ] [EMAIL PROTECTED] edited comment on LUCENE-1483 at 12/9/08 7:00 AM:

[jira] Issue Comment Edited: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654812#action_12654812 ] [EMAIL PROTECTED] edited comment on LUCENE-1483 at 12/9/08 6:55 AM:

[jira] Commented: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654812#action_12654812 ] Mark Miller commented on LUCENE-1483: - I'll be sure to include that info with the next

Re: [jira] Commented: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Yonik Seeley
On Tue, Dec 9, 2008 at 9:23 AM, Mark Miller <[EMAIL PROTECTED]> wrote: > Great, because that's prob the main optimation spot we have. I also made > things a bit difficult with the 50 merge factory. I'll try a 10 later. It's useful to report the number of segments in the index too. Even with high

Re: [jira] Commented: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Mark Miller
Great, because that's prob the main optimation spot we have. I also made things a bit difficult with the 50 merge factory. I'll try a 10 later. - Mark On Dec 9, 2008, at 9:20 AM, "Marvin Humphrey (JIRA)" <[EMAIL PROTECTED]> wrote: [ https://issues.apache.org/jira/browse/LUCENE-1483

[jira] Commented: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Marvin Humphrey (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654805#action_12654805 ] Marvin Humphrey commented on LUCENE-1483: - > Quick micro bench - did it twice and

[jira] Issue Comment Edited: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654798#action_12654798 ] [EMAIL PROTECTED] edited comment on LUCENE-1483 at 12/9/08 5:41 AM:

[jira] Commented: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654798#action_12654798 ] Mark Miller commented on LUCENE-1483: - Quick micro bench - did it twice and both times

[jira] Updated: (LUCENE-1471) Faster MultiSearcher.search merge docs

2008-12-09 Thread Luke Nezda (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Nezda updated LUCENE-1471: --- Attachment: multisearcher.take3.patch Doh. Sorry Michael, I reverted my local changes and tested th

[jira] Updated: (LUCENE-1482) Replace infoSteram by a logging framework (SLF4J)

2008-12-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-1482: --- Attachment: LUCENE-1482.patch Forgot to clean up some code in tests which made use of JDK logging.

[jira] Updated: (LUCENE-1482) Replace infoSteram by a logging framework (SLF4J)

2008-12-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-1482: --- Attachment: (was: LUCENE-1482.patch) > Replace infoSteram by a logging framework (SLF4J) > -

[jira] Commented: (LUCENE-1471) Faster MultiSearcher.search merge docs

2008-12-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654791#action_12654791 ] Mark Miller commented on LUCENE-1471: - Re: thread, Something makes me think a method m

[jira] Updated: (LUCENE-1482) Replace infoSteram by a logging framework (SLF4J)

2008-12-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-1482: --- Attachment: slf4j-nop-1.5.6.jar slf4j-api-1.5.6.jar LUCENE-1482.patch

[jira] Updated: (LUCENE-1482) Replace infoSteram by a logging framework (SLF4J)

2008-12-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-1482: --- Attachment: (was: LUCENE-1482.patch) > Replace infoSteram by a logging framework (SLF4J) > -

[jira] Updated: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated LUCENE-1483: Attachment: LUCENE-1483.patch I had meant to attach a patch, but then a bunch of stuff wasn't work

Re: [jira] Commented: (LUCENE-831) Complete overhaul of FieldCache API/Implementation

2008-12-09 Thread Mark Miller
Michael McCandless wrote: I think it does make sense (it's well defined). This is what the SubsearcherTopDocs.convertTopDoc method is doing (in the multisearcher.take2.patch on LUCENE-1471). In fact, returning by document order is a particularly trivial sort, since you'd just have to conca

Re: [jira] Commented: (LUCENE-831) Complete overhaul of FieldCache API/Implementation

2008-12-09 Thread Mark Miller
Michael McCandless wrote: Mark Miller wrote: Mark Miller wrote: Mark Miller wrote: Which new sort stuff are you referring to? Is it LUCENE-1471? Yes. First thing I did was try and patch this in, but the sort tests failed. It would be the right order, but like the two center docs would

Re: [jira] Commented: (LUCENE-831) Complete overhaul of FieldCache API/Implementation

2008-12-09 Thread Michael McCandless
Mark Miller wrote: Michael McCandless wrote: Mark Miller wrote: Mark Miller wrote: Which new sort stuff are you referring to? Is it LUCENE-1471? Yes. First thing I did was try and patch this in, but the sort tests failed. It would be the right order, but like the two center docs wo

[jira] Commented: (LUCENE-1471) Faster MultiSearcher.search merge docs

2008-12-09 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654755#action_12654755 ] Michael McCandless commented on LUCENE-1471: Luke, it looks like the 2nd patch

Re: [jira] Commented: (LUCENE-831) Complete overhaul of FieldCache API/Implementation

2008-12-09 Thread Michael McCandless
Mark Miller wrote: Mark Miller wrote: Mark Miller wrote: Which new sort stuff are you referring to? Is it LUCENE-1471? Yes. First thing I did was try and patch this in, but the sort tests failed. It would be the right order, but like the two center docs would be reversed or something.

[jira] Commented: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for sorted searches

2008-12-09 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654751#action_12654751 ] Michael McCandless commented on LUCENE-1483: Mark did you intend to attach the