Re: [jira] Created: (LUCENE-1535) Make tests using java.util.Random reproducible on failure

2009-02-04 Thread Michael McCandless
Chris Hostetter wrote: PS: "It would be really nice if i had several million dollars, because that way i could spend it." (let's see what you guys can do with that one) Alas that one is quite a bit more challenging... Mike ---

[jira] Commented: (LUCENE-1536) if a filter can support random access API, we should use it

2009-02-04 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670455#action_12670455 ] Michael McCandless commented on LUCENE-1536: Some ideas / further things to ex

Re: [jira] Created: (LUCENE-1535) Make tests using java.util.Random reproducible on failure

2009-02-04 Thread Chris Hostetter
: Make tests using java.util.Random reproducible on failure Whoa ... i make an off the cuff comment that i forget about 10 hours later, and the next thing i know Uwe and Michael have made it reality. +1. PS: "It would be really nice if i had several million dollars, because that way i could

[jira] Commented: (LUCENE-1536) if a filter can support random access API, we should use it

2009-02-04 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670452#action_12670452 ] Michael McCandless commented on LUCENE-1536: It's a ridiculous amount of data

[jira] Updated: (LUCENE-1536) if a filter can support random access API, we should use it

2009-02-04 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-1536: --- Attachment: LUCENE-1536.patch Attaching patch I'm using to run tests. NOTE: this is

[jira] Commented: (LUCENE-1536) if a filter can support random access API, we should use it

2009-02-04 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670449#action_12670449 ] Michael McCandless commented on LUCENE-1536: Test results: ||%tg Filter||Quer

[jira] Created: (LUCENE-1536) if a filter can support random access API, we should use it

2009-02-04 Thread Michael McCandless (JIRA)
if a filter can support random access API, we should use it --- Key: LUCENE-1536 URL: https://issues.apache.org/jira/browse/LUCENE-1536 Project: Lucene - Java Issue Type: Improvement

[jira] Commented: (LUCENE-1535) Make tests using java.util.Random reproducible on failure

2009-02-04 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670444#action_12670444 ] Michael McCandless commented on LUCENE-1535: bq. The @link reference in the ja

[jira] Commented: (LUCENE-1535) Make tests using java.util.Random reproducible on failure

2009-02-04 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670421#action_12670421 ] Uwe Schindler commented on LUCENE-1535: --- Hi Mike, all tests pass here, looks good.

[jira] Updated: (LUCENE-1535) Make tests using java.util.Random reproducible on failure

2009-02-04 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-1535: --- Attachment: LUCENE-1535.patch OK I replaced many of the "new Random(...)"'s in tests

Re: failure in TestTrieRangeQuery

2009-02-04 Thread Stefan Trcek
On Wednesday 04 February 2009 12:01:54 Michael McCandless wrote: > Though: I thought JUnit invokes tests in the sequential order as they >   are defined in your class?  (I'm not sure about this... it's just > what seems to be the case). Just looking at one of my unit tests: It reorders in some cas

[jira] Assigned: (LUCENE-1535) Make tests using java.util.Random reproducible on failure

2009-02-04 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless reassigned LUCENE-1535: -- Assignee: Michael McCandless > Make tests using java.util.Random reproducible

[jira] Commented: (LUCENE-1531) contrib/xml-query-parser, BoostingTermQuery support

2009-02-04 Thread Mark Harwood (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670341#action_12670341 ] Mark Harwood commented on LUCENE-1531: -- Looks good to me. The only thing I would be t

[jira] Updated: (LUCENE-1535) Make tests using java.util.Random reproducible on failure

2009-02-04 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-1535: -- Attachment: LUCENE-1535.patch This is the patch. As only TrieRangeQuery uses the new random fu

[jira] Created: (LUCENE-1535) Make tests using java.util.Random reproducible on failure

2009-02-04 Thread Uwe Schindler (JIRA)
Make tests using java.util.Random reproducible on failure - Key: LUCENE-1535 URL: https://issues.apache.org/jira/browse/LUCENE-1535 Project: Lucene - Java Issue Type: Test Affects V

Re: failure in TestTrieRangeQuery

2009-02-04 Thread Michael McCandless
Great!! Yes please open JIRA. Mike Uwe Schindler wrote: Hi, atached is a patch for LuceneTestCase and a implementation in TestTrieRangeQuery. It overrides the protected method runTest() and inserts a try-catch around the super.runTest() call. Two new methods newRandom() and newRandom(lo

RE: failure in TestTrieRangeQuery

2009-02-04 Thread Uwe Schindler
I forgot to mention: If a test fails, the message using the seed is printed to stdout. The developer can then change the test temporarily: LuceneTestCase.newRandom() -> LuceneTestCase.newRandom(long) using the seed from the failed test printout. Uwe - Uwe Schindler H.-H.-Meier-Allee 63, D-2

RE: failure in TestTrieRangeQuery

2009-02-04 Thread Uwe Schindler
Hi, atached is a patch for LuceneTestCase and a implementation in TestTrieRangeQuery. It overrides the protected method runTest() and inserts a try-catch around the super.runTest() call. Two new methods newRandom() and newRandom(long) are available for the test case. As each test case is run in an

Re: failure in TestTrieRangeQuery

2009-02-04 Thread Michael McCandless
Sweet! I was wondering (but didn't dig) whether we could extend LuceneTestCase to expose a getRandom() method (which'd record the seed), and then override invocation of a test (which I'm not sure JUnit allows you to do) to add a try/finally that prints out the seeds. Though: I thought JU

RE: failure in TestTrieRangeQuery

2009-02-04 Thread Uwe Schindler
Hi, > > : By allowing Random to randomly seed itself, we effectively test a > > much > > : much larger space, ie every time we all run the test, it's > > different. We can > > : potentially cast a much larger net than a fixed seed. > > > > i guess i'm just in favor of less randomness and more ite