Re: MergePolicy and IndexWriter methods argument

2009-07-26 Thread Shai Erera
I'll open an issue and work out a patch. Though this deprecation stuff is what I was worried of - they always tend to expand more than I plan to :). Shai On Sun, Jul 26, 2009 at 9:44 PM, Michael McCandless < luc...@mikemccandless.com> wrote: > I agree it's messy now. I think requiring the write

[jira] Updated: (LUCENE-1460) Change all contrib TokenStreams/Filters to use the new TokenStream API

2009-07-26 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-1460: Attachment: LUCENE-1460.patch with analyzers/compound > Change all contrib TokenStreams/Filters t

[jira] Commented: (LUCENE-1460) Change all contrib TokenStreams/Filters to use the new TokenStream API

2009-07-26 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735444#action_12735444 ] Robert Muir commented on LUCENE-1460: - Michael, I looked at your patch. What do you

[jira] Updated: (LUCENE-1758) improve arabic analyzer: light8 -> light10

2009-07-26 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-1758: Attachment: LUCENE-1758.patch also updated the stopwords list, it was in need of much improvement.

Re: MergePolicy and IndexWriter methods argument

2009-07-26 Thread Michael McCandless
I agree it's messy now. I think requiring the writer to be specified on creating the merge policy would make sense. You can't safely share a LMP today across multiple writers, yet the class "pretends" that you can... You'd also need to deprecate the public methods that take a writer in favor of

MergePolicy and IndexWriter methods argument

2009-07-26 Thread Shai Erera
Hi While reading LogMergePolicy I noticed that it uses IndexWriter's member and method arg inconsistently: 1) Some methods that receive IW as a parameer, do: this.indexWriter = indexWriter, and then use the member instance. 2) Others set the member instance, but continue to use the method arg. 3)

[jira] Updated: (LUCENE-1460) Change all contrib TokenStreams/Filters to use the new TokenStream API

2009-07-26 Thread Michael Busch (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Busch updated LUCENE-1460: -- Attachment: lucene-1460.patch Some more progress - mostly in contrib/memory. > Change all con

[jira] Commented: (LUCENE-1762) Slightly more readable code in TermAttributeImpl

2009-07-26 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735358#action_12735358 ] Uwe Schindler commented on LUCENE-1762: --- bq. setOnlyUseNewAPI(false) does not exist,