I know this docs. We also had the same discussion on java-dev half a year
ago.
Generics are not visible in the compiled java code, they are "erasured" and
replaced by their upper type (at least Object, like for Collection API). "E
Extends Attribute" in my example would be replaced by Attribute.
[
https://issues.apache.org/jira/browse/LUCENE-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745803#action_12745803
]
Uwe Schindler edited comment on LUCENE-1826 at 8/20/09 10:35 PM:
---
[
https://issues.apache.org/jira/browse/LUCENE-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745803#action_12745803
]
Uwe Schindler commented on LUCENE-1826:
---
bq. without the Tokenizer.reset(Reader, Att
I guess you could consider that you have to use 1.5 the break?
But I think that goes without saying ...
Mark Miller wrote:
> bq. While technically it breaks back compatibility,
>
> How does it break back compatibility? Generics are only compile time -
> they simply don't exist in the binary. Jav
bq. While technically it breaks back compatibility,
How does it break back compatibility? Generics are only compile time -
they simply don't exist in the binary. Java itself is extremely back
compat, so you can still use StringBuffer and the rest. I didn't find
anything in the archives or the wik
Please read the archives on the 1.5 move. We have discussed it many
times. There is also a Wiki page on it under the committers section.
While technically it breaks back compatibility, we are going forward
with it and we decided to allow generics, etc. right from the start.
We also didn
[
https://issues.apache.org/jira/browse/LUCENE-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller reopened LUCENE-584:
I think I have tracked down this issue as the one changing things most
regarding Scorer documentation
[
https://issues.apache.org/jira/browse/LUCENE-1834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-1834:
Attachment: LUCENE-1834.patch
> remove unused code in SmartChineseAnalyzer hmm pkg
> -
remove unused code in SmartChineseAnalyzer hmm pkg
--
Key: LUCENE-1834
URL: https://issues.apache.org/jira/browse/LUCENE-1834
Project: Lucene - Java
Issue Type: Task
Components: contr
[
https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745756#action_12745756
]
Mark Miller edited comment on LUCENE-1821 at 8/20/09 6:12 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745756#action_12745756
]
Mark Miller commented on LUCENE-1821:
-
{quote}
howevever, this method is actually also
[
https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745754#action_12745754
]
Tim Smith commented on LUCENE-1821:
---
in the case of the getDocIdSet() method, i would sa
[
https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745735#action_12745735
]
Mark Miller commented on LUCENE-1821:
-
I'm still not a fan of giving access to the upp
[
https://issues.apache.org/jira/browse/LUCENE-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745724#action_12745724
]
Tim Smith commented on LUCENE-1826:
---
without the Tokenizer.reset(Reader, AttributeSource
[
https://issues.apache.org/jira/browse/LUCENE-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745723#action_12745723
]
Mark Miller commented on LUCENE-1827:
-
If no one objects to this patch I'm going to co
[
https://issues.apache.org/jira/browse/LUCENE-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1826:
--
Summary: All Tokenizer implementations should have constructors that take
AttributeSource and
[
https://issues.apache.org/jira/browse/LUCENE-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745713#action_12745713
]
Uwe Schindler commented on LUCENE-1826:
---
I was thinking about that, too. But it was
[
https://issues.apache.org/jira/browse/LUCENE-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745708#action_12745708
]
Uwe Schindler commented on LUCENE-1833:
---
...and also StringBuffers!
> When we move
This is either a bug (its meant to be something else) or a harmless
mistake - someone check it out?
// set setMultiTermRewriteMethod for WildcardQueryNode and
PrefixWildcardQueryNode
if (node instanceof WildcardQueryNode || node instanceof
ParametricRangeQueryNode
|| node instance
Not really, there is no reason fort hat in my opinion. And Token.copyTo()
does not do this, but should then!
I think, remove it. Strings can always by kept, as they are final and
unmodifiable.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
When we move to java 1.5 in 3.0 we should replace all Interger, Long, etc
construction with .valueOf
Key: LUCENE-1833
URL: https://issues.apache.org/jira/browse/L
Getting into the nitpick stuff ;)
In TypeAttributeImpl:
public void copyTo(AttributeImpl target) {
TypeAttribute t = (TypeAttribute) target;
t.setType(new String(type));
}
The class uses type.equals and type.hashCode - is there any reason to
create a new String object here? Just use
minor/nitpick TermInfoReader bug ?
--
Key: LUCENE-1832
URL: https://issues.apache.org/jira/browse/LUCENE-1832
Project: Lucene - Java
Issue Type: Bug
Reporter: Mark Miller
Priority: Triv
[
https://issues.apache.org/jira/browse/LUCENE-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler resolved LUCENE-1831.
---
Resolution: Fixed
Committed rev 806381
> TokenWrapperAttributeFactory, CachingWrapperFilter
[
https://issues.apache.org/jira/browse/LUCENE-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745697#action_12745697
]
Mark Miller commented on LUCENE-1760:
-
I also think it couldn't hurt to add some javad
[
https://issues.apache.org/jira/browse/LUCENE-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1831:
--
Attachment: LUCENE-1831.patch
Forgot a static xor for a difference in hashCode.
> TokenWrappe
[
https://issues.apache.org/jira/browse/LUCENE-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1831:
--
Attachment: LUCENE-1831.patch
I will commit this shortly.
> TokenWrapperAttributeFactory, Cac
[
https://issues.apache.org/jira/browse/LUCENE-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745692#action_12745692
]
Uwe Schindler commented on LUCENE-1831:
---
I implemented the two hashCodes. The wrappe
[
https://issues.apache.org/jira/browse/LUCENE-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745689#action_12745689
]
Mark Miller commented on LUCENE-1831:
-
I disagree - whatever a classes original intent
[
https://issues.apache.org/jira/browse/LUCENE-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745688#action_12745688
]
Uwe Schindler commented on LUCENE-1831:
---
This class is used internally only. There i
[
https://issues.apache.org/jira/browse/LUCENE-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler reassigned LUCENE-1831:
-
Assignee: Uwe Schindler (was: Mark Miller)
> TokenWrapperAttributeFactory, CachingWrapp
[
https://issues.apache.org/jira/browse/LUCENE-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller updated LUCENE-1831:
Summary: TokenWrapperAttributeFactory, CachingWrapperFilterHelper
implements equals and so should
[
https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Smith updated LUCENE-1821:
--
Fix Version/s: 2.9
Marking as fix for 2.9 so this gets looked over real good prior to 2.9 going
out (
TokenWrapperAttributeFactory implements equals and so should also implement
hashCode
Key: LUCENE-1831
URL: https://issues.apache.org/jira/browse/LUCENE-1831
Project:
[
https://issues.apache.org/jira/browse/LUCENE-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1825:
--
Attachment: LUCENE-1825.patch
Attached is a first patch, that fixes the wrong getAttribute() c
[
https://issues.apache.org/jira/browse/LUCENE-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller reopened LUCENE-1760:
-
Would love to have some sample code, but at a min we have to update javadocs to
have full contract
[
https://issues.apache.org/jira/browse/LUCENE-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745671#action_12745671
]
Mark Miller commented on LUCENE-1827:
-
I want to remove PayloadQuery marking interface
BoostingNearQuery doesn't have hashCode/equals
--
Key: LUCENE-1830
URL: https://issues.apache.org/jira/browse/LUCENE-1830
Project: Lucene - Java
Issue Type: Bug
Components: Search
[
https://issues.apache.org/jira/browse/LUCENE-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745667#action_12745667
]
Tim Smith commented on LUCENE-1826:
---
This is further complicated by the fact that Tokeni
[
https://issues.apache.org/jira/browse/LUCENE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan-Pascal updated LUCENE-1829:
---
Attachment: contrib-queryparser-javacc.patch
This patch caused 'ant javacc' to also run in contrib/q
'ant javacc' in root project should also properly create contrib/queryparser
Java files
---
Key: LUCENE-1829
URL: https://issues.apache.org/jira/browse/LUCENE-1829
Pr
[
https://issues.apache.org/jira/browse/LUCENE-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Smith updated LUCENE-1828:
--
Attachment: LUCENE-1828.patch
Patch to call TokenStream.reset() and TokenStream.end() in MemoryIndex
[
https://issues.apache.org/jira/browse/LUCENE-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745624#action_12745624
]
Tim Smith commented on LUCENE-1825:
---
I agree that a 'more helpful' error message may not
[
https://issues.apache.org/jira/browse/LUCENE-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler reassigned LUCENE-1825:
-
Assignee: Uwe Schindler
In principle you should always use addAttribute() when consuming
MemoryIndex doesn't call TokenStream.reset() and TokenStream.end()
--
Key: LUCENE-1828
URL: https://issues.apache.org/jira/browse/LUCENE-1828
Project: Lucene - Java
Issue Type:
It would *not* break apps without generics, if the "upper" type is the same
(which is easily fulfilled by my example with the AttributeSource). The
whole 1.5 Java Collection API uses generics and 1.4 programs still run.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaph
[
https://issues.apache.org/jira/browse/LUCENE-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745617#action_12745617
]
Jason Rutherglen commented on LUCENE-965:
-
The link http://www.ece.udel.edu/~hfang/
So I am trying to give a bit of time for rapid fixes to come in, and
upgrade issues to be addressed before we actually start a code freeze
(I'm getting the feeling noone is going to come out of the woodwork to
be RM). I'd love to at least give that another day or two.
We are building up a couple m
[
https://issues.apache.org/jira/browse/LUCENE-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller updated LUCENE-1827:
Attachment: LUCENE-1827.patch
This is what I would do - merge boostingfunctiontermquery into
boos
[
https://issues.apache.org/jira/browse/LUCENE-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745608#action_12745608
]
Hui Fang commented on LUCENE-965:
-
Hello everyone,
We have re-implemented the retrieval f
Make the Payload Boosting Queries consistent
Key: LUCENE-1827
URL: https://issues.apache.org/jira/browse/LUCENE-1827
Project: Lucene - Java
Issue Type: Improvement
Components: Search
And what is the purpose of the marker interface PayloadQuery?
Is there a use case for this?
- Mark
Mark Miller wrote:
> In a similar line though, BoostingFunctionTermQuery doesn't really fit
> with BoostingNearQuery. I see part of why its not called
> BoostingTermQuery is because BoostingTermQu
In a similar line though, BoostingFunctionTermQuery doesn't really fit
with BoostingNearQuery. I see part of why its not called
BoostingTermQuery is because BoostingTermQuery is deprecated - but why
can't the BoostingFunctionTermQuery impl replace BoostingTermQuery with
average as the default? (wh
[
https://issues.apache.org/jira/browse/LUCENE-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir reassigned LUCENE-1793:
---
Assignee: Robert Muir
> remove custom encoding support in Greek/Russian Analyzers
>
My fault - it does! I was just checking JavaDocs and this was misleading:
Payload scores are averaged across term occurrences in the document.
I'll update to be less ambiguous eg it takes a function that defaults to
average.
- Mark
Simon Willnauer wrote:
> +1
>
> On Thu, Aug 20, 2009 at 8:21
+1
On Thu, Aug 20, 2009 at 8:21 PM, Michael
McCandless wrote:
> +1
>
> Mike
>
> On Thu, Aug 20, 2009 at 11:08 AM, Mark Miller wrote:
>> BoostingNearQuery averages payloads - shouldn't it take a
>> PayloadFunction as well?
>>
>> --
>> - Mark
>>
>> http://www.lucidimagination.com
>>
>>
>>
>>
>>
+1
Mike
On Thu, Aug 20, 2009 at 11:08 AM, Mark Miller wrote:
> BoostingNearQuery averages payloads - shouldn't it take a
> PayloadFunction as well?
>
> --
> - Mark
>
> http://www.lucidimagination.com
>
>
>
>
> -
> To unsubscribe,
[
https://issues.apache.org/jira/browse/LUCENE-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745531#action_12745531
]
Mark Miller commented on LUCENE-1826:
-
bq. didn't want to overstep my bounds suggestin
[
https://issues.apache.org/jira/browse/LUCENE-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745530#action_12745530
]
Tim Smith commented on LUCENE-1826:
---
NOTE: for me, this is just a "nice to have"
I curr
[
https://issues.apache.org/jira/browse/LUCENE-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Smith updated LUCENE-1825:
--
Fix Version/s: 2.9
> AttributeSource.getAttribute() should throw better IllegalArgumentException
> ---
[
https://issues.apache.org/jira/browse/LUCENE-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Smith updated LUCENE-1826:
--
Fix Version/s: 2.9
> All Tokenizer implementations should have constructor that takes an
> AttributeS
[
https://issues.apache.org/jira/browse/LUCENE-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745523#action_12745523
]
Tim Smith commented on LUCENE-1826:
---
i'll do that from now on (feel free to boot them if
[
https://issues.apache.org/jira/browse/LUCENE-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745522#action_12745522
]
Mark Miller commented on LUCENE-1826:
-
To make sure these issues are considered for 2.
On Thu, Aug 20, 2009 at 11:44 AM, Tim Smith wrote:
> Also, the javadoc should also mark that the consumer call end() as step
> 5 (don't think this was added when end() was put in)
And close()
is there a way these could be consolidated?
-Yonik
http://www.lucidimagination.com
> -- Tim
>
> Ma
All Tokenizer implementations should have constructor that takes an
AttributeSource
---
Key: LUCENE-1826
URL: https://issues.apache.org/jira/browse/LUCENE-1826
Project: L
[
https://issues.apache.org/jira/browse/LUCENE-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745514#action_12745514
]
Mark Miller commented on LUCENE-1825:
-
Gotchya - in the summary it said you were looki
[
https://issues.apache.org/jira/browse/LUCENE-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745508#action_12745508
]
Tim Smith commented on LUCENE-1825:
---
Updated getAttribute() on AttributeSource as follow
[
https://issues.apache.org/jira/browse/LUCENE-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745502#action_12745502
]
Tim Smith commented on LUCENE-1825:
---
Looked a little closer on this and it looks like if
[
https://issues.apache.org/jira/browse/LUCENE-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745472#action_12745472
]
Mark Miller commented on LUCENE-1825:
-
Have a proposed patch? Doesn't look easy - I do
AttributeSource.getAttribute() should throw better IllegalArgumentException
---
Key: LUCENE-1825
URL: https://issues.apache.org/jira/browse/LUCENE-1825
Project: Lucene - Java
[
https://issues.apache.org/jira/browse/LUCENE-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-1793:
Lucene Fields: [New, Patch Available] (was: [New])
Fix Version/s: 2.9
Setting to 2.9
I would
[
https://issues.apache.org/jira/browse/LUCENE-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-1793:
Attachment: LUCENE-1793.patch
updated patch with "removed in next release" changed to "removed in
Also, the javadoc should also mark that the consumer call end() as step
5 (don't think this was added when end() was put in)
-- Tim
Mark Miller wrote:
> As a new user, reading the TokenStream javadoc is a bit intimidating I
> think.
>
> One thing that might help I think, is adding just a bit of
As a new user, reading the TokenStream javadoc is a bit intimidating I
think.
One thing that might help I think, is adding just a bit of example code
to the following section:
The workflow of the new TokenStream API is as follows:
1. Instantiation of TokenStream/TokenFilters which add/get attrib
BoostingNearQuery averages payloads - shouldn't it take a
PayloadFunction as well?
--
- Mark
http://www.lucidimagination.com
-
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: j
[
https://issues.apache.org/jira/browse/LUCENE-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745456#action_12745456
]
Mark Miller commented on LUCENE-1793:
-
We have not started code freeze yet - I'd depre
I just made some fixes/updates to org.apache.lucene.search package.html -
I started updating the Scorer section a bit, but it needs more work. If
someone involved in that those
Scorer issues could help finish up, that would be great. I don't think
there is much to do.
--
- Mark
http://www.lucid
[
https://issues.apache.org/jira/browse/LUCENE-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-1793:
Attachment: LUCENE-1793.patch
patch with more javadocs verbage.
When do we want to deprecate thes
I don't think thats an issue? Generics use type erasure - its just
compile time - so its binary compatible with any previous code that
doesn't use generics.
- Mark
Shai Erera wrote:
> What will be w/ generics? Won't they break cack-compat as soon as we
> add them (e.g., if we move to accepting pa
[
https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745436#action_12745436
]
Tim Smith commented on LUCENE-1821:
---
true, MultiSearcher does kink things up some (and t
What will be w/ generics? Won't they break cack-compat as soon as we add
them (e.g., if we move to accepting parameters as generics - it may break an
application which does not use generics yet). I think that the move to 1.5
needs to include the generics as well, unless we're willing to break
back-
Michael McCandless wrote:
> On Wed, Aug 19, 2009 at 6:21 PM, Mark Miller wrote:
>
>
>> I forgot about this oddity. Its so weird. Its like we are doing two
>> releases on top of each other - it just seems confusing.
>>
>
> I'm also not wed to the "fast turnaround" (remove deprecations, switc
[
https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745430#action_12745430
]
Mark Miller commented on LUCENE-1821:
-
I'm still not sold on this - these use cases do
[
https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745423#action_12745423
]
Tim Smith commented on LUCENE-1821:
---
I can work up another patch where the Searcher is p
[
https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745418#action_12745418
]
Mark Miller commented on LUCENE-1821:
-
bq. It can ease the transition for users doing
[
https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745416#action_12745416
]
Tim Smith commented on LUCENE-1821:
---
It would also be nice if the top level Searcher wer
On Wed, Aug 19, 2009 at 6:21 PM, Mark Miller wrote:
> I forgot about this oddity. Its so weird. Its like we are doing two
> releases on top of each other - it just seems confusing.
I'm also not wed to the "fast turnaround" (remove deprecations, switch
to generics) 3.0 release.
We could, instead,
[
https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745367#action_12745367
]
Michael McCandless commented on LUCENE-1821:
I think we should in fact add thi
88 matches
Mail list logo
