[
https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller updated LUCENE-1929:
Description:
Sucks. Will throw a NullPointer exception.
Only NumericRangeQuery will throw the ex
[
https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller updated LUCENE-1929:
Summary: Highlighter doesn't support NumericQuery or deprecated RangeQuery
(was: Highlighter does
[
https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760076#action_12760076
]
Mark Miller commented on LUCENE-1929:
-
bq. Another option to fix Solr's highlighter is
[
https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760074#action_12760074
]
Uwe Schindler commented on LUCENE-1929:
---
Another option to fix Solr's highlighter is
[
https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760072#action_12760072
]
Mark Miller commented on LUCENE-1929:
-
bq. I wasn't blaming you for the problem
In fa
[
https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760071#action_12760071
]
Mark Miller commented on LUCENE-1929:
-
Ah, thanks - didn't catch that. Wondered how it
[
https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760070#action_12760070
]
Uwe Schindler commented on LUCENE-1929:
---
bq. On a side note, its a bummer we seem to
[
https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760068#action_12760068
]
Mark Miller commented on LUCENE-1929:
-
bq. and not a backwards break, as both classes
[
https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760067#action_12760067
]
Mark Miller commented on LUCENE-1929:
-
I realize the difficulties - I wasn't blaming y
[
https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760066#action_12760066
]
Uwe Schindler commented on LUCENE-1929:
---
bq. In fact, its probably wrong - but at th
[
https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760064#action_12760064
]
Mark Miller commented on LUCENE-1929:
-
bq. so whether return null from getTerm is righ
Yeah, I agree Hoss - we shouldn't pull the rug in either case - if you
could count on it before and its worked out well, its more of a hassle
to push out a surprise than to keep the known behavior.
More of an aside from me ;)
Chris Hostetter wrote:
> : That is my opinion, too. Closing the readers
[
https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760062#action_12760062
]
Mark Miller commented on LUCENE-1929:
-
Yeah - eventually (as in when getTerm() is remo
: That is my opinion, too. Closing the readers should be done by the caller in
I don't disagree with either of you, but...
: a finally block and not automatically by the IW. I only wanted to confirm,
: that the behaviour of 2.9 did not change. Closing readers two times is not a
...i wanted to t
[
https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760061#action_12760061
]
Uwe Schindler commented on LUCENE-1929:
---
I read what stands in SOLR-1221: It calls M
[
https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760060#action_12760060
]
Uwe Schindler commented on LUCENE-1929:
---
Does it throw a NPE for every "unknown" que
[
https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760056#action_12760056
]
Mark Miller commented on LUCENE-1929:
-
So making NumericQuery Hilightable is not going
Highlighter doesn't support NumericQuery
Key: LUCENE-1929
URL: https://issues.apache.org/jira/browse/LUCENE-1929
Project: Lucene - Java
Issue Type: Bug
Components: contrib/highlighter
Af
> I guess the fact that Lucene closes it is a legacy we may be stuck with
> - but I think it encourages bad practice code. There is plenty of room
> for an exception to be thrown before the Reader is sure to be closed in
> a finally block.
>
> Part of why its standard convention to close your own
I guess the fact that Lucene closes it is a legacy we may be stuck with
- but I think it encourages bad practice code. There is plenty of room
for an exception to be thrown before the Reader is sure to be closed in
a finally block.
Part of why its standard convention to close your own I think, rat
: So in 2.9, the Reader is correctly closed, if the TokenStream chain is
: correctly set up, passing all close() calls to the delegate.
Thanks for digging into that Uwe.
So Daniel: The ball is in your court here: what analyzer /
tokenizer+tokenfilters is your app using in the cases where you se
[
https://issues.apache.org/jira/browse/LUCENE-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760031#action_12760031
]
Michael McCandless commented on LUCENE-1458:
The codec is per segment. Howeve
Sorry my last reply was nonsense. Even if you reuse TokenStreams, the
consumer should close the stream at the end of operations.
And this is for sure done by the DocInverterPerField (finally-block within
TokenStream.close()). Maybe the user with the problem has created a
TokenFilter or something l
I think I know, what is different than earlier versions:
The close of the Reader is done by Tokenizer.close(). As in 2.9.0 we did
much work to get all the Tokenizers reusable, there is the following
problem:
The Reader is only closed, if you call Tokenizer.close(), but not, if you
call Tokenizer.
How does your test perform with 2.4.1 ?
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: [email protected]
> -Original Message-
> From: Chris Hostetter [mailto:[email protected]]
> Sent: Sunday, September 27, 2009 3:34 AM
> To: Lucene Dev
> Subj
25 matches
Mail list logo
