Re: 2.9.1

2009-10-17 Thread John Wang
Hi guys: Maybe it is not a big deal. But I would still like to know why in MultiTermDocs, if term is not null, termDocs(term) is not called, rather termDocs() is. Thanks -John On Sat, Oct 17, 2009 at 10:16 AM, John Wang wrote: > Oh ok. I was thinking that if term is not null, termDocs(Term

[jira] Updated: (LUCENE-1257) Port to Java5

2009-10-17 Thread Kay Kay (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kay Kay updated LUCENE-1257: Attachment: LUCENE-1257_org_apache_lucene_index.patch Patch across a good number of files in org.apache.lu

[jira] Issue Comment Edited: (LUCENE-1989) CharArraySet cannot be made generic, because it violates the Set interface

2009-10-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766899#action_12766899 ] Uwe Schindler edited comment on LUCENE-1989 at 10/17/09 1:27 PM: ---

Re: Whitespace inside Generics parameters

2009-10-17 Thread Michael Busch
+1 for (3) Michael On 10/17/09 3:55 AM, Uwe Schindler wrote: Just because I came along a lot of new Generics declarations: How should we handle generics parameters in the source code? There are more possibilities: 1. Map 2. Map 3. Map Sun's Java code in src.jar of their JDK always uses (3)[

[jira] Commented: (LUCENE-1257) Port to Java5

2009-10-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766948#action_12766948 ] Uwe Schindler commented on LUCENE-1257: --- Committed: LUCENE-1257-DocFieldProcessor

[jira] Commented: (LUCENE-1257) Port to Java5

2009-10-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766949#action_12766949 ] Uwe Schindler commented on LUCENE-1257: --- Kay Kay: You can also provide only one comb

Re: 2.9.1

2009-10-17 Thread Mark Miller
Not that I have any comfort with spans - but I'm good with a shovel ;) Mark Miller wrote: > Got it I think. > > Michael McCandless wrote: > >> I've marked fix for 2.9.1. Can someone w/ comfort in this (span >> queries) have a look? >> >> If nobody jumps after a while I'll try to dig in... >> >

Re: 2.9.1

2009-10-17 Thread John Wang
Oh ok. I was thinking that if term is not null, termDocs(Term) would be called. -John On Sat, Oct 17, 2009 at 10:12 AM, Michael McCandless < luc...@mikemccandless.com> wrote: > I think this code is correct? The null is forwarded so SegmentReader > returns AllDocsEnum. > > Mike > > On Sat, Oct 17

Re: 2.9.1

2009-10-17 Thread Michael McCandless
I think this code is correct? The null is forwarded so SegmentReader returns AllDocsEnum. Mike On Sat, Oct 17, 2009 at 1:09 PM, John Wang wrote: > In DirectoryReader$MultiTermDocs implementation: > in method:  protected TermDocs termDocs(IndexReader reader) > return term==null ? reader.termDocs

Re: 2.9.1

2009-10-17 Thread Mark Miller
Got it I think. Michael McCandless wrote: > I've marked fix for 2.9.1. Can someone w/ comfort in this (span > queries) have a look? > > If nobody jumps after a while I'll try to dig in... > > Mike > > On Sat, Oct 17, 2009 at 11:11 AM, Yonik Seeley > wrote: > >> On Wed, Oct 14, 2009 at 5:39 PM

[jira] Updated: (LUCENE-1986) NPE in NearSpansUnordered from PayloadNearQuery

2009-10-17 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated LUCENE-1986: Attachment: LUCENE-1986.patch > NPE in NearSpansUnordered from PayloadNearQuery >

[jira] Updated: (LUCENE-1986) NPE in NearSpansUnordered from PayloadNearQuery

2009-10-17 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-1986: --- Fix Version/s: 3.0 2.9.1 > NPE in NearSpansUnordered from Payload

Re: 2.9.1

2009-10-17 Thread Michael McCandless
I've marked fix for 2.9.1. Can someone w/ comfort in this (span queries) have a look? If nobody jumps after a while I'll try to dig in... Mike On Sat, Oct 17, 2009 at 11:11 AM, Yonik Seeley wrote: > On Wed, Oct 14, 2009 at 5:39 PM, Michael McCandless > wrote: >> I can cut the 2.9.1 release, b

Re: 2.9.1

2009-10-17 Thread John Wang
In DirectoryReader$MultiTermDocs implementation:in method: protected TermDocs termDocs(IndexReader reader) return term==null ? reader.termDocs(null) : reader.termDocs(); Is this correct? Shouldn't it be: return term==null ? reader.termDocs() : reader.termDocs(term); Thanks -John On Sat, Oc

[jira] Commented: (LUCENE-1458) Further steps towards flexible indexing

2009-10-17 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766940#action_12766940 ] Michael McCandless commented on LUCENE-1458: Ahh, I just changed your seek to

[jira] Updated: (LUCENE-1257) Port to Java5

2009-10-17 Thread Kay Kay (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kay Kay updated LUCENE-1257: Attachment: LUCENE-1257-DocFieldProcessorPerThread.patch > Port to Java5 > - > >

[jira] Updated: (LUCENE-1257) Port to Java5

2009-10-17 Thread Kay Kay (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kay Kay updated LUCENE-1257: Attachment: LUCENE-1257-DirectoryReader.patch > Port to Java5 > - > > Key: LUC

[jira] Updated: (LUCENE-1257) Port to Java5

2009-10-17 Thread Kay Kay (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kay Kay updated LUCENE-1257: Attachment: LUCENE-1257-ConcurrentMergeScheduler.patch > Port to Java5 > - > >

[jira] Updated: (LUCENE-1257) Port to Java5

2009-10-17 Thread Kay Kay (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kay Kay updated LUCENE-1257: Attachment: LUCENE-1257-CompoundFileReaderWriter.patch > Port to Java5 > - > >

[jira] Updated: (LUCENE-1257) Port to Java5

2009-10-17 Thread Kay Kay (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kay Kay updated LUCENE-1257: Attachment: LUCENE-1257-CheckIndex.patch > Port to Java5 > - > > Key: LUCENE-1

[jira] Commented: (LUCENE-1257) Port to Java5

2009-10-17 Thread Kay Kay (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766931#action_12766931 ] Kay Kay commented on LUCENE-1257: - Thanks Uwe for helping with the patches. > Port to Ja

Re: 2.9.1

2009-10-17 Thread Yonik Seeley
On Wed, Oct 14, 2009 at 5:39 PM, Michael McCandless wrote: > I can cut the 2.9.1 release, but... should we wait a bit to see > whether other issues come up? I took a quick peek at the test code provided by Peter... and this certainly looks like a bug: https://issues.apache.org/jira/browse/LUCENE-

[jira] Commented: (LUCENE-1458) Further steps towards flexible indexing

2009-10-17 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766925#action_12766925 ] Mark Miller commented on LUCENE-1458: - bq. Actually I think I just moved things around

[jira] Commented: (LUCENE-1458) Further steps towards flexible indexing

2009-10-17 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766922#action_12766922 ] Michael McCandless commented on LUCENE-1458: bq. you tweaked a couple little t

[jira] Commented: (LUCENE-1955) Fix Hits deprecation notice

2009-10-17 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766921#action_12766921 ] Michael McCandless commented on LUCENE-1955: bq. I think we want to point peop

Re: Whitespace inside Generics parameters

2009-10-17 Thread Michael McCandless
+1 for option 3 Mike On Sat, Oct 17, 2009 at 6:55 AM, Uwe Schindler wrote: > Just because I came along a lot of new Generics declarations: > How should we handle generics parameters in the source code? There are more > possibilities: > > 1. Map > 2. Map > 3. Map > > Sun's Java code in src.jar o

Re: Whitespace inside Generics parameters

2009-10-17 Thread Mark Miller
Uwe Schindler wrote: > Just because I came along a lot of new Generics declarations: > How should we handle generics parameters in the source code? There are more > possibilities: > > 1. Map > 2. Map > 3. Map > > Sun's Java code in src.jar of their JDK always uses (3)[only in some special > cases,

[jira] Commented: (LUCENE-1458) Further steps towards flexible indexing

2009-10-17 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766917#action_12766917 ] Mark Miller commented on LUCENE-1458: - Okay, first pass for sep cache support is in -

[jira] Commented: (LUCENE-1458) Further steps towards flexible indexing

2009-10-17 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766913#action_12766913 ] Mark Miller commented on LUCENE-1458: - Hey Mike: you tweaked a couple little things wi

[jira] Commented: (LUCENE-1955) Fix Hits deprecation notice

2009-10-17 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766910#action_12766910 ] Mark Miller commented on LUCENE-1955: - Mike fixed as: {code} * @deprecated * see {.

[jira] Updated: (LUCENE-1989) CharArraySet cannot be made generic, because it violates the Set interface

2009-10-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-1989: -- Attachment: LUCENE-1989.patch This is the only possibility to make it somehow genericfied. As

Re: Whitespace inside Generics parameters

2009-10-17 Thread Earwin Burrfoot
Always used 1. That's also the default for many autoformatters, which probably explains why people use it. On Sat, Oct 17, 2009 at 14:55, Uwe Schindler wrote: > Just because I came along a lot of new Generics declarations: > How should we handle generics parameters in the source code? There are m

[jira] Created: (LUCENE-1989) CharArraySet cannot be made generic, because it violates the Set interface

2009-10-17 Thread Uwe Schindler (JIRA)
CharArraySet cannot be made generic, because it violates the Set interface -- Key: LUCENE-1989 URL: https://issues.apache.org/jira/browse/LUCENE-1989 Project: Lucene - Ja

RE: [jira] Updated: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)

2009-10-17 Thread Uwe Schindler
Any comments about this? +1 for undeprecate these ctors in Token from my side. - Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de eMail: u...@thetaphi.de > -Original Message- > From: Uwe Schindler (JIRA) [mailto:j...@apache.org] > Sent: Friday, October 16, 2

Whitespace inside Generics parameters

2009-10-17 Thread Uwe Schindler
Just because I came along a lot of new Generics declarations: How should we handle generics parameters in the source code? There are more possibilities: 1. Map 2. Map 3. Map Sun's Java code in src.jar of their JDK always uses (3)[only in some special cases, when it gets complicated, like when ?

[jira] Updated: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)

2009-10-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-1987: -- Attachment: LUCENE-1987.patch Updated patch to last generics additions > Remove rest of analy

[jira] Commented: (LUCENE-1257) Port to Java5

2009-10-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766869#action_12766869 ] Uwe Schindler commented on LUCENE-1257: --- Committed: LUCENE-1257-SegmentInfos.patc

[jira] Updated: (LUCENE-1257) Port to Java5

2009-10-17 Thread Kay Kay (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kay Kay updated LUCENE-1257: Attachment: LUCENE-1257-BooleanScorer_2.patch > Port to Java5 > - > > Key: LUC

[jira] Commented: (LUCENE-1257) Port to Java5

2009-10-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766861#action_12766861 ] Uwe Schindler commented on LUCENE-1257: --- again we have the date sorting bug in JIRA

[jira] Updated: (LUCENE-1257) Port to Java5

2009-10-17 Thread Kay Kay (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kay Kay updated LUCENE-1257: Attachment: LUCENE-1257-BooleanQuery.patch > Port to Java5 > - > > Key: LUCENE

[jira] Commented: (LUCENE-1257) Port to Java5

2009-10-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766858#action_12766858 ] Uwe Schindler commented on LUCENE-1257: --- I am working on it, I already fixed the mis

[jira] Updated: (LUCENE-1257) Port to Java5

2009-10-17 Thread Kay Kay (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kay Kay updated LUCENE-1257: Attachment: (was: LUCENE-1257-SegmentInfos.patch) > Port to Java5 > - > >

[jira] Updated: (LUCENE-1257) Port to Java5

2009-10-17 Thread Kay Kay (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kay Kay updated LUCENE-1257: Attachment: LUCENE-1257-SegmentInfos.patch > Port to Java5 > - > > Key: LUCENE

[jira] Updated: (LUCENE-1257) Port to Java5

2009-10-17 Thread Kay Kay (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kay Kay updated LUCENE-1257: Attachment: LUCENE-1257-SegmentInfos.patch > Port to Java5 > - > > Key: LUCENE

[jira] Assigned: (LUCENE-1988) CharacterCache - references deleted

2009-10-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler reassigned LUCENE-1988: - Assignee: Uwe Schindler > CharacterCache - references deleted > ---

[jira] Updated: (LUCENE-1257) Port to Java5

2009-10-17 Thread Kay Kay (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kay Kay updated LUCENE-1257: Attachment: LUCENE-1257-BufferedDeletes_DocumentsWriter.patch > Port to Java5 > - > >

[jira] Commented: (LUCENE-1988) CharacterCache - references deleted

2009-10-17 Thread Kay Kay (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766854#action_12766854 ] Kay Kay commented on LUCENE-1988: - LUCENE-1987 seems to address a good number of issues as

[jira] Created: (LUCENE-1988) CharacterCache - references deleted

2009-10-17 Thread Kay Kay (JIRA)
CharacterCache - references deleted Key: LUCENE-1988 URL: https://issues.apache.org/jira/browse/LUCENE-1988 Project: Lucene - Java Issue Type: Improvement Reporter: Kay Kay Attachmen

[jira] Updated: (LUCENE-1988) CharacterCache - references deleted

2009-10-17 Thread Kay Kay (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kay Kay updated LUCENE-1988: Attachment: LUCENE-1988.patch > CharacterCache - references deleted > ---

[jira] Updated: (LUCENE-1257) Port to Java5

2009-10-17 Thread Kay Kay (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kay Kay updated LUCENE-1257: Attachment: LUCENE-1257-NormalizeCharMap.patch > Port to Java5 > - > > Key: LU

[jira] Updated: (LUCENE-1257) Port to Java5

2009-10-17 Thread Kay Kay (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kay Kay updated LUCENE-1257: Attachment: LUCENE-1257-WordListLoader.patch Generify signatures. > Port to Java5 > - > >