[jira] Commented: (LUCENE-2084) remove Byte/CharBuffer wrapping for collation key generation

[ https://issues.apache.org/jira/browse/LUCENE-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794763#action_12794763 ] Robert Muir commented on LUCENE-2084: - Steve, thanks for pointing these out. #3 conce

[jira] Commented: (LUCENE-2084) remove Byte/CharBuffer wrapping for collation key generation

[ https://issues.apache.org/jira/browse/LUCENE-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794762#action_12794762 ] Steven Rowe commented on LUCENE-2084: - Hi Robert, I took a look at the patch and found

[jira] Updated: (LUCENE-2084) remove Byte/CharBuffer wrapping for collation key generation

[ https://issues.apache.org/jira/browse/LUCENE-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-2084: Attachment: LUCENE-2084.patch updated patch with uwe's javadoc suggestions > remove Byte/CharBuff

Hudson build is back to normal: Lucene-trunk #1044

See - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org

Re: TermDocs.close

Thanks Michael for the clarification! -John On Sun, Dec 27, 2009 at 4:11 AM, Michael McCandless < luc...@mikemccandless.com> wrote: > It's confusing... but it is in fact safe not closing it (for Lucene's > core IndexReader impls) -- because the IndexInputs that > SegmentTermDocs/Positions use ar

[jira] Commented: (LUCENE-2084) remove Byte/CharBuffer wrapping for collation key generation

[ https://issues.apache.org/jira/browse/LUCENE-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794706#action_12794706 ] Uwe Schindler commented on LUCENE-2084: --- OK. I do not want to discuss further, the

[jira] Commented: (LUCENE-2084) remove Byte/CharBuffer wrapping for collation key generation

[ https://issues.apache.org/jira/browse/LUCENE-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794703#action_12794703 ] Robert Muir commented on LUCENE-2084: - Thanks Uwe, I will incorporate some of this wor

[jira] Created: (LUCENE-2181) benchmark for collation

benchmark for collation --- Key: LUCENE-2181 URL: https://issues.apache.org/jira/browse/LUCENE-2181 Project: Lucene - Java Issue Type: New Feature Components: contrib/benchmark Reporter: Robert Muir

[jira] Issue Comment Edited: (LUCENE-2084) remove Byte/CharBuffer wrapping for collation key generation

[ https://issues.apache.org/jira/browse/LUCENE-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794702#action_12794702 ] Uwe Schindler edited comment on LUCENE-2084 at 12/27/09 5:08 PM: ---

[jira] Commented: (LUCENE-2084) remove Byte/CharBuffer wrapping for collation key generation

[ https://issues.apache.org/jira/browse/LUCENE-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794702#action_12794702 ] Uwe Schindler commented on LUCENE-2084: --- +1 And please add a note that the Char/Byt

[jira] Commented: (LUCENE-2084) remove Byte/CharBuffer wrapping for collation key generation

[ https://issues.apache.org/jira/browse/LUCENE-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794701#action_12794701 ] Robert Muir commented on LUCENE-2084: - Hi, this is a simple, straightforward performan

[jira] Updated: (LUCENE-2084) remove Byte/CharBuffer wrapping for collation key generation

[ https://issues.apache.org/jira/browse/LUCENE-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-2084: Attachment: LUCENE-2084.patch in this patch, preserve the javadoc at the beginning of this class w

[jira] Commented: (LUCENE-2084) remove Byte/CharBuffer wrapping for collation key generation

[ https://issues.apache.org/jira/browse/LUCENE-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794687#action_12794687 ] Robert Muir commented on LUCENE-2084: - Uwe, can we please do any nio bugfixes under an

[jira] Issue Comment Edited: (LUCENE-2084) remove Byte/CharBuffer wrapping for collation key generation

[ https://issues.apache.org/jira/browse/LUCENE-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794680#action_12794680 ] Uwe Schindler edited comment on LUCENE-2084 at 12/27/09 12:36 PM: --

[jira] Commented: (LUCENE-2084) remove Byte/CharBuffer wrapping for collation key generation

[ https://issues.apache.org/jira/browse/LUCENE-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794680#action_12794680 ] Uwe Schindler commented on LUCENE-2084: --- I found one place where the arrayOffset() b

RE: TermDocs.close

E.g. in flex, the wrappers around old enums do not ever call close(), too. I am not sure if this is a problem for TermEnums wrapped by TermsEnum there. The new enums do not implement j.io.Closeable at all. - Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de eMail: u...@

Re: TermDocs.close

It's confusing... but it is in fact safe not closing it (for Lucene's core IndexReader impls) -- because the IndexInputs that SegmentTermDocs/Positions use are clones, their close methods are a no-op. Mike On Sun, Dec 27, 2009 at 6:37 AM, John Wang wrote: > Hi: >   I see TermDocs.close not being

TermDocs.close

Hi: I see TermDocs.close not being called when created with TermQuery: TermQuery creates it and passes to TermScorer, and is never closed. I see TermDocs.close actually closes the input stream. Is it safe not closing TermDocs? Thanks -John

[jira] Issue Comment Edited: (LUCENE-2084) remove Byte/CharBuffer wrapping for collation key generation

[ https://issues.apache.org/jira/browse/LUCENE-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794675#action_12794675 ] Uwe Schindler edited comment on LUCENE-2084 at 12/27/09 10:01 AM: --

[jira] Commented: (LUCENE-2084) remove Byte/CharBuffer wrapping for collation key generation

[ https://issues.apache.org/jira/browse/LUCENE-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794675#action_12794675 ] Uwe Schindler commented on LUCENE-2084: --- bq. Therefore, limit - offset is a correct

[jira] Updated: (LUCENE-2084) remove Byte/CharBuffer wrapping for collation key generation

[ https://issues.apache.org/jira/browse/LUCENE-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-2084: Attachment: LUCENE-2084.patch updated patch: * deprecate the now unused CharBuffer/ByteBuffer meth