[jira] Commented: (LUCENE-2396) remove version from contrib/analyzers.

2010-04-15 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12857427#action_12857427 ] DM Smith commented on LUCENE-2396: -- Robert, I think this is a red-herring. There has been

[jira] Commented: (LUCENE-2396) remove version from contrib/analyzers.

2010-04-15 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12857456#action_12857456 ] DM Smith commented on LUCENE-2396: -- {quote} So I think we should instead use

[jira] Issue Comment Edited: (LUCENE-2396) remove version from contrib/analyzers.

2010-04-15 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12857456#action_12857456 ] DM Smith edited comment on LUCENE-2396 at 4/15/10 2:16 PM: ---

[jira] Commented: (LUCENE-2396) remove version from contrib/analyzers.

2010-04-15 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12857487#action_12857487 ] DM Smith commented on LUCENE-2396: -- bq. Well, I think asking for a well-defined backwards

[jira] Commented: (LUCENE-2396) remove version from contrib/analyzers.

2010-04-15 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12857498#action_12857498 ] DM Smith commented on LUCENE-2396: -- {quote} bq. One mechanism that would work is

[jira] Commented: (LUCENE-2396) remove version from core and contrib analyzers.

2010-04-15 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12857543#action_12857543 ] DM Smith commented on LUCENE-2396: -- Hmmm. If we are moving stuff out of core and into

[jira] Commented: (LUCENE-2055) Fix buggy stemmers and Remove duplicate analysis functionality

2010-01-18 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801909#action_12801909 ] DM Smith commented on LUCENE-2055: -- I think it is right to fix bad behavior, but such a

[jira] Commented: (LUCENE-2226) move contrib/snowball to contrib/analyzers

2010-01-18 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801912#action_12801912 ] DM Smith commented on LUCENE-2226: -- +1 However this is a very minor break in bw compat:

[jira] Commented: (LUCENE-2226) move contrib/snowball to contrib/analyzers

2010-01-18 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12802004#action_12802004 ] DM Smith commented on LUCENE-2226: -- Robert, I'm suggesting that you move it. But that in

[jira] Commented: (LUCENE-2226) move contrib/snowball to contrib/analyzers

2010-01-18 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12802040#action_12802040 ] DM Smith commented on LUCENE-2226: -- bq. But i think this concept doesn't even make sense

[jira] Commented: (LUCENE-1343) A replacement for ISOLatin1AccentFilter that does a more thorough job of removing diacritical marks or non-spacing modifiers.

2009-12-07 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12786941#action_12786941 ] DM Smith commented on LUCENE-1343: -- I also am dubious about a general purpose folding

[jira] Commented: (LUCENE-1343) A replacement for ISOLatin1AccentFilter that does a more thorough job of removing diacritical marks or non-spacing modifiers.

2009-12-07 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12786968#action_12786968 ] DM Smith commented on LUCENE-1343: -- {quote} bq. Robert Muir, Would it make sense to

[jira] Commented: (LUCENE-2105) Lucene does not support Unicode Normalization Forms

2009-12-03 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12785302#action_12785302 ] DM Smith commented on LUCENE-2105: -- Is this a duplicate or solved by LUCENE-1488? It

[jira] Commented: (LUCENE-2034) Massive Code Duplication in Contrib Analyzers - unifly the analyzer ctors

2009-12-02 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784812#action_12784812 ] DM Smith commented on LUCENE-2034: -- bq. But I do not see the benefit compared to the

[jira] Commented: (LUCENE-1488) multilingual analyzer based on icu

2009-12-02 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12785036#action_12785036 ] DM Smith commented on LUCENE-1488: -- Robert, just finished reviewing the code. Looks

[jira] Commented: (LUCENE-2094) Prepare CharArraySet for Unicode 4.0

2009-12-01 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784175#action_12784175 ] DM Smith commented on LUCENE-2094: -- bq. I would like to open another issue for roberts

[jira] Commented: (LUCENE-2034) Massive Code Duplication in Contrib Analyzers - unifly the analyzer ctors

2009-12-01 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784338#action_12784338 ] DM Smith commented on LUCENE-2034: -- Robert: bq. DM, I think we can have both? A method to

[jira] Commented: (LUCENE-1581) LowerCaseFilter should be able to be configured to use a specific locale.

2009-12-01 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784358#action_12784358 ] DM Smith commented on LUCENE-1581: -- bq. ultimately I still think case folding is the

[jira] Commented: (LUCENE-2102) LowerCaseFilter for Turkish language

2009-12-01 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784421#action_12784421 ] DM Smith commented on LUCENE-2102: -- bq. but non-NFC text doesn't work correctly

[jira] Commented: (LUCENE-2102) LowerCaseFilter for Turkish language

2009-12-01 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784423#action_12784423 ] DM Smith commented on LUCENE-2102: -- For new classes, would it be helpful to add @since to

[jira] Commented: (LUCENE-2034) Massive Code Duplication in Contrib Analyzers - unifly the analyzer ctors

2009-12-01 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784506#action_12784506 ] DM Smith commented on LUCENE-2034: -- {quote} bq.How about splitting out the stop words

[jira] Commented: (LUCENE-2034) Massive Code Duplication in Contrib Analyzers - unifly the analyzer ctors

2009-11-30 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12783737#action_12783737 ] DM Smith commented on LUCENE-2034: -- I was trying to lurk, but I'm not able to apply the

[jira] Commented: (LUCENE-1458) Further steps towards flexible indexing

2009-11-24 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12781947#action_12781947 ] DM Smith commented on LUCENE-1458: -- bq. Yes, this (customizing comparator for termrefs)

[jira] Commented: (LUCENE-1799) Unicode compression

2009-11-19 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12780129#action_12780129 ] DM Smith commented on LUCENE-1799: -- The sample code is probably what is on this page,

[jira] Commented: (LUCENE-2023) Improve performance of SmartChineseAnalyzer

2009-11-01 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12772350#action_12772350 ] DM Smith commented on LUCENE-2023: -- Internals are internals. Anyone digging into

[jira] Commented: (LUCENE-2023) Improve performance of SmartChineseAnalyzer

2009-10-30 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12772003#action_12772003 ] DM Smith commented on LUCENE-2023: -- If we have a 2.9.2 release, can this be there too?

[jira] Commented: (LUCENE-2023) Improve performance of SmartChineseAnalyzer

2009-10-30 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12772022#action_12772022 ] DM Smith commented on LUCENE-2023: -- I fully understand that at some point, just say no.

[jira] Commented: (LUCENE-2023) Improve performance of SmartChineseAnalyzer

2009-10-30 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12772050#action_12772050 ] DM Smith commented on LUCENE-2023: -- Robert, You have in BigramDictionary: {code} public

[jira] Commented: (LUCENE-2012) Add @Override annotations

2009-10-27 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12770705#action_12770705 ] DM Smith commented on LUCENE-2012: -- Uwe, what did you use to generate the @override?

[jira] Commented: (LUCENE-1998) Use Java 5 enums

2009-10-21 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12768215#action_12768215 ] DM Smith commented on LUCENE-1998: -- .bq I only added the license header back in the

[jira] Issue Comment Edited: (LUCENE-1998) Use Java 5 enums

2009-10-21 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12768215#action_12768215 ] DM Smith edited comment on LUCENE-1998 at 10/21/09 2:22 PM:

[jira] Commented: (LUCENE-1998) Use Java 5 enums

2009-10-21 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12768270#action_12768270 ] DM Smith commented on LUCENE-1998: -- I just noticed that enums are comparable. For the

[jira] Commented: (LUCENE-1998) Use Java 5 enums

2009-10-21 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12768304#action_12768304 ] DM Smith commented on LUCENE-1998: -- bq. changing the order of enum constants is bad, you

[jira] Updated: (LUCENE-1257) Port to Java5

2009-10-20 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DM Smith updated LUCENE-1257: - Attachment: LUCENE-1257_enum.patch Migrates to Java 5 enums in core and contrib. All tests pass.

[jira] Created: (LUCENE-1998) Use Java 5 enums

2009-10-20 Thread DM Smith (JIRA)
Use Java 5 enums Key: LUCENE-1998 URL: https://issues.apache.org/jira/browse/LUCENE-1998 Project: Lucene - Java Issue Type: Improvement Affects Versions: 3.0 Reporter: DM Smith Priority: Minor

[jira] Updated: (LUCENE-1998) Use Java 5 enums

2009-10-20 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DM Smith updated LUCENE-1998: - Attachment: LUCENE-1998_enum.patch This issue and patch were part of LUCENE-1257, but may have backward

[jira] Updated: (LUCENE-1257) Port to Java5

2009-10-20 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DM Smith updated LUCENE-1257: - Attachment: (was: LUCENE-1257_enum.patch) Port to Java5 - Key:

[jira] Commented: (LUCENE-1963) ArabicAnalyzer: Lowercase before Stopfilter

2009-10-08 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12763554#action_12763554 ] DM Smith commented on LUCENE-1963: -- can you commit it to 2.9.1 too? (For those stuck on

[jira] Commented: (LUCENE-1813) Add option to ReverseStringFilter to mark reversed tokens

2009-08-17 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12744092#action_12744092 ] DM Smith commented on LUCENE-1813: -- I like the idea of a constant and it presented as a

[jira] Commented: (LUCENE-1793) remove custom encoding support in Greek/Russian Analyzers

2009-08-09 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12741109#action_12741109 ] DM Smith commented on LUCENE-1793: -- bq.If this is the concern, then I think a better

[jira] Commented: (LUCENE-1793) remove custom encoding support in Greek/Russian Analyzers

2009-08-09 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12741173#action_12741173 ] DM Smith commented on LUCENE-1793: -- I wasn't thinking about any encoding in particular.

[jira] Commented: (LUCENE-1581) LowerCaseFilter should be able to be configured to use a specific locale.

2009-03-29 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12693545#action_12693545 ] DM Smith commented on LUCENE-1581: -- This a bit larger of a problem. It also pertains to

[jira] Commented: (LUCENE-1581) LowerCaseFilter should be able to be configured to use a specific locale.

2009-03-29 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12693579#action_12693579 ] DM Smith commented on LUCENE-1581: -- bq.Why do this? Lucene has a bias toward English

[jira] Commented: (LUCENE-1422) New TokenStream API

2008-10-21 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12641580#action_12641580 ] DM Smith commented on LUCENE-1422: -- bq.Another question. Currently the members in Token,

[jira] Created: (LUCENE-1368) demo HTMLParser.java and HTMLParser.jj are out of sync

2008-08-28 Thread DM Smith (JIRA)
demo HTMLParser.java and HTMLParser.jj are out of sync -- Key: LUCENE-1368 URL: https://issues.apache.org/jira/browse/LUCENE-1368 Project: Lucene - Java Issue Type: Bug

[jira] Closed: (LUCENE-1368) demo HTMLParser.java and HTMLParser.jj are out of sync

2008-08-28 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DM Smith closed LUCENE-1368. Resolution: Invalid sorry. my mistake. I didn't compare it closely enough. demo HTMLParser.java and

[jira] Created: (LUCENE-1369) Eliminate unnecessary uses of Hashtable and Vector

2008-08-28 Thread DM Smith (JIRA)
Eliminate unnecessary uses of Hashtable and Vector -- Key: LUCENE-1369 URL: https://issues.apache.org/jira/browse/LUCENE-1369 Project: Lucene - Java Issue Type: Improvement Affects

[jira] Updated: (LUCENE-1369) Eliminate unnecessary uses of Hashtable and Vector

2008-08-28 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DM Smith updated LUCENE-1369: - Attachment: LUCENE-1369.patch Eliminate unnecessary uses of Hashtable and Vector

[jira] Updated: (LUCENE-1333) Token implementation needs improvements

2008-08-18 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DM Smith updated LUCENE-1333: - Attachment: LUCENE-1333.patch * Added reinit(Token ...) methods to initialize one token from another. *

[jira] Commented: (LUCENE-1333) Token implementation needs improvements

2008-08-13 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12622201#action_12622201 ] DM Smith commented on LUCENE-1333: -- {quote} Cloning Tokens is not cheap, as I recall. In

[jira] Commented: (LUCENE-1333) Token implementation needs improvements

2008-08-13 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12622238#action_12622238 ] DM Smith commented on LUCENE-1333: -- Regarding the implementation of hashCode: You are

[jira] Issue Comment Edited: (LUCENE-1333) Token implementation needs improvements

2008-08-13 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12622238#action_12622238 ] dmsmith edited comment on LUCENE-1333 at 8/13/08 12:04 PM:

[jira] Commented: (LUCENE-1333) Token implementation needs improvements

2008-08-12 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12621969#action_12621969 ] DM Smith commented on LUCENE-1333: -- {quote} The SinkTokenizer changes don't seem right to

[jira] Commented: (LUCENE-1333) Token implementation needs improvements

2008-08-11 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12621417#action_12621417 ] DM Smith commented on LUCENE-1333: -- Caching flies in the face of reuse. I think that a

[jira] Commented: (LUCENE-1333) Token implementation needs improvements

2008-08-10 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12621319#action_12621319 ] DM Smith commented on LUCENE-1333: -- Back from a trip. Would have jumped in to help, but

[jira] Commented: (LUCENE-1333) Token implementation needs improvements

2008-08-09 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12621132#action_12621132 ] DM Smith commented on LUCENE-1333: -- I'll give my analysis here. Feel free to make the

[jira] Updated: (LUCENE-1350) Filters which are consumers should not reset the payload or flags and should better reuse the token

2008-08-08 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DM Smith updated LUCENE-1350: - Attachment: LUCENE-1350.patch {quote} Should we just absorb this issue into LUCENE-1333? DM, of your

[jira] Updated: (LUCENE-1333) Token implementation needs improvements

2008-08-08 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DM Smith updated LUCENE-1333: - Attachment: LUCENE-1333.patch This patch includes all the previous ones. Note: It includes the

[jira] Commented: (LUCENE-1350) SnowballFilter resets the payload

2008-08-06 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12620435#action_12620435 ] DM Smith commented on LUCENE-1350: -- {quote} Non-reuse TokenStream API is not deprecated

[jira] Commented: (LUCENE-1350) SnowballFilter resets the payload

2008-08-05 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12619925#action_12619925 ] DM Smith commented on LUCENE-1350: -- When we go to the reuse pattern across all of Lucene,

[jira] Commented: (LUCENE-1350) SnowballFilter resets the payload

2008-08-05 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12619961#action_12619961 ] DM Smith commented on LUCENE-1350: -- The non-reuse interface is deprecated. LUCENE-1333

[jira] Commented: (LUCENE-1350) SnowballFilter resets the payload

2008-08-05 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12619982#action_12619982 ] DM Smith commented on LUCENE-1350: -- Survey of other potential problem areas (I did not

[jira] Updated: (LUCENE-1333) Token implementation needs improvements

2008-08-04 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DM Smith updated LUCENE-1333: - Attachment: LUCENE-1333.patch Better comments based upon migrating all of core and contrib. This patch

[jira] Updated: (LUCENE-1333) Token implementation needs improvements

2008-08-04 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DM Smith updated LUCENE-1333: - Attachment: LUCENE-1333-analysis.patch I've broken up the changes to core and contrib into small

[jira] Updated: (LUCENE-1333) Token implementation needs improvements

2008-08-04 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DM Smith updated LUCENE-1333: - Attachment: LUCENE-1333-analyzers.patch This is for contrib analyzers. Token implementation needs

[jira] Updated: (LUCENE-1333) Token implementation needs improvements

2008-08-04 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DM Smith updated LUCENE-1333: - Attachment: LUCENE-1333-snowball.patch for contrib snowball Token implementation needs improvements

[jira] Updated: (LUCENE-1333) Token implementation needs improvements

2008-08-04 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DM Smith updated LUCENE-1333: - Attachment: LUCENE-1333-highlighter.patch for contrib highlighter Token implementation needs

[jira] Updated: (LUCENE-1333) Token implementation needs improvements

2008-08-04 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DM Smith updated LUCENE-1333: - Attachment: LUCENE-1333-wikipedia.patch for contrib wikipedia Token implementation needs improvements

[jira] Updated: (LUCENE-1333) Token implementation needs improvements

2008-08-04 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DM Smith updated LUCENE-1333: - Attachment: LUCENE-1333-lucli.patch for contrib lucli Token implementation needs improvements

[jira] Updated: (LUCENE-1333) Token implementation needs improvements

2008-08-04 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DM Smith updated LUCENE-1333: - Attachment: LUCENE-1333-memory.patch for contrib memory Token implementation needs improvements

[jira] Updated: (LUCENE-1333) Token implementation needs improvements

2008-08-04 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DM Smith updated LUCENE-1333: - Attachment: LUCENE-1333-wordnet.patch for contrib wordnet Token implementation needs improvements

[jira] Updated: (LUCENE-1333) Token implementation needs improvements

2008-08-04 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DM Smith updated LUCENE-1333: - Attachment: LUCENE-1333-xml-query-parser.patch for contrib xml-query-parser Token implementation

[jira] Issue Comment Edited: (LUCENE-1333) Token implementation needs improvements

2008-08-04 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12619667#action_12619667 ] dmsmith edited comment on LUCENE-1333 at 8/4/08 1:24 PM: -- Better

[jira] Commented: (LUCENE-1333) Token implementation needs improvements

2008-08-04 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12619695#action_12619695 ] DM Smith commented on LUCENE-1333: -- All the code has been migrated to use the reuse

[jira] Updated: (LUCENE-1333) Token implementation needs improvements

2008-07-14 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DM Smith updated LUCENE-1333: - Attachment: LUCENE-1333a.txt The following has been addressed in this patch: 1. JavaDoc is improved (as

[jira] Created: (LUCENE-1334) Term improvement

2008-07-11 Thread DM Smith (JIRA)
Term improvement Key: LUCENE-1334 URL: https://issues.apache.org/jira/browse/LUCENE-1334 Project: Lucene - Java Issue Type: Improvement Components: Index Affects Versions: 2.3.1 Environment: all

[jira] Updated: (LUCENE-1334) Term improvement

2008-07-11 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DM Smith updated LUCENE-1334: - Attachment: LUCENE-1334.txt patch for the issue Term improvement

[jira] Commented: (LUCENE-1224) NGramTokenFilter creates bad TokenStream

2008-05-15 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12597112#action_12597112 ] DM Smith commented on LUCENE-1224: -- My take as a user: Maybe, I don't understand the

[jira] Commented: (LUCENE-1029) Illegal character replacements in ISOLatin1AccentFilter

2007-10-15 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534839 ] DM Smith commented on LUCENE-1029: -- Transliteration rules are language dependent. I suggest that the documentation

[jira] Commented: (LUCENE-1029) Illegal character replacements in ISOLatin1AccentFilter

2007-10-15 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535047 ] DM Smith commented on LUCENE-1029: -- One could maintain compatibility by adding a constructor that supplies a

[jira] Commented: (LUCENE-872) have Hits implement Iterable

2007-05-02 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493236 ] DM Smith commented on LUCENE-872: - This will need to wait until Java 1.4.2 is no longer our target language. have

[jira] Commented: (LUCENE-388) [PATCH] IndexWriter.maybeMergeSegments() takes lots of CPU resources

2006-08-14 Thread DM Smith (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-388?page=comments#action_12427984 ] DM Smith commented on LUCENE-388: - In Eclipse you can set the run to use its own JVM. Otherwise it runs in Eclipse's JVM and it has negative memory side effects.

[jira] Created: (LUCENE-611) TestConstantScoreRangeQuery does not compile with ecj

2006-06-22 Thread DM Smith (JIRA)
TestConstantScoreRangeQuery does not compile with ecj - Key: LUCENE-611 URL: http://issues.apache.org/jira/browse/LUCENE-611 Project: Lucene - Java Type: Bug Components: Search Versions: 2.0.0

[jira] Updated: (LUCENE-611) TestConstantScoreRangeQuery does not compile with ecj

2006-06-22 Thread DM Smith (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-611?page=all ] DM Smith updated LUCENE-611: Attachment: TestConstantScoreRangeQueryPatch.txt TestConstantScoreRangeQuery does not compile with ecj -

[jira] Commented: (LUCENE-611) TestConstantScoreRangeQuery does not compile with ecj

2006-06-22 Thread DM Smith (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-611?page=comments#action_12417319 ] DM Smith commented on LUCENE-611: - I have checked all of trunk/src/{java,demo,test} but not gcj. I have not checked any of contrib yet. Give me a bit and I'll check these out

[jira] Commented: (LUCENE-611) TestConstantScoreRangeQuery does not compile with ecj

2006-06-22 Thread DM Smith (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-611?page=comments#action_12417333 ] DM Smith commented on LUCENE-611: - Other than gcj, everything compiles with ecj without error (given the attached patch). The gcj fails on an import which has nothing to do

[jira] Created: (LUCENE-610) BooleanScorer2 does not compile with ecj

2006-06-21 Thread DM Smith (JIRA)
BooleanScorer2 does not compile with ecj Key: LUCENE-610 URL: http://issues.apache.org/jira/browse/LUCENE-610 Project: Lucene - Java Type: Bug Components: Search Versions: 2.0.0 Environment: Eclipse 3.1.2,

[jira] Commented: (LUCENE-610) BooleanScorer2 does not compile with ecj

2006-06-21 Thread DM Smith (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-610?page=comments#action_12417186 ] DM Smith commented on LUCENE-610: - I did a bit further testing. The current behavior under Java 5 is to call this.doc(); BooleanScorer2 does not compile with ecj