[jira] Commented: (LUCENE-2198) support protected words in Stemming TokenFilters

2010-01-18 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801734#action_12801734 ] Uwe Schindler commented on LUCENE-2198: --- bq. I also don't understand the arguments

[jira] Commented: (LUCENE-2198) support protected words in Stemming TokenFilters

2010-01-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801426#action_12801426 ] Uwe Schindler commented on LUCENE-2198: --- The KeywordAttribute and *Impl looks

[jira] Commented: (LUCENE-2198) support protected words in Stemming TokenFilters

2010-01-17 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801437#action_12801437 ] Yonik Seeley commented on LUCENE-2198: -- One random thought is to wonder how much this

[jira] Commented: (LUCENE-2198) support protected words in Stemming TokenFilters

2010-01-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801438#action_12801438 ] Uwe Schindler commented on LUCENE-2198: --- If we start to discuss about such topics,

[jira] Commented: (LUCENE-2198) support protected words in Stemming TokenFilters

2010-01-17 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801442#action_12801442 ] Yonik Seeley commented on LUCENE-2198: -- bq. If we start to discuss about such topics,

[jira] Commented: (LUCENE-2198) support protected words in Stemming TokenFilters

2010-01-17 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801446#action_12801446 ] Simon Willnauer commented on LUCENE-2198: - I kind of agree with both of you. When

[jira] Commented: (LUCENE-2198) support protected words in Stemming TokenFilters

2010-01-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801448#action_12801448 ] Uwe Schindler commented on LUCENE-2198: --- My problem with FlagsAttribute is missing

[jira] Commented: (LUCENE-2198) support protected words in Stemming TokenFilters

2010-01-17 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801450#action_12801450 ] Robert Muir commented on LUCENE-2198: - bq. Surely the native clone() invoked for every

[jira] Commented: (LUCENE-2198) support protected words in Stemming TokenFilters

2010-01-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801451#action_12801451 ] Uwe Schindler commented on LUCENE-2198: --- bq. Surely the native clone() invoked for

[jira] Commented: (LUCENE-2198) support protected words in Stemming TokenFilters

2010-01-17 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801457#action_12801457 ] Yonik Seeley commented on LUCENE-2198: -- bq. Only in the case that having multiple

[jira] Commented: (LUCENE-2198) support protected words in Stemming TokenFilters

2010-01-13 Thread Erik Hatcher (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799839#action_12799839 ] Erik Hatcher commented on LUCENE-2198: -- +1 on the StemAttribute approach. I've just

[jira] Commented: (LUCENE-2198) support protected words in Stemming TokenFilters

2010-01-13 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799873#action_12799873 ] Robert Muir commented on LUCENE-2198: - the patch looks great to me Simon. I especially

[jira] Commented: (LUCENE-2198) support protected words in Stemming TokenFilters

2010-01-09 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12798388#action_12798388 ] Simon Willnauer commented on LUCENE-2198: - bq. So I think we should just provide