[jira] Commented: (LUCENE-2343) Add support for benchmarking Collectors

[ https://issues.apache.org/jira/browse/LUCENE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12849295#action_12849295 ] Grant Ingersoll commented on LUCENE-2343: - I intend to commit today or tomorrow.

[jira] Commented: (LUCENE-2343) Add support for benchmarking Collectors

[ https://issues.apache.org/jira/browse/LUCENE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12849384#action_12849384 ] Shai Erera commented on LUCENE-2343: In the patch you write: topDocOrdered - Creates a

[jira] Commented: (LUCENE-2343) Add support for benchmarking Collectors

[ https://issues.apache.org/jira/browse/LUCENE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12849390#action_12849390 ] Grant Ingersoll commented on LUCENE-2343: - bq. can be written as

[jira] Commented: (LUCENE-2343) Add support for benchmarking Collectors

[ https://issues.apache.org/jira/browse/LUCENE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12849393#action_12849393 ] Shai Erera commented on LUCENE-2343: ok I won't argue about == true/false. It's a

[jira] Commented: (LUCENE-2343) Add support for benchmarking Collectors

[ https://issues.apache.org/jira/browse/LUCENE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12849397#action_12849397 ] Grant Ingersoll commented on LUCENE-2343: - bq. In the patch you write:

[jira] Commented: (LUCENE-2343) Add support for benchmarking Collectors

[ https://issues.apache.org/jira/browse/LUCENE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12849403#action_12849403 ] Shai Erera commented on LUCENE-2343: I wasn't talking about the name of the parameter

[jira] Commented: (LUCENE-2343) Add support for benchmarking Collectors

[ https://issues.apache.org/jira/browse/LUCENE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12849405#action_12849405 ] Grant Ingersoll commented on LUCENE-2343: - bq. I wasn't talking about the name of

[jira] Commented: (LUCENE-2343) Add support for benchmarking Collectors

[ https://issues.apache.org/jira/browse/LUCENE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12849416#action_12849416 ] Shai Erera commented on LUCENE-2343: Looks good ! Add support for benchmarking

[jira] Commented: (LUCENE-2343) Add support for benchmarking Collectors

[ https://issues.apache.org/jira/browse/LUCENE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12849435#action_12849435 ] Shai Erera commented on LUCENE-2343: I've just realized you haven't added a CHANGES

[jira] Commented: (LUCENE-2343) Add support for benchmarking Collectors

[ https://issues.apache.org/jira/browse/LUCENE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12849536#action_12849536 ] Grant Ingersoll commented on LUCENE-2343: - Should be in the