Re: Change HashSet to Set in WordlistLoader - BackCompat Issue

2009-10-11 Thread Simon Willnauer
On Sun, Oct 11, 2009 at 3:48 PM, Robert Muir wrote: > Simon, so I don't forget, we also have a custom WordListLoader in > org.apache.lucene.analysis.nl that we can delete for 3.0 (it is deprecated) Saw that already -- thanks for pointing it out again > > For your question though, maybe one idea is

Re: Change HashSet to Set in WordlistLoader - BackCompat Issue

2009-10-11 Thread Robert Muir
Simon, so I don't forget, we also have a custom WordListLoader in org.apache.lucene.analysis.nl that we can delete for 3.0 (it is deprecated) For your question though, maybe one idea is to return HashSet/HashMap but with a comment saying the return value will change to Set/Map in 3.1? If the user

Change HashSet to Set in WordlistLoader - BackCompat Issue

2009-10-10 Thread Simon Willnauer
Hey there, in the context of https://issues.apache.org/jira/browse/LUCENE-1967 I was looking at org.apache.lucene.analysis.WordlistLoader. I noticed that all static methods return HashSet / HashMap instead of their corresponding interfaces Map / Set. As I'm going to add another static helper to th