Re: CharArraySet makes excessive use of Character.toLowerCase

Ok it might not be that easy to make the changes. While add() clearly states that the passed char[] may be modified if ignoreCase is true, it is not the case for contains(char[]). If I first lower case the passed in char[], it modifies the instance the application holds, and then the "Now" will be

Re: CharArraySet makes excessive use of Character.toLowerCase

Thanks, I'll open an issue and create a patch On Sun, Dec 28, 2008 at 5:55 PM, Michael McCandless < luc...@mikemccandless.com> wrote: > > I think all of these changes make sense! > I would just remove that if (false &&...) dead code. > > Mike > > > Shai Erera wrote: > >> Hi >> >> I noticed that

Re: CharArraySet makes excessive use of Character.toLowerCase

I think all of these changes make sense! I would just remove that if (false &&...) dead code. Mike Shai Erera wrote: > Hi > > I noticed that CharArraySet uses Character.toLowerCase in many places in > the code. I think it uses it too much unnecessarily. > For example, the equals(char[], int, in

CharArraySet makes excessive use of Character.toLowerCase

Hi I noticed that CharArraySet uses Character.toLowerCase in many places in the code. I think it uses it too much unnecessarily. For example, the equals(char[], int, int, char[]) method converts the characters to lower case if ignoreCase is true, although it could have been converted in one of the