Re: Deprecating IndexModifier

2007-08-13 Thread Yonik Seeley
On 8/12/07, Ning Li <[EMAIL PROTECTED]> wrote: > IndexWriter does everything IndexModifier does and more, except > "deleteDocument(int doc)". Can we reach consensus on: 1 Should we > deprecate IndexModifier before 3.0 and remove it in 3.0? 2 If so, do > we have to add "deleteDocument(int doc)" to I

Re: Deprecating IndexModifier

2007-08-12 Thread Ning Li
IndexWriter does everything IndexModifier does and more, except "deleteDocument(int doc)". Can we reach consensus on: 1 Should we deprecate IndexModifier before 3.0 and remove it in 3.0? 2 If so, do we have to add "deleteDocument(int doc)" to IndexWriter? We know how to support "deleteDocument(int

Re: Deprecating IndexModifier

2007-08-08 Thread Ning Li
On 8/8/07, Yonik Seeley <[EMAIL PROTECTED]> wrote: > On 8/8/07, Ning Li <[EMAIL PROTECTED]> wrote: > > This reminds me: It'd be nice if we could support delete-by-query someday. > > :) > > > > I was thinking people use deleteDocument(int docid) when they are sure > > the docid hasn't changed since

Re: Deprecating IndexModifier

2007-08-08 Thread Yonik Seeley
On 8/8/07, Ning Li <[EMAIL PROTECTED]> wrote: > On 8/8/07, Yonik Seeley <[EMAIL PROTECTED]> wrote: > > Let's take a simple case of deleting documents in a range, like > > date:[2006 TO 2008] > > One would currently need to close the writer and open a new reader to > > ensure that they can "see" all

Re: Deprecating IndexModifier

2007-08-08 Thread Ning Li
On 8/8/07, Yonik Seeley <[EMAIL PROTECTED]> wrote: > Let's take a simple case of deleting documents in a range, like > date:[2006 TO 2008] > One would currently need to close the writer and open a new reader to > ensure that they can "see" all the documents. Then execute a > RangeQuery, collect th

Re: Deprecating IndexModifier

2007-08-08 Thread Yonik Seeley
On 8/8/07, Ning Li <[EMAIL PROTECTED]> wrote: > On 8/8/07, Yonik Seeley <[EMAIL PROTECTED]> wrote: > > On 8/8/07, Ning Li <[EMAIL PROTECTED]> wrote: > > > But you still think it's worth to be included in IndexWriter, right? > > > > I'm not sure... (unless I'm missing some obvious use-cases). > > If

Re: Deprecating IndexModifier

2007-08-08 Thread Ning Li
On 8/8/07, Yonik Seeley <[EMAIL PROTECTED]> wrote: > On 8/8/07, Ning Li <[EMAIL PROTECTED]> wrote: > > But you still think it's worth to be included in IndexWriter, right? > > I'm not sure... (unless I'm missing some obvious use-cases). > If one could get a list of IndexReaders, one could directly

Re: Deprecating IndexModifier

2007-08-08 Thread Yonik Seeley
On 8/8/07, Ning Li <[EMAIL PROTECTED]> wrote: > On 8/8/07, Yonik Seeley <[EMAIL PROTECTED]> wrote: > > To make delete by docid useful, one needs a way to *get* those docids. > > A callback after flush that provided acurrent list of readers for the > > segments would serve. > > Interesting. That mak

Re: Deprecating IndexModifier

2007-08-08 Thread Ning Li
On 8/8/07, Yonik Seeley <[EMAIL PROTECTED]> wrote: > To make delete by docid useful, one needs a way to *get* those docids. > A callback after flush that provided acurrent list of readers for the > segments would serve. Interesting. That makes sense. > I think IndexWriter.deleteDocument(int doc)

Re: Deprecating IndexModifier

2007-08-08 Thread Yonik Seeley
On 8/8/07, Ning Li <[EMAIL PROTECTED]> wrote: > I'm thinking about the impact of adding "deleteDocument(int doc)" on To make delete by docid useful, one needs a way to *get* those docids. A callback after flush that provided acurrent list of readers for the segments would serve. I think IndexWrit

Re: Deprecating IndexModifier

2007-08-08 Thread Ning Li
I'm thinking about the impact of adding "deleteDocument(int doc)" on LUCENE-847, especially on concurrent merge. The semantics of "deleteDocument(int doc)" is that the document to delete is specified by the document id on the index at the time of the call. When a merge is finished and the result is

Re: Deprecating IndexModifier

2007-08-07 Thread Grant Ingersoll
+1 On Aug 7, 2007, at 3:37 PM, Ning Li wrote: With the plan towards 3.0 release laid out, I think it's a good time to deprecate IndexModifier and eventually remove IndexModifier. The only method in IndexModifier which is not implemented in IndexWriter is "deleteDocument(int doc)". This is bec

Deprecating IndexModifier

2007-08-07 Thread Ning Li
With the plan towards 3.0 release laid out, I think it's a good time to deprecate IndexModifier and eventually remove IndexModifier. The only method in IndexModifier which is not implemented in IndexWriter is "deleteDocument(int doc)". This is because of the concern that document ids are changing