Re: FieldCacheImpl concurrency

2010-02-12 Thread Yonik Seeley
On Fri, Feb 12, 2010 at 1:50 AM, Shay Banon wrote: > On Thu, Feb 11, 2010 at 5:41 PM, Yonik Seeley >> It really shouldn't be heavily used. >> For a sorted search, get() is called once per segment in the index. >> There is no synchronization to retrieve per-document values. > > Sorting is not the

Re: FieldCacheImpl concurrency

2010-02-11 Thread Shay Banon
On Thu, Feb 11, 2010 at 5:41 PM, Yonik Seeley wrote: > On Thu, Feb 11, 2010 at 9:54 AM, Shay Banon wrote: > >I would like to try and improve concurrency in Lucene in several > places, > > and thought I would start with FieldCacheImpl. The implementation is > heavily > > synchronized on both a

Re: FieldCacheImpl concurrency

2010-02-11 Thread Yonik Seeley
On Thu, Feb 11, 2010 at 9:54 AM, Shay Banon wrote: >    I would like to try and improve concurrency in Lucene in several places, > and thought I would start with FieldCacheImpl. The implementation is heavily > synchronized on both a global map and on creation values for a pretty > heavily used pat

FieldCacheImpl concurrency

2010-02-11 Thread Shay Banon
Hi, I would like to try and improve concurrency in Lucene in several places, and thought I would start with FieldCacheImpl. The implementation is heavily synchronized on both a global map and on creation values for a pretty heavily used path (get). I think the weak hash map is a good solution (