Re: LazyField retains temp char[] buffer

2006-10-09 Thread Yonik Seeley
On 10/8/06, Grant Ingersoll <[EMAIL PROTECTED]> wrote: I think I was modeling it after IndexInput which does a similar thing when reading in String data to avoid having to reallocate the buffer unless it is necessary. But you're right, in looking at it now, there really is no need for it since t

Re: LazyField retains temp char[] buffer

2006-10-08 Thread Grant Ingersoll
I think I was modeling it after IndexInput which does a similar thing when reading in String data to avoid having to reallocate the buffer unless it is necessary. But you're right, in looking at it now, there really is no need for it since the LazyField is instantiated each time it is read

Re: LazyField retains temp char[] buffer

2006-10-08 Thread Nicolas Lalevée
Le Samedi 07 Octobre 2006 18:29, Yonik Seeley a écrit : > While reviewing some of the LazyField code in preparation for Solr support, > https://issues.apache.org/jira/browse/SOLR-52 > I noticed that the char[] used to read the String data is a member, > and thus kept around after the data is read a

LazyField retains temp char[] buffer

2006-10-07 Thread Yonik Seeley
While reviewing some of the LazyField code in preparation for Solr support, https://issues.apache.org/jira/browse/SOLR-52 I noticed that the char[] used to read the String data is a member, and thus kept around after the data is read and a String constructed. It doesn't look like it serves any pur