Re: MergePolicy and IndexWriter methods argument

2009-07-26 Thread Shai Erera
I'll open an issue and work out a patch. Though this deprecation stuff is what I was worried of - they always tend to expand more than I plan to :). Shai On Sun, Jul 26, 2009 at 9:44 PM, Michael McCandless < luc...@mikemccandless.com> wrote: > I agree it's messy now. I think requiring the write

Re: MergePolicy and IndexWriter methods argument

2009-07-26 Thread Michael McCandless
I agree it's messy now. I think requiring the writer to be specified on creating the merge policy would make sense. You can't safely share a LMP today across multiple writers, yet the class "pretends" that you can... You'd also need to deprecate the public methods that take a writer in favor of

MergePolicy and IndexWriter methods argument

2009-07-26 Thread Shai Erera
Hi While reading LogMergePolicy I noticed that it uses IndexWriter's member and method arg inconsistently: 1) Some methods that receive IW as a parameer, do: this.indexWriter = indexWriter, and then use the member instance. 2) Others set the member instance, but continue to use the method arg. 3)