Re: BitVector.get bounds checking

2009-02-03 Thread Michael McCandless
Tell me about it! We gotta get 2.9/3.0 out, so we can switch to 1.5. The 1.5/1.6 line is less blurry :) Mike Andi Vajda wrote: On Tue, 3 Feb 2009, Michael McCandless wrote: Do you mean the assert statement? That's available since 1.4. Yeah, that's what I meant. 1.5 vs 1.4 is gettin

Re: BitVector.get bounds checking

2009-02-03 Thread Andi Vajda
On Tue, 3 Feb 2009, Michael McCandless wrote: Do you mean the assert statement? That's available since 1.4. Yeah, that's what I meant. 1.5 vs 1.4 is getting blurry :) Andi.. Mike Andi Vajda wrote: Isn't that depending on Java 1.5 ? Andi.. On Feb 3, 2009, at 11:38, Michael McCandless

RE: BitVector.get bounds checking

2009-02-03 Thread Uwe Schindler
Hi Andi, > Isn't that depending on Java 1.5 ? Assertions work since Java 1.4 I think. We have a lot of assertions in code. And it would not compile with -source 1.4, as we do. > wrote: > > > > > I think that makes sense. I'll wait a day or so and then commit it > > if there are no objections.

Re: BitVector.get bounds checking

2009-02-03 Thread Michael McCandless
Do you mean the assert statement? That's available since 1.4. Mike Andi Vajda wrote: Isn't that depending on Java 1.5 ? Andi.. On Feb 3, 2009, at 11:38, Michael McCandless > wrote: I think that makes sense. I'll wait a day or so and then commit it if there are no objections. Mike

Re: BitVector.get bounds checking

2009-02-03 Thread Andi Vajda
Isn't that depending on Java 1.5 ? Andi.. On Feb 3, 2009, at 11:38, Michael McCandless wrote: I think that makes sense. I'll wait a day or so and then commit it if there are no objections. Mike Jason Rutherglen wrote: A simple way to make BitVector faster would be to turn the get

Re: BitVector.get bounds checking

2009-02-03 Thread Michael McCandless
I think that makes sense. I'll wait a day or so and then commit it if there are no objections. Mike Jason Rutherglen wrote: A simple way to make BitVector faster would be to turn the get method bounds checking into an assertion. This is similar to OpenBitSet.fastGet. --