Re: some minor fixes

2007-11-19 Thread Tzvika Barenholz
Duly noted. I created https://issues.apache.org/jira/browse/LUCENE-1059 Tzvika On 11/19/07, Grant Ingersoll <[EMAIL PROTECTED]> wrote: > > Sure it fixes an issue. I think a JIRA issue is the best way to make > sure this doesn't get lost. > > -Grant > > On Nov 19, 2007, at 2:23 AM, Tzvika Barenho

Re: some minor fixes

2007-11-19 Thread Grant Ingersoll
Sure it fixes an issue. I think a JIRA issue is the best way to make sure this doesn't get lost. -Grant On Nov 19, 2007, at 2:23 AM, Tzvika Barenholz wrote: Hi Michael! The patch is attached to my previous message (and this one too). It doesn't actually fix an issue, so I don't see where

RE: some minor fixes

2007-11-18 Thread Uwe Schindler
> functionality. In someĀ  cases strings are compared with string literals > using ==. I can give a list if anyone thinks he or she will have use for > it. This is a speed optimization. All Strings compared by this function were "interned" before. This is done for e.g. all "field" names in Lucene.

RE: some minor fixes

2007-11-18 Thread Uwe Schindler
: java-dev@lucene.apache.org Subject: Re: some minor fixes Hi Michael! The patch is attached to my previous message (and this one too). It doesn't actually fix an issue, so I don't see where to put it otherwise. Please advise. *trying not to be difficult* :-) T On 11/18/0

Re: some minor fixes

2007-11-18 Thread Tzvika Barenholz
Hi Michael! The patch is attached to my previous message (and this one too). It doesn't actually fix an issue, so I don't see where to put it otherwise. Please advise. *trying not to be difficult* :-) T On 11/18/07, Michael McCandless <[EMAIL PROTECTED]> wrote: > > > Thank you! Yes please submi

Re: some minor fixes

2007-11-18 Thread Michael McCandless
Thank you! Yes please submit a patch and we can iterate from there. Mike "Tzvika Barenholz" <[EMAIL PROTECTED]> wrote: > Hello good people of Lucene! > > I've been using Lucene for a long while, but have only recently had occasion > to checkout the source code from the trunk and build it mysel