Michael McCandless wrote:
I do worry that wholesale formatting changes will obsolete pending
patches
Note that 'patch -l' will ignore whitespace, permitting indentation
changes w/o breaking patches.
Doug
-
To unsubscribe, e
It seems to me that the following would work:
1) All new code (contrib too) has to be formatted according to
published standards. This can be done either by the person doing the
submission, by a committer, or (It doesn't matter to me)
2) All existing code for which there is no patch can b
We _could_ do a wholesale change as part of 3.0, and then just make
sure that committers going forward format properly. I've seen other
projects do that.
Also, I'm not sure, but I think Hadoop's automated patch checker can
check to see if a patch is properly formatted or not. We need to a
I too am bugged by inconsistent formatting and must hold back the
temptation to fix it.
And I agree a patch for a real change should not mix-in formatting
changes.
I do worry that wholesale formatting changes will obsolete pending
patches (though really we should try to keep "pending pa