Re: IndexReader.isDeleted synchronization

2008-07-03 Thread Michael McCandless
Let's do it as a separate patch? The clone patch is already scaring me enough ;) Maybe we can allow creation of a read-only IndexReader during open? Ie, a new open method that takes a "boolean readOnly". I had been previously thinking that we'd get to a read-only IndexReader by slurpi

Re: IndexReader.isDeleted synchronization

2008-07-03 Thread Jason Rutherglen
Should we do a read-only reader as part of the clone patch? Sounds very similar. Also sounds like the delegate model will work best instead of creating a SegmentReader subclass. On Thu, Jul 3, 2008 at 7:55 AM, Michael McCandless < [EMAIL PROTECTED]> wrote: > > But I think you still need to sync

Re: IndexReader.isDeleted synchronization

2008-07-03 Thread Michael McCandless
But I think you still need to synchronize, because the first thread that does a deletion needs to create the deletedDocs BitVector and others need to wait while that's happening? I think [eventually] getting to a read-only reader is the best approach (https://issues.apache.org/jira/browse