Re: SegmentInfos extends Vector

2010-02-28 Thread Shai Erera
; segments > >> related methods. The collection's ones are really get and iterator? So > maybe > >> we should just impl Iterable and expose whatever API we feel is > necessary? > >> Back-compat wise, if we change anything in this class's > extension/impl

Re: SegmentInfos extends Vector

2010-02-28 Thread Michael McCandless
Uwe Schindler >> >> H.-H.-Meier-Allee 63, D-28213 Bremen >> >> http://www.thetaphi.de >> >> eMail: u...@thetaphi.de >> >> >> >> From: Shai Erera [mailto:ser...@gmail.com] >> Sent: Sunday, February 28, 2010 2:22 PM >> >> To:

Re: SegmentInfos extends Vector

2010-02-28 Thread Shai Erera
; my side. > > > > - > > Uwe Schindler > > H.-H.-Meier-Allee 63, D-28213 Bremen > > http://www.thetaphi.de > > eMail: u...@thetaphi.de > > > > *From:* Shai Erera [mailto:ser...@gmail.com] > *Sent:* Sunday, February 28, 2010 2:22 PM > > *T

RE: SegmentInfos extends Vector

2010-02-28 Thread Uwe Schindler
..@gmail.com] Sent: Sunday, February 28, 2010 2:04 PM To: java-dev@lucene.apache.org Subject: Re: SegmentInfos extends Vector Why do you say remove was unsupported before? I don't see it in the class's impl. It just inherits from Vector and so remove is supported by inheritance. S

Re: SegmentInfos extends Vector

2010-02-28 Thread Shai Erera
u...@thetaphi.de > > > > *From:* Shai Erera [mailto:ser...@gmail.com] > *Sent:* Sunday, February 28, 2010 2:04 PM > > *To:* java-dev@lucene.apache.org > *Subject:* Re: SegmentInfos extends Vector > > > > Why do you say remove was unsupported before? I don't se

Re: SegmentInfos extends Vector

2010-02-28 Thread DM Smith
> > Uwe Schindler > > H.-H.-Meier-Allee 63, D-28213 Bremen > > http://www.thetaphi.de > > eMail: u...@thetaphi.de > > > From: Shai Erera [mailto:ser...@gmail.com] > Sent: Sunday, February 28, 2010 1:38 PM > > > To: java-dev@lucene.apache.org

RE: SegmentInfos extends Vector

2010-02-28 Thread Uwe Schindler
-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de <http://www.thetaphi.de/> eMail: u...@thetaphi.de From: Shai Erera [mailto:ser...@gmail.com] Sent: Sunday, February 28, 2010 1:38 PM To: java-dev@lucene.apache.org Subject: Re: SegmentInfos extends Vector I would rather avoid i

Re: SegmentInfos extends Vector

2010-02-28 Thread Shai Erera
> > Uwe Schindler > > H.-H.-Meier-Allee 63, D-28213 Bremen > > http://www.thetaphi.de > > eMail: u...@thetaphi.de > > > > *From:* Shai Erera [mailto:ser...@gmail.com] > *Sent:* Sunday, February 28, 2010 1:38 PM > > *To:* java-dev@lucene.apache.org > *Su

RE: SegmentInfos extends Vector

2010-02-28 Thread Uwe Schindler
www.thetaphi.de <http://www.thetaphi.de/> eMail: u...@thetaphi.de From: Shai Erera [mailto:ser...@gmail.com] Sent: Sunday, February 28, 2010 1:20 PM To: java-dev@lucene.apache.org Subject: Re: SegmentInfos extends Vector Yes that's what I've been thinking as well - SegmentInfos sho

RE: SegmentInfos extends Vector

2010-02-28 Thread Uwe Schindler
ttp://www.thetaphi.de <http://www.thetaphi.de/> eMail: u...@thetaphi.de From: Shai Erera [mailto:ser...@gmail.com] Sent: Sunday, February 28, 2010 1:20 PM To: java-dev@lucene.apache.org Subject: Re: SegmentInfos extends Vector Yes that's what I've been thinking as well -

Re: SegmentInfos extends Vector

2010-02-28 Thread Shai Erera
8213 Bremen > > http://www.thetaphi.de > > eMail: u...@thetaphi.de > > > > *From:* Shai Erera [mailto:ser...@gmail.com] > *Sent:* Sunday, February 28, 2010 1:20 PM > > *To:* java-dev@lucene.apache.org > *Subject:* Re: SegmentInfos extends Vector > > > >

RE: SegmentInfos extends Vector

2010-02-28 Thread Uwe Schindler
phi.de eMail: u...@thetaphi.de From: Shai Erera [mailto:ser...@gmail.com] Sent: Sunday, February 28, 2010 1:20 PM To: java-dev@lucene.apache.org Subject: Re: SegmentInfos extends Vector Yes that's what I've been thinking as well - SegmentInfos should have a segments-related

Re: SegmentInfos extends Vector

2010-02-28 Thread Shai Erera
Yes that's what I've been thinking as well - SegmentInfos should have a segments-related API, not a List related. Whether the infos inside are kept in a Map, List, Collection or array is an implementation detail. In fact, I have a code which uses the API and could really benefit from a Map-like int

RE: SegmentInfos extends Vector

2010-02-28 Thread Uwe Schindler
I think this is historically. I have seen this in my big 3.0 generification patches, too. But I did not wanted to change it as Vector has other allocation schema than ArrayList. But maybe we should simply change it, it’s a package-private class, right? But in general subclassing those implem