Re: SegmentInfos extends Vector

2010-02-28 Thread Shai Erera
; segments > >> related methods. The collection's ones are really get and iterator? So > maybe > >> we should just impl Iterable and expose whatever API we feel is > necessary? > >> Back-compat wise, if we change anything in this class's > extension/impl

Re: SegmentInfos extends Vector

2010-02-28 Thread Michael McCandless
Uwe Schindler >> >> H.-H.-Meier-Allee 63, D-28213 Bremen >> >> http://www.thetaphi.de >> >> eMail: u...@thetaphi.de >> >> >> >> From: Shai Erera [mailto:ser...@gmail.com] >> Sent: Sunday, February 28, 2010 2:22 PM >> >> To:

Re: SegmentInfos extends Vector

2010-02-28 Thread Shai Erera
; my side. > > > > - > > Uwe Schindler > > H.-H.-Meier-Allee 63, D-28213 Bremen > > http://www.thetaphi.de > > eMail: u...@thetaphi.de > > > > *From:* Shai Erera [mailto:ser...@gmail.com] > *Sent:* Sunday, February 28, 2010 2:22 PM > > *T

RE: SegmentInfos extends Vector

2010-02-28 Thread Uwe Schindler
ct: Re: SegmentInfos extends Vector Ok so just that I'm cleared - unmodifiable you mean for iteration only right? And .. do you agree then to refactor the class, or prefer to keep it like that? If you agree, then we need to think if we do that by introducing a new class, or modify the e

Re: SegmentInfos extends Vector

2010-02-28 Thread Shai Erera
u...@thetaphi.de > > > > *From:* Shai Erera [mailto:ser...@gmail.com] > *Sent:* Sunday, February 28, 2010 2:04 PM > > *To:* java-dev@lucene.apache.org > *Subject:* Re: SegmentInfos extends Vector > > > > Why do you say remove was unsupported before? I don't se

Re: SegmentInfos extends Vector

2010-02-28 Thread DM Smith
> > Uwe Schindler > > H.-H.-Meier-Allee 63, D-28213 Bremen > > http://www.thetaphi.de > > eMail: u...@thetaphi.de > > > From: Shai Erera [mailto:ser...@gmail.com] > Sent: Sunday, February 28, 2010 1:38 PM > > > To: java-dev@lucene.apache.org

RE: SegmentInfos extends Vector

2010-02-28 Thread Uwe Schindler
ct: Re: SegmentInfos extends Vector Why do you say remove was unsupported before? I don't see it in the class's impl. It just inherits from Vector and so remove is supported by inheritance. Since the class is public, someone may have called it. Even if we change the class to impl List, per

Re: SegmentInfos extends Vector

2010-02-28 Thread Shai Erera
> > Uwe Schindler > > H.-H.-Meier-Allee 63, D-28213 Bremen > > http://www.thetaphi.de > > eMail: u...@thetaphi.de > > > > *From:* Shai Erera [mailto:ser...@gmail.com] > *Sent:* Sunday, February 28, 2010 1:38 PM > > *To:* java-dev@lucene.apache.org > *Su

RE: SegmentInfos extends Vector

2010-02-28 Thread Uwe Schindler
www.thetaphi.de <http://www.thetaphi.de/> eMail: u...@thetaphi.de From: Shai Erera [mailto:ser...@gmail.com] Sent: Sunday, February 28, 2010 1:20 PM To: java-dev@lucene.apache.org Subject: Re: SegmentInfos extends Vector Yes that's what I've been thinking as well - SegmentInfos sho

RE: SegmentInfos extends Vector

2010-02-28 Thread Uwe Schindler
ct: Re: SegmentInfos extends Vector I would rather avoid implementing List .. we should implement Iterable for sure, but I'd like to keep the API open either iterating in-order or getting a particular SegmentInfo. Another thing, I haven't seen anywhere that remove is called. In general I do

Re: SegmentInfos extends Vector

2010-02-28 Thread Shai Erera
8213 Bremen > > http://www.thetaphi.de > > eMail: u...@thetaphi.de > > > > *From:* Shai Erera [mailto:ser...@gmail.com] > *Sent:* Sunday, February 28, 2010 1:20 PM > > *To:* java-dev@lucene.apache.org > *Subject:* Re: SegmentInfos extends Vector > > > >

RE: SegmentInfos extends Vector

2010-02-28 Thread Uwe Schindler
phi.de eMail: u...@thetaphi.de From: Shai Erera [mailto:ser...@gmail.com] Sent: Sunday, February 28, 2010 1:20 PM To: java-dev@lucene.apache.org Subject: Re: SegmentInfos extends Vector Yes that's what I've been thinking as well - SegmentInfos should have a segments-related

Re: SegmentInfos extends Vector

2010-02-28 Thread Shai Erera
gt; > - > > Uwe Schindler > > H.-H.-Meier-Allee 63, D-28213 Bremen > > http://www.thetaphi.de > > eMail: u...@thetaphi.de > > > > *From:* Shai Erera [mailto:ser...@gmail.com] > *Sent:* Sunday, February 28, 2010 12:33 PM > *To:* java-dev@lucene.a

RE: SegmentInfos extends Vector

2010-02-28 Thread Uwe Schindler
- Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de <http://www.thetaphi.de/> eMail: u...@thetaphi.de From: Shai Erera [mailto:ser...@gmail.com] Sent: Sunday, February 28, 2010 12:33 PM To: java-dev@lucene.apache.org Subject: SegmentInfos extends Vector Hi

SegmentInfos extends Vector

2010-02-28 Thread Shai Erera
Hi What's the reason SegmentInfos extends Vector rather than say ArrayList? Do we need the synchronization around it which Vector provides? Shai