ttributeImpl.java
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: Uwe Schindler [mailto:u...@thetaphi.de]
> Sent: Friday, August 21, 2009 12:46 AM
> To: java-dev@lucene.apache.org
> Subject: RE: TypeAttribu
> -Original Message-
> From: Mark Miller [mailto:markrmil...@gmail.com]
> Sent: Friday, August 21, 2009 12:39 AM
> To: java-dev@lucene.apache.org
> Subject: TypeAttributeImpl
>
> Getting into the nitpick stuff ;)
>
> In TypeAttributeImpl:
>
> public
Getting into the nitpick stuff ;)
In TypeAttributeImpl:
public void copyTo(AttributeImpl target) {
TypeAttribute t = (TypeAttribute) target;
t.setType(new String(type));
}
The class uses type.equals and type.hashCode - is there any reason to
create a new String object here? Just use