Re: Uneffective writeBytes and readBytes [FIX]

2005-09-21 Thread Lukas Zapletal
Dne Thu, 08 Sep 2005 14:17:57 -0700 Doug Cutting <[EMAIL PROTECTED]> napsal(a): > This forces a flush() each time a byte array of any size is written. Oh I didnt scroll down the message, I have read this today. I see, I thought Lucene uses writeByte instead. I will reimplement the patch, sure.

Re: Uneffective writeBytes and readBytes [FIX]

2005-09-09 Thread Lukas Zapletal
Dne Thu, 8 Sep 2005 05:45:59 -0700 (PDT) Otis Gospodnetic <[EMAIL PROTECTED]> napsal(a): > Did you measure, or at least observe the performance improvement this > change made? Oh yes! In the indexing of one 200MB HTML archive, there was no measurable performance gain, BUT when calling method wri

Re: Uneffective writeBytes and readBytes [FIX]

2005-09-08 Thread Doug Cutting
Paul Elschot wrote: I suppose one of these cases are when many terms are used in a query. Would it be easily possible to make the buffer size for a term iterator depend on the numbers of documents to be iterated? Many terms only occur in a few documents, so this could be a nice win on total buf

Re: Uneffective writeBytes and readBytes [FIX]

2005-09-08 Thread Paul Elschot
On Thursday 08 September 2005 23:17, Doug Cutting wrote: > I don't in general disagree with this sort of optimization, but I think > a good fix is a bit more complicated than what you posted. > > Lukas Zapletal wrote: > > And here comes the fixes: > > ... > > > There is significant time improve

Re: Uneffective writeBytes and readBytes [FIX]

2005-09-08 Thread Doug Cutting
I don't in general disagree with this sort of optimization, but I think a good fix is a bit more complicated than what you posted. Lukas Zapletal wrote: And here comes the fixes: OutputStream: /** * Writes an array of bytes. * * @param b *the bytes

Re: Uneffective writeBytes and readBytes [FIX]

2005-09-08 Thread Otis Gospodnetic
Hi Lukas, Did you measure, or at least observe the performance improvement this change made? The changes look fine to me, although there are comments next to code for reading/writing 1 byte at a time (the non-buffered part), so Doug obviously wanted it that way, and I don't know why... Otis --

Re: Uneffective writeBytes and readBytes [FIX]

2005-09-08 Thread Maik Schreiber
> did anyone tested the patches? Any results? Perhaps you should try and create a real patch (unified diff comes to mind), and post that one here. -- Maik Schreiber * http://www.blizzy.de GPG public key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x1F11D713 Key fingerprint: CF19 AFCE

Re: Uneffective writeBytes and readBytes [FIX]

2005-09-07 Thread Lukas Zapletal
Dne Tue, 6 Sep 2005 13:15:02 +0200 Lukas Zapletal <[EMAIL PROTECTED]> napsal(a): > And here comes the fixes: Hi there, did anyone tested the patches? Any results? -- S pozdravem / Best regards Lukas Zapletal sefredaktor / editor-in-chief LinuxEXPRES - opravdovy linuxovy magazin www.LinuxEXPRE

Re: Uneffective writeBytes and readBytes [FIX]

2005-09-06 Thread Lukas Zapletal
And here comes the fixes: OutputStream: /** * Writes an array of bytes. * * @param b *the bytes to write * @param length *the number of bytes to write * @see InputStream#readBytes(byte[],int,int)