Re: back compat testing

2008-12-01 Thread Michael McCandless
I've created this branch (lucene_2_4_back_compat_tests) and fix the build scripts to use that branch. I haven't removed all but tests cases on the branch yet -- I think we don't actually need to do that? Ie, nobody should ever checkout that branch and run "ant test" (it's only "ant test

Re: back compat testing

2008-11-26 Thread Michael McCandless
Oh that's a good idea. OK I'll take this approach. Mike Michael Busch wrote: +1. I think this makes sense. To get around the problem of testcases being dependent on package- private APIs that change between minor releases, maybe we should *only* have testcases in that branch? Otherwise i

Re: back compat testing

2008-11-26 Thread Michael Busch
+1. I think this makes sense. To get around the problem of testcases being dependent on package-private APIs that change between minor releases, maybe we should *only* have testcases in that branch? Otherwise if we have to make a change to a test to make it compile with an API we changed in tr

back compat testing

2008-11-26 Thread Michael McCandless
We now run "ant test-tag" in the nightly build, to verify that all unit tests in 2.4.0 still pass, which is awesome. But, for LUCENE-1464, which is ready to commit, there is a bug in TestLockFactory whereby its rmDir method hits an NPE if the directory doesn't exist. For two testcases that now