Re: contrib additions in 2.0

2006-05-25 Thread Doug Cutting
Chris Hostetter wrote: My gut says go ahead and commit them (ASAP if the plan is to release 2.0 this weekend), but as the guy that submited both of them, i feel like maybe i'm not the most impartial person to decide. +1 For new code that cannot break existing functionality the bar is lower. D

Re: contrib additions in 2.0

2006-05-25 Thread Erik Hatcher
I think having these committed to the contrib area is ok prior to 2.0. Let's see what others say. Erik On May 25, 2006, at 4:13 AM, Chris Hostetter wrote: I'd like to commit the following two submissions... http://issues.apache.org/jira/browse/LUCENE-496 http://issues.apache.org/

contrib additions in 2.0

2006-05-25 Thread Chris Hostetter
I'd like to commit the following two submissions... http://issues.apache.org/jira/browse/LUCENE-496 http://issues.apache.org/jira/browse/LUCENE-577 ...but it's not clear to me wether the best time to do that is before or after the 2.0 release: * neither patch fixes a bug, which suggests i shoul