Re: snowball discussion on LUCENE-2285

2010-02-27 Thread Shai Erera
I created LUCENE-2288 for handling the Object[] thingy in SnowballProgram (and Class[] in Among). Shai On Sat, Feb 27, 2010 at 8:48 PM, Robert Muir wrote: > Can you open an issue for the new object[]? its sad about the hungarian > issue. I'm inclined to think we should add savoy's and default

Re: snowball discussion on LUCENE-2285

2010-02-27 Thread Robert Muir
Can you open an issue for the new object[]? its sad about the hungarian issue. I'm inclined to think we should add savoy's and default to it instead. I don't see this as code duplication, as its a different alg. Normally just don't spend a lot of effort towards adding alternative stemmers, but h

Re: snowball discussion on LUCENE-2285

2010-02-27 Thread Shai Erera
Hi Robert, the EMPTY_ARGS stuff is just in SnowballProgram. I didn't touch the generated code, besides handling calling deprecated API. We've actually taken the same approach I think :). In my Analyzer, the user passes a Locale to create the proper Analyzer. The analyzer comes pre-configured w/ al

snowball discussion on LUCENE-2285

2010-02-27 Thread Robert Muir
i wanted to continue this here to not clog up the issue! Shai Erera commented on LUCENE-2285: > bq. I'd be curious to know what you did > > Ok, now you've made me compare the two :). I'm happy to see we both did the > same thing, only you call your buffer 'current' while I call it 'buf'. > Beside