Fwd: svn commit: r168454 - /lucene/java/trunk/src/test/org/apache/lucene/search/CheckHits.java

2005-05-06 Thread Paul Elschot
Daniel, When using the static TestCase methods it is quite likely that the testCase attribute of CheckHits can be removed completely. I suppose JUnit assumes a single thread for reporting errors/failures of a test case? Regards, Paul Elschot -- Forwarded Message -- Subject:

Re: build process changes

2005-05-06 Thread Barry Hawkins
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Agreed. Not that I have a vote, but that convention has made many of the Jakarta Commons libs much easier to track in my projects. Yonik Seeley wrote: > Definitely. That's exactly our usecase... copying all the jars we > need (or perhaps all of them

Re: svn commit: r168450 - in /lucene/java/trunk/src/java/org/apache/lucene: index/SegmentMerger.java search/MultiPhraseQuery.java search/MultiSearcher.java search/PhrasePrefixQuery.java search/PhraseQ

2005-05-06 Thread Doug Cutting
[EMAIL PROTECTED] wrote: don't declare Exceptions that are never thrown; remove an unused variable When these are implementing a pubic interface or abstract method I think it is good to keep the exception declaration, as it is a part of the interface. That way, if an exception needs to be thrown

Re: svn commit: r168450 - in /lucene/java/trunk/src/java/org/apache/lucene: index/SegmentMerger.java search/MultiPhraseQuery.java search/MultiSearcher.java search/PhrasePrefixQuery.java search/PhraseQ

2005-05-06 Thread Daniel Naber
On Friday 06 May 2005 20:00, Doug Cutting wrote: > When these are implementing a pubic interface or abstract method I think > it is good to keep the exception declaration, as it is a part of the > interface. Yes, I'm aware of that. All my changes (unless I made a mistake) only affected private o

multi-field highlighting

2005-05-06 Thread Doug Cutting
There's a post over at SearchEngineWatch theorizing about how Google produces summaries. http://forums.searchenginewatch.com/showthread.php?threadid=5448 Lucene's current highlighter doesn't easily support multi-fields, nor does it take phrasal matching into account. It might be useful to have

Re: multi-field highlighting

2005-05-06 Thread Martin Haye
As part of my work on XTF for the California Digital Library, I've written such a highlighter. You can see it in action here: http://texts.cdlib.org/escholarship/ It supports multi-field highlighting, and ranks the matches within a document field. It highlights the extent of the actual

Re: multi-field highlighting

2005-05-06 Thread markharw00d
Phrase highlighting (and spans) would certainly be useful, as would multi-field. Before we leap into adding code into the highlighter though I think it's worth considering what we are trying to fix here in a more general sense. As a basic principle I think highlighting should attempt to show the

Re: multi-field highlighting

2005-05-06 Thread markharw00d
Hi Martin, welcome to the group. >>You can see it in action here: Very nice work! I like the forward/backward links between hits. Unfortunately, it involves significant additions to the Lucene core. In essence it relies on an amped-up span system that is capable of scoring the spans, as well as rec

File.isFile() and links

2005-05-06 Thread Daniel Naber
Hi, I'd like to add this code to FSDirectory.create(): if (directory.isFile()) throw new IOException("Expected directory, but '" + directory + "' is a file"); This way people will get a useful exception if they specify a file instead of a directory (currently this leads to

Re: multi-field highlighting

2005-05-06 Thread Martin Haye
Hi Mark, Thanks very much for your comments. > It looks like all queries on the site have to be a span of some > kind (ie all search terms must appear in the document). Is your > highlighting code applicable to other modes of querying? In a sense you're correct, in that the system relies on all