[jira] Created: (LUCENE-714) Use a System.arraycopy more than a for

2006-11-17 Thread JIRA
Use a System.arraycopy more than a for -- Key: LUCENE-714 URL: http://issues.apache.org/jira/browse/LUCENE-714 Project: Lucene - Java Issue Type: Improvement Reporter: Nicolas Lalevée

[jira] Updated: (LUCENE-714) Use a System.arraycopy more than a for

2006-11-17 Thread JIRA
[ http://issues.apache.org/jira/browse/LUCENE-714?page=all ] Nicolas Lalevée updated LUCENE-714: --- Attachment: DocumentWriter.patch Use a System.arraycopy more than a for -- Key: LUCENE-714

[jira] Commented: (LUCENE-714) Use a System.arraycopy more than a for

2006-11-17 Thread JIRA
[ http://issues.apache.org/jira/browse/LUCENE-714?page=comments#action_12450680 ] Nicolas Lalevée commented on LUCENE-714: About the priority of the issue, I didn't want to set it to Major, I just forget to set it correctly. Use a

[jira] Commented: (LUCENE-714) Use a System.arraycopy more than a for

2006-11-17 Thread Michael McCandless (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-714?page=comments#action_12450704 ] Michael McCandless commented on LUCENE-714: --- Thanks for the patch! OK, it looks like you're replacing two cases in DocumentWriter.java where we are

[jira] Updated: (LUCENE-714) Use a System.arraycopy more than a for

2006-11-17 Thread Michael McCandless (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-714?page=all ] Michael McCandless updated LUCENE-714: -- Priority: Minor (was: Major) Use a System.arraycopy more than a for -- Key: LUCENE-714

[jira] Updated: (LUCENE-714) Use a System.arraycopy more than a for

2006-11-17 Thread Michael McCandless (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-714?page=all ] Michael McCandless updated LUCENE-714: -- Lucene Fields: [New, Patch Available] (was: [New]) Use a System.arraycopy more than a for --

[jira] Resolved: (LUCENE-714) Use a System.arraycopy more than a for

2006-11-17 Thread Michael McCandless (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-714?page=all ] Michael McCandless resolved LUCENE-714. --- Fix Version/s: 2.1 Resolution: Fixed Committed! Thanks Nicolas -- keep the patches coming! Use a System.arraycopy more than a for

[jira] Commented: (LUCENE-584) Decouple Filter from BitSet

2006-11-17 Thread Paul Elschot (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-584?page=comments#action_12450715 ] Paul Elschot commented on LUCENE-584: - I have just resolved some minor local conflicts on the updated copyrights of four java files. Please holler when a

Re: svn commit: r468289 - /lucene/java/trunk/CHANGES.txt

2006-11-17 Thread Yonik Seeley
It might be nice to try and limit reformatting changes to CHANGES.txt in the future. It's useful to be able to use diff on CHANGES.txt to document what has changed for lucene users (and it obviously didn't work that well this time ;-) -Yonik On 10/27/06, [EMAIL PROTECTED] [EMAIL PROTECTED]

[jira] Commented: (LUCENE-709) [PATCH] Enable application-level management of IndexWriter.ramDirectory size

2006-11-17 Thread Yonik Seeley (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-709?page=comments#action_12450791 ] Yonik Seeley commented on LUCENE-709: - A couple of points: - synchronizing the hashTable doesn't help solve the outlined scenario above since the logic that

[jira] Updated: (LUCENE-709) [PATCH] Enable application-level management of IndexWriter.ramDirectory size

2006-11-17 Thread Yonik Seeley (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-709?page=all ] Yonik Seeley updated LUCENE-709: Attachment: ramdir.patch What do people think of this patch to RAMDirectory that keeps track of the size of closed files with a minimum of overhead, in

[jira] Commented: (LUCENE-709) [PATCH] Enable application-level management of IndexWriter.ramDirectory size

2006-11-17 Thread Yonik Seeley (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-709?page=comments#action_12450800 ] Yonik Seeley commented on LUCENE-709: - I'm referring to ramdir.patch that I just attached (It would be nice if JIRA would show a link in the comments to what

Re: svn commit: r468289 - /lucene/java/trunk/CHANGES.txt

2006-11-17 Thread Doug Cutting
Yonik Seeley wrote: It might be nice to try and limit reformatting changes to CHANGES.txt in the future. It's useful to be able to use diff on CHANGES.txt to document what has changed for lucene users (and it obviously didn't work that well this time ;-) +1 In general we should resist the

[jira] Commented: (LUCENE-709) [PATCH] Enable application-level management of IndexWriter.ramDirectory size

2006-11-17 Thread Yonik Seeley (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-709?page=comments#action_12450833 ] Yonik Seeley commented on LUCENE-709: - we could add a bufferAdded(int size) method to RAMOutputStream, and increment the directory size whenever this is

Re: [jira] Updated: (LUCENE-675) Lucene benchmark: objective performance test for Lucene

2006-11-17 Thread Doron Cohen
Paul Elschot [EMAIL PROTECTED] wrote on 16/11/2006 14:03:23: Did you svn add the new files locally before doing svn diff? It took me a quite while to get the hang of that. It is mentioned here: http://wiki.apache.org/jakarta-lucene/HowToContribute Thanks Paul, In fact TortoiseSVN does the

Re: [jira] Updated: (LUCENE-675) Lucene benchmark: objective performance test for Lucene

2006-11-17 Thread Doron Cohen
Steven Rowe [EMAIL PROTECTED] wrote on 16/11/2006 14:21:37: I haven't tried to use TortoiseSVN to create patches, but my experience with it for other purposes has been negative enough, especially in trying to use it on the same working copy on which I use a Cygwin command-line version of SVN,

[jira] Commented: (LUCENE-709) [PATCH] Enable application-level management of IndexWriter.ramDirectory size

2006-11-17 Thread Yonik Seeley (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-709?page=comments#action_12450838 ] Yonik Seeley commented on LUCENE-709: - Keeping track of buffers does complicate figuring how much to subtract on a delete. We could: 1) iterate over

Re: [jira] Updated: (LUCENE-675) Lucene benchmark: objective performance test for Lucene

2006-11-17 Thread Daniel John Debrunner
Doron Cohen wrote: And, for applying the patch, again from cygwin shell: - patch -p0 -i patchFile.patch The -p0 was also something that I was missing. FYI, I had endless issues with 'patch' with patches from contributors on the derby project, depending on if they were running windows or

[jira] Closed: (LUCENE-664) [PATCH] small fixes to the new scoring.html doc

2006-11-17 Thread Grant Ingersoll (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-664?page=all ] Grant Ingersoll closed LUCENE-664. -- [PATCH] small fixes to the new scoring.html doc --- Key: LUCENE-664 URL:

[jira] Created: (LUCENE-715) IndexWriter does not release its write lock when trying to open an index which does not yet exist

2006-11-17 Thread Matthew Bogosian (JIRA)
IndexWriter does not release its write lock when trying to open an index which does not yet exist - Key: LUCENE-715 URL:

[jira] Updated: (LUCENE-715) IndexWriter does not release its write lock when trying to open an index which does not yet exist

2006-11-17 Thread Matthew Bogosian (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-715?page=all ] Matthew Bogosian updated LUCENE-715: Attachment: LUCENE-715.patch Attaching the fix as a patch. All tests pass. Patch includes fix, test case and modifications to the CHANGES.txt file.

[jira] Updated: (LUCENE-573) Escaped quotes inside a phrase cause a ParseException

2006-11-17 Thread Michael Busch (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-573?page=all ] Michael Busch updated LUCENE-573: - Attachment: LUCENE-573_new.patch I actually found another problem in the current unescaping code: junit.framework.AssertionFailedError: Query /a\\\+b/

[jira] Updated: (LUCENE-573) Escaped quotes inside a phrase cause a ParseException

2006-11-17 Thread Michael Busch (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-573?page=all ] Michael Busch updated LUCENE-573: - Attachment: (was: escaped_quotes_inside_phrases.patch) Escaped quotes inside a phrase cause a ParseException

[jira] Created: (LUCENE-716) Support unicode escapes in QueryParser

2006-11-17 Thread Michael Busch (JIRA)
Support unicode escapes in QueryParser -- Key: LUCENE-716 URL: http://issues.apache.org/jira/browse/LUCENE-716 Project: Lucene - Java Issue Type: Improvement Components: QueryParser

[jira] Updated: (LUCENE-573) Escaped quotes inside a phrase cause a ParseException

2006-11-17 Thread Michael Busch (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-573?page=all ] Michael Busch updated LUCENE-573: - Lucene Fields: [Patch Available] Escaped quotes inside a phrase cause a ParseException -

[jira] Commented: (LUCENE-715) IndexWriter does not release its write lock when trying to open an index which does not yet exist

2006-11-17 Thread Michael McCandless (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-715?page=comments#action_12450875 ] Michael McCandless commented on LUCENE-715: --- Good catch! And thanks for the patch. Plus I like the perl-ese correction above. It looks like with this

[jira] Commented: (LUCENE-709) [PATCH] Enable application-level management of IndexWriter.ramDirectory size

2006-11-17 Thread Doug Cutting (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-709?page=comments#action_12450880 ] Doug Cutting commented on LUCENE-709: - If we add a RAMFile.totalBufferSize() method then we can easily change the implementation later. For now, I'd choose

[jira] Updated: (LUCENE-709) [PATCH] Enable application-level management of IndexWriter.ramDirectory size

2006-11-17 Thread Yonik Seeley (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-709?page=all ] Yonik Seeley updated LUCENE-709: Attachment: ramdir.patch Attaching new un-tested ramdir.patch: - keeps track of buffers added instead of file length. - handles overwrites - adds

[jira] Commented: (LUCENE-573) Escaped quotes inside a phrase cause a ParseException

2006-11-17 Thread Yonik Seeley (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-573?page=comments#action_12450886 ] Yonik Seeley commented on LUCENE-573: - Thanks Michael, I haven't had a chance to look at the code yet, but I agree with your description of all the changes.

[jira] Updated: (LUCENE-709) [PATCH] Enable application-level management of IndexWriter.ramDirectory size

2006-11-17 Thread Chuck Williams (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-709?page=all ] Chuck Williams updated LUCENE-709: -- Attachment: ramDirSizeManagement.patch I've just attached my version of this patch. It includes a multi-threaded test case. I believe it is sound. A

[jira] Commented: (LUCENE-709) [PATCH] Enable application-level management of IndexWriter.ramDirectory size

2006-11-17 Thread Chuck Williams (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-709?page=comments#action_12450894 ] Chuck Williams commented on LUCENE-709: --- I didn't see Yonik's new version or comments until after my attach. Throwing IOExceptions when files that should

[jira] Updated: (LUCENE-715) IndexWriter does not release its write lock when trying to open an index which does not yet exist

2006-11-17 Thread Matthew Bogosian (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-715?page=all ] Matthew Bogosian updated LUCENE-715: Attachment: LUCENE-715.patch Ugh! How embarrassing! If it makes you feel better, I re-raised the exception in my mind ;-) I added the the missing

[jira] Commented: (LUCENE-715) IndexWriter does not release its write lock when trying to open an index which does not yet exist

2006-11-17 Thread Michael McCandless (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-715?page=comments#action_12450913 ] Michael McCandless commented on LUCENE-715: --- Don't worry about it :) This is what open source is all about! OK this looks good to me. I will commit.

[jira] Resolved: (LUCENE-715) IndexWriter does not release its write lock when trying to open an index which does not yet exist

2006-11-17 Thread Michael McCandless (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-715?page=all ] Michael McCandless resolved LUCENE-715. --- Fix Version/s: 2.1 Resolution: Fixed IndexWriter does not release its write lock when trying to open an index which does not yet exist

[jira] Resolved: (LUCENE-701) Lock-less commits

2006-11-17 Thread Michael McCandless (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-701?page=all ] Michael McCandless resolved LUCENE-701. --- Fix Version/s: 2.1 Resolution: Fixed Lock-less commits - Key: LUCENE-701 URL: