[VOTE] Commit LUCENE-843 (IndexWriter performance gains)

2007-07-02 Thread Michael McCandless
Hi, I'd like to commit LUCENE-843. The patch has gone through a number of iterations but the final version that's there now (take9) is quite a bit cleaner & simpler than the ones leading up to it and I believe ready. It provides solid indexing performance gains (between 2X-8X), but, it is somewh

[jira] Created: (LUCENE-947) Some improvements to contrib/benchmark

2007-07-02 Thread Michael McCandless (JIRA)
Some improvements to contrib/benchmark -- Key: LUCENE-947 URL: https://issues.apache.org/jira/browse/LUCENE-947 Project: Lucene - Java Issue Type: Improvement Components: contrib/benchmark

[jira] Updated: (LUCENE-947) Some improvements to contrib/benchmark

2007-07-02 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-947: -- Attachment: LUCENE-947.patch First cut patch. > Some improvements to contrib/benchmark

[jira] Commented: (LUCENE-856) Optimize segment merging

2007-07-02 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509576 ] Michael McCandless commented on LUCENE-856: --- I ran a new performance comparison here to test the merging c

Re: [VOTE] Commit LUCENE-843 (IndexWriter performance gains)

2007-07-02 Thread Yonik Seeley
On 7/2/07, Michael McCandless <[EMAIL PROTECTED]> wrote: I'd like to commit LUCENE-843. +1 Awesome job! The patch has gone through a number of iterations but the final version that's there now (take9) is quite a bit cleaner & simpler than the ones leading up to it and I believe ready. It pro

ant jar-core is slow

2007-07-02 Thread Michael McCandless
I've noticed that "ant jar-core" walks the full subtree; this is very slow and in fact is deadly when wikipedia XML has been unpacked (~3.2 million files under contrib/benchmark/work/enwiki!). I've tracked it down to this nested element in the jar task in common-build.xml: which refe

[jira] Updated: (LUCENE-892) CompoundFileReader's openInput produces streams that may do an extra buffer copy

2007-07-02 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-892: -- Attachment: LUCENE-892.patch Attached patch that implements the design above (make an I

[jira] Updated: (LUCENE-892) CompoundFileReader's openInput produces streams that may do an extra buffer copy

2007-07-02 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-892: -- Lucene Fields: [New, Patch Available] (was: [New]) > CompoundFileReader's openInput pr

Re: [VOTE] Commit LUCENE-843 (IndexWriter performance gains)

2007-07-02 Thread Grant Ingersoll
On Jul 2, 2007, at 9:35 AM, Michael McCandless wrote: Hi, I'd like to commit LUCENE-843. The patch has gone through a number of iterations but the final version that's there now (take9) is quite a bit cleaner & simpler than the ones leading up to it and I believe ready. It provides solid ind

Re: ant jar-core is slow

2007-07-02 Thread Chris Hostetter
: which references this "metainf.includes" patternset: : : : : : : Does this rule just exclude everything? (I'm not very familiar w/ the : syntax here). EG I don't see anything besides LICENSE.txt and NOTICE.txt : and MANIFEST.MF under the "META-INF" dir in the released 2.2.0 core JAR,

Re: ant jar-core is slow

2007-07-02 Thread Michael McCandless
"Chris Hostetter" <[EMAIL PROTECTED]> wrote: > : which references this "metainf.includes" patternset: > : > : > : > : > : > : Does this rule just exclude everything? (I'm not very familiar w/ the > : syntax here). EG I don't see anything besides LICENSE.txt and > NOTICE.txt > : and MAN

[jira] Commented: (LUCENE-645) Highligter fails to include non-token at end of string to be highlighted

2007-07-02 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509643 ] Mark Miller commented on LUCENE-645: This issue has been fixed. > Highligter fails to include non-token at end o

Re: [VOTE] Commit LUCENE-843 (IndexWriter performance gains)

2007-07-02 Thread Grant Ingersoll
Also, is it worth considering a couple of things: 1. Do a build version release prior to committing (i.e. 2.2.1) that way we could isolate this change and do a separate release to 2.3. I don't want to do releases just for the sake of releases, but I think we should at least prepare people

Re: [VOTE] Commit LUCENE-843 (IndexWriter performance gains)

2007-07-02 Thread Yonik Seeley
On 7/2/07, Grant Ingersoll <[EMAIL PROTECTED]> wrote: 2. or, at a minimum, do a tag of the trunk right before committing. I just find explicit tags make it easier to rollback or compare diffs if need be You can always use an explicit revision number, which is easy to find out from the bug, or y

Re: ant jar-core is slow

2007-07-02 Thread Chris Hostetter
: That doesn't seem to change things. However, this seems to : successfully match nothing without taking a long time doing so :) : : : : ah ... yes, because ant first compares files to the directives, and only if they match does it compare with the directives ... and if there is no

Re: [VOTE] Commit LUCENE-843 (IndexWriter performance gains)

2007-07-02 Thread Doug Cutting
+1 This is great work! Commit it. Doug Michael McCandless wrote: Hi, I'd like to commit LUCENE-843. The patch has gone through a number of iterations but the final version that's there now (take9) is quite a bit cleaner & simpler than the ones leading up to it and I believe ready. It provid

Build failed in Hudson: Lucene-Nightly #140

2007-07-02 Thread hudson
See http://lucene.zones.apache.org:8080/hudson/job/Lucene-Nightly/140/changes Changes: [hossman] hack to prevent ant from recursively stating all files in all directories looking for files to include in the META-INF -- [...truncated 15412 lines...]