Re: [jira] Created: (LUCENE-1257) Port to Java5

2008-04-11 Thread Endre Stølsvik
robert engels wrote: The 'foreach' should be faster in the general case for arrays as the bounds checking can be avoided. Why is that? Where do you mean that the bounds-checking can be avoided? But, I doubt the speed difference is going to matter much either way, and eventually the JVM i

[jira] Commented: (LUCENE-1262) IndexOutOfBoundsException from FieldsReader after problem reading the index

2008-04-11 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587896#action_12587896 ] Michael McCandless commented on LUCENE-1262: OK indeed I can get the failure t

[jira] Updated: (LUCENE-1262) IndexOutOfBoundsException from FieldsReader after problem reading the index

2008-04-11 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-1262: --- Attachment: LUCENE-1262.patch Attached patch. All tests pass. I plan to commit in

Deprecation of flush in IndexWriter

2008-04-11 Thread Shay Banon
Hi, I was just looking a bit at the trunk. First, let me say that the progress you guys make is amazing!. I would still like to ask a quick question regarding deprecation of flush in IndexWriter. I think that there are cases where flush is needed. For example, in trying to create a two phase (

Re: [jira] Created: (LUCENE-1257) Port to Java5

2008-04-11 Thread robert engels
When iterating over an array using an indexed loop, you typically need to access the element, as follows: for(int i=0;i<100;i++) { String s = array[i]; ... } Java performs bounds checking on the array[i] access to make sure i is within the limits of the array. Granted, there

[jira] Updated: (LUCENE-1260) Norm codec strategy in Similarity

2008-04-11 Thread Karl Wettin (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Wettin updated LUCENE-1260: Attachment: LUCENE-1260.txt Fixed some typos and added some tests. Perhaps it needs new javadocs t

[jira] Commented: (LUCENE-1260) Norm codec strategy in Similarity

2008-04-11 Thread Karl Wettin (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587954#action_12587954 ] Karl Wettin commented on LUCENE-1260: - This is a retroactive ASL blessing of the patch

Re: [jira] Commented: (LUCENE-1260) Norm codec strategy in Similarity

2008-04-11 Thread Chris Hostetter
: I still am but mainly because it is the simplest and only way to get : better document boost resolution at the moment. I would argue that using a FieldScoreQuery is the easiest way to get better document boost resolution ... but it doesn't change the fact thta support for more flexible norm

Re: index reopen question

2008-04-11 Thread Chris Hostetter
: 1) looking at the code: : : if (this.hasChanges || this.isCurrent()) { : // the index hasn't changed - nothing to do here : return this; : } :Shouldn't it be !this.hasChanges? ...that's from DirectoryIndexReader, and it sure looks like a bug to me. : 2) FilterIndexRe

Re: [jira] Created: (LUCENE-1257) Port to Java5

2008-04-11 Thread Chris Hostetter
Since i had to read robert's email about 3 times before i got what he was saying, i'll elaborate in case anyone else is scratching their head as much as i was... because you could write code that looks like this... for (int i = 0; i < arr.length; i++) { i = getSomeNumberNotBetweenZero

Re: [jira] Created: (LUCENE-1257) Port to Java5

2008-04-11 Thread robert engels
Correct. On Apr 11, 2008, at 7:43 PM, Chris Hostetter wrote: Since i had to read robert's email about 3 times before i got what he was saying, i'll elaborate in case anyone else is scratching their head as much as i was... because you could write code that looks like this... for (int i

Re: index reopen question

2008-04-11 Thread Michael Busch
Chris Hostetter wrote: : 1) looking at the code: : : if (this.hasChanges || this.isCurrent()) { : // the index hasn't changed - nothing to do here : return this; : } :Shouldn't it be !this.hasChanges? ...that's from DirectoryIndexReader, and it sure looks like a bug t