CharArraySet makes excessive use of Character.toLowerCase

Hi I noticed that CharArraySet uses Character.toLowerCase in many places in the code. I think it uses it too much unnecessarily. For example, the equals(char[], int, int, char[]) method converts the characters to lower case if ignoreCase is true, although it could have been converted in one of the

[jira] Commented: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for multiple subreaders

[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659436#action_12659436 ] Michael McCandless commented on LUCENE-1483: {quote} > Only other option I see

[jira] Commented: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for multiple subreaders

[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659437#action_12659437 ] Mark Miller commented on LUCENE-1483: - Nice Mike! Definitely what needs to be done and

Re: CharArraySet makes excessive use of Character.toLowerCase

I think all of these changes make sense! I would just remove that if (false &&...) dead code. Mike Shai Erera wrote: > Hi > > I noticed that CharArraySet uses Character.toLowerCase in many places in > the code. I think it uses it too much unnecessarily. > For example, the equals(char[], int, in

[jira] Commented: (LUCENE-1496) Move solr NumberUtils to lucene

[ https://issues.apache.org/jira/browse/LUCENE-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659445#action_12659445 ] Uwe Schindler commented on LUCENE-1496: --- I am thinking about extending TrieUtils and

Re: Blob storage

> PS I am relicensing skwish under Apache 2.0 and am in the process of > re-releasing it from the project website under this new license. (I'm > not that efficient with such chores, so bear with me :) DONE On Sat, Dec 27, 2008 at 1:15 AM, Babak Farhang wrote: >> - there will be a trade-off where

[jira] Created: (LUCENE-1501) Phonetic filters

Phonetic filters Key: LUCENE-1501 URL: https://issues.apache.org/jira/browse/LUCENE-1501 Project: Lucene - Java Issue Type: New Feature Components: contrib/* Reporter: Karl Wettin Assignee:

[jira] Updated: (LUCENE-1501) Phonetic filters

[ https://issues.apache.org/jira/browse/LUCENE-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Wettin updated LUCENE-1501: Attachment: LUCENE-1501.txt This is in need of a bit of documentation about the different algorith

Re: CharArraySet makes excessive use of Character.toLowerCase

Thanks, I'll open an issue and create a patch On Sun, Dec 28, 2008 at 5:55 PM, Michael McCandless < luc...@mikemccandless.com> wrote: > > I think all of these changes make sense! > I would just remove that if (false &&...) dead code. > > Mike > > > Shai Erera wrote: > >> Hi >> >> I noticed that

Re: CharArraySet makes excessive use of Character.toLowerCase

Ok it might not be that easy to make the changes. While add() clearly states that the passed char[] may be modified if ignoreCase is true, it is not the case for contains(char[]). If I first lower case the passed in char[], it modifies the instance the application holds, and then the "Now" will be