Re: Payloads and TrieRangeQuery

2009-06-14 Thread Earwin Burrfoot
> Just to throw something out, the new Token API is not very consumable in my > experience. The old one was very intuitive and very easy to follow the code. > > I've had to refigure out what the heck was going on with the new one more > than once now. Writing some example code with it is hard to fo

[jira] Commented: (LUCENE-1673) Move TrieRange to core

2009-06-14 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719242#action_12719242 ] Uwe Schindler commented on LUCENE-1673: --- I am currently preparing a first patch for

[jira] Commented: (LUCENE-1630) Mating Collector and Scorer on doc Id orderness

2009-06-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719243#action_12719243 ] Shai Erera commented on LUCENE-1630: If that's agreed, then I'll do it and put a NOTE

[jira] Commented: (LUCENE-1673) Move TrieRange to core

2009-06-14 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719246#action_12719246 ] Uwe Schindler commented on LUCENE-1673: --- Here my own thoughts: bq. But the latter c

[jira] Updated: (LUCENE-1539) Improve Benchmark

2009-06-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-1539: --- Attachment: LUCENE-1539.patch Attached new patch; fixed a bunch of silly issues (eg

[jira] Issue Comment Edited: (LUCENE-1673) Move TrieRange to core

2009-06-14 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719246#action_12719246 ] Uwe Schindler edited comment on LUCENE-1673 at 6/14/09 4:03 AM:

[jira] Issue Comment Edited: (LUCENE-1673) Move TrieRange to core

2009-06-14 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719246#action_12719246 ] Uwe Schindler edited comment on LUCENE-1673 at 6/14/09 4:05 AM:

[jira] Resolved: (LUCENE-1407) Refactor Searchable to not have RMI Remote dependency

2009-06-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-1407. Resolution: Fixed Thanks Simon! > Refactor Searchable to not have RMI Remote depe

[jira] Updated: (LUCENE-1589) IndexWriter.addIndexesNoOptimize(IndexReader[] readers)

2009-06-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-1589: --- Fix Version/s: (was: 2.9) 3.1 Moving out. > IndexWriter.addI

[jira] Resolved: (LUCENE-1677) Remove GCJ IndexReader specializations

2009-06-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-1677. Resolution: Fixed > Remove GCJ IndexReader specializations > -

[jira] Commented: (LUCENE-1677) Remove GCJ IndexReader specializations

2009-06-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719253#action_12719253 ] Shai Erera commented on LUCENE-1677: Is there a reason why test-tag does not depend on

New Token API was Re: Payloads and TrieRangeQuery

2009-06-14 Thread Grant Ingersoll
Agreed. I've been bringing it up for a while now and made the same comments when it was first introduced, but felt like the lone voice in the wilderness on it and gave way [1], [2], [3]. Now that others are writing/converting, I think it is worth revisiting. That being said, I did just wr

[jira] Commented: (LUCENE-1595) Split DocMaker into ContentSource and DocMaker

2009-06-14 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719257#action_12719257 ] Mark Miller commented on LUCENE-1595: - I hope to look at this today. Shai, will this a

[jira] Assigned: (LUCENE-1571) DistanceFilter problem with deleted documents

2009-06-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless reassigned LUCENE-1571: -- Assignee: Michael McCandless > DistanceFilter problem with deleted documents >

[jira] Commented: (LUCENE-1571) DistanceFilter problem with deleted documents

2009-06-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719258#action_12719258 ] Michael McCandless commented on LUCENE-1571: Indeed, this bug looks like it's

[jira] Commented: (LUCENE-979) Remove Deprecated Benchmarking Utilities from contrib/benchmark

2009-06-14 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719262#action_12719262 ] Mark Miller commented on LUCENE-979: Hmmm, I'm now getting Exception in thread "main"

[jira] Updated: (LUCENE-1571) DistanceFilter problem with deleted documents

2009-06-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-1571: --- Attachment: LUCENE-1571.patch OK I fixed it by switching to TermDocs(null), and also

[jira] Reopened: (LUCENE-979) Remove Deprecated Benchmarking Utilities from contrib/benchmark

2009-06-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless reopened LUCENE-979: --- Woops, I'll fix the build.xml & remove the old *.xml files from conf. > Remove Deprecate

[jira] Commented: (LUCENE-1677) Remove GCJ IndexReader specializations

2009-06-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719265#action_12719265 ] Michael McCandless commented on LUCENE-1677: bq. Is there a reason why test-ta

[jira] Commented: (LUCENE-1673) Move TrieRange to core

2009-06-14 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719266#action_12719266 ] Yonik Seeley commented on LUCENE-1673: -- bq. use SortField.PREFIX_ENCODED_INT for the

[jira] Commented: (LUCENE-1673) Move TrieRange to core

2009-06-14 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719270#action_12719270 ] Uwe Schindler commented on LUCENE-1673: --- {quote} bq. use SortField.PREFIX_ENCODED_IN

[jira] Commented: (LUCENE-1571) DistanceFilter problem with deleted documents

2009-06-14 Thread patrick o'leary (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719272#action_12719272 ] patrick o'leary commented on LUCENE-1571: - patch looks good to me, tests passed as

[jira] Commented: (LUCENE-1673) Move TrieRange to core

2009-06-14 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719273#action_12719273 ] Yonik Seeley commented on LUCENE-1673: -- bq. But on the other hand SortField.INT is al

[jira] Resolved: (LUCENE-979) Remove Deprecated Benchmarking Utilities from contrib/benchmark

2009-06-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-979. --- Resolution: Fixed > Remove Deprecated Benchmarking Utilities from contrib/benchmark >

[jira] Commented: (LUCENE-1595) Split DocMaker into ContentSource and DocMaker

2009-06-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719287#action_12719287 ] Shai Erera commented on LUCENE-1595: Yes, it will. Basically, DocMaker is now a concre

[jira] Commented: (LUCENE-1571) DistanceFilter problem with deleted documents

2009-06-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719290#action_12719290 ] Michael McCandless commented on LUCENE-1571: OK thanks for reviewing Patrick.

[jira] Resolved: (LUCENE-1571) DistanceFilter problem with deleted documents

2009-06-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-1571. Resolution: Fixed > DistanceFilter problem with deleted documents > --

[jira] Commented: (LUCENE-1595) Split DocMaker into ContentSource and DocMaker

2009-06-14 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719291#action_12719291 ] Mark Miller commented on LUCENE-1595: - I'd love other opinions. If we go with it, I

[jira] Updated: (LUCENE-1673) Move TrieRange to core

2009-06-14 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-1673: -- Attachment: LUCENE-1673.patch Here is a first patch, just for initial review of the API. - Onl

[jira] Issue Comment Edited: (LUCENE-1673) Move TrieRange to core

2009-06-14 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719292#action_12719292 ] Uwe Schindler edited comment on LUCENE-1673 at 6/14/09 9:14 AM:

[jira] Issue Comment Edited: (LUCENE-1673) Move TrieRange to core

2009-06-14 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719292#action_12719292 ] Uwe Schindler edited comment on LUCENE-1673 at 6/14/09 9:15 AM:

[jira] Resolved: (LUCENE-1539) Improve Benchmark

2009-06-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-1539. Resolution: Fixed Thanks Jason! > Improve Benchmark > - > >

[jira] Commented: (LUCENE-1595) Split DocMaker into ContentSource and DocMaker

2009-06-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719318#action_12719318 ] Shai Erera commented on LUCENE-1595: Well ... depends on what are the "existing algori

[jira] Commented: (LUCENE-1488) issues with standardanalyzer on multilingual text

2009-06-14 Thread Earwin Burrfoot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719322#action_12719322 ] Earwin Burrfoot commented on LUCENE-1488: - bq. But this can't replace ArabicAnalyz

[jira] Commented: (LUCENE-1488) issues with standardanalyzer on multilingual text

2009-06-14 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719342#action_12719342 ] Robert Muir commented on LUCENE-1488: - Earwin, I don't understand your question... Th

[jira] Commented: (LUCENE-1595) Split DocMaker into ContentSource and DocMaker

2009-06-14 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719351#action_12719351 ] Mark Miller commented on LUCENE-1595: - bq. If we say that contrib in general does not

Re: New Token API was Re: Payloads and TrieRangeQuery

2009-06-14 Thread Michael Busch
On 6/14/09 5:17 AM, Grant Ingersoll wrote: Agreed. I've been bringing it up for a while now and made the same comments when it was first introduced, but felt like the lone voice in the wilderness on it and gave way [1], [2], [3]. Now that others are writing/converting, I think it is worth rev

Re: New Token API was Re: Payloads and TrieRangeQuery

2009-06-14 Thread Mark Miller
I don't know how I feel about rolling the new token api back. I will say that I originally had no issue with it because I am very excited about Lucene-1458. At the same time though, I'm thinking Lucene-1458 is a very advanced issue that will likely be for really expert usage (though I can see

Re: New Token API was Re: Payloads and TrieRangeQuery

2009-06-14 Thread Mark Miller
Mark Miller wrote: I don't know how I feel about rolling the new token api back. I will say that I originally had no issue with it because I am very excited about Lucene-1458. At the same time though, I'm thinking Lucene-1458 is a very advanced issue that will likely be for really expert usa

[jira] Updated: (LUCENE-1689) supplementary character handling

2009-06-14 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-1689: Attachment: testCurrentBehavior.txt this is just a patch with testcases showing the existing behav

Build failed in Hudson: Lucene-trunk #859

2009-06-14 Thread Apache Hudson Server
See http://hudson.zones.apache.org/hudson/job/Lucene-trunk/859/changes Changes: [mikemccand] LUCENE-1539: add DeleteByPercent, FlushReader tasks, and ability to open reader on a labelled commit point [mikemccand] LUCENE-1571: fix LatLongDistanceFilter to respect deleted docs [mikemccand] LUCEN

[jira] Commented: (LUCENE-1595) Split DocMaker into ContentSource and DocMaker

2009-06-14 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719374#action_12719374 ] Mark Miller commented on LUCENE-1595: - {quote}Well ... depends on what are the "existi

[jira] Commented: (LUCENE-1595) Split DocMaker into ContentSource and DocMaker

2009-06-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719379#action_12719379 ] Shai Erera commented on LUCENE-1595: bq. So its not like I'm sitting here saying this

Re: New Token API was Re: Payloads and TrieRangeQuery

2009-06-14 Thread Shai Erera
The "old" API is deprecated, and therefore when we release 2.9 there might be some people who'd think they should move away from it, to better prepare for 3.0 (while in fact this many not be the case). Also, we should make sure that when we remove all the deprecations, this will still exist (and th

[jira] Commented: (LUCENE-1677) Remove GCJ IndexReader specializations

2009-06-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719422#action_12719422 ] Shai Erera commented on LUCENE-1677: I think test-core is broken too ... > Remove GCJ