Re: (LUCENE-1844) Speed up junit tests

2010-02-14 Thread Michael McCandless
Wow -- this is MUCH faster! I think we should switch... It seems like we use a batchtest for all core tests, then for all back-compat tests, then once per contrib package? Ie, so "ant test-core" uses one jvm? I think we should simply fix any badly behaved tests (that don't restore statics). It

Re: IndexWriter.init() checks for infoStream != null, redundantly?

2010-02-14 Thread Michael McCandless
IndexWriter has a default infoStream, so the infoStream could be non-null during init. Mike On Sat, Feb 13, 2010 at 3:16 PM, Shai Erera wrote: > Hi > > IndexWriter.init() checks a couple of times whether infoStream != null in > order to print informative messages ... init() is called only from t

RE: (LUCENE-1844) Speed up junit tests

2010-02-14 Thread Uwe Schindler
At least we should check all core tests to not set any static defaults without try...finally! Are there any possibilities inside Eclipse/other-IDEs to check this? Uwe - Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de eMail: u...@thetaphi.de > -Original Message

[jira] Commented: (LUCENE-1941) MinPayloadFunction returns 0 when only one payload is present

2010-02-14 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833551#action_12833551 ] Uwe Schindler commented on LUCENE-1941: --- As there is no real test available (for the

[jira] Commented: (LUCENE-1941) MinPayloadFunction returns 0 when only one payload is present

2010-02-14 Thread Erik Hatcher (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833552#action_12833552 ] Erik Hatcher commented on LUCENE-1941: -- Uwe - patch looks good. Go for it! > MinPay

Re: (LUCENE-1844) Speed up junit tests

2010-02-14 Thread Robert Muir
its not just statics, I think we should really look at ensuring files are closed etc, or eventually there will be a problem! I guess in general the tradeoff is, it requires us to have better test code. On Sun, Feb 14, 2010 at 5:53 AM, Uwe Schindler wrote: > At least we should check all core tes

[jira] Commented: (LUCENE-2263) Deadlock with FSIndexInput and SegmentReader

2010-02-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833558#action_12833558 ] Michael McCandless commented on LUCENE-2263: I added a comment on JCR-2426. >

[jira] Created: (LUCENE-2264) Add missing tests for PayloadXxxQuery

2010-02-14 Thread Uwe Schindler (JIRA)
Add missing tests for PayloadXxxQuery - Key: LUCENE-2264 URL: https://issues.apache.org/jira/browse/LUCENE-2264 Project: Lucene - Java Issue Type: Test Components: Search Reporter: Uw

[jira] Commented: (LUCENE-1941) MinPayloadFunction returns 0 when only one payload is present

2010-02-14 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833564#action_12833564 ] Uwe Schindler commented on LUCENE-1941: --- I created LUCENE-2264 for the tests. I wil

[jira] Issue Comment Edited: (LUCENE-1941) MinPayloadFunction returns 0 when only one payload is present

2010-02-14 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833564#action_12833564 ] Uwe Schindler edited comment on LUCENE-1941 at 2/14/10 12:52 PM: ---

[jira] Updated: (LUCENE-1941) MinPayloadFunction returns 0 when only one payload is present

2010-02-14 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-1941: -- Attachment: LUCENE-1941.patch Patch with CHANGES.txt in the new 3.0.1/2.9.2 section of restruc

[jira] Created: (LUCENE-2265) improve automaton performance by running on byte[]

2010-02-14 Thread Robert Muir (JIRA)
improve automaton performance by running on byte[] -- Key: LUCENE-2265 URL: https://issues.apache.org/jira/browse/LUCENE-2265 Project: Lucene - Java Issue Type: Improvement Components

[jira] Updated: (LUCENE-2265) improve automaton performance by running on byte[]

2010-02-14 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-2265: Attachment: LUCENE-2265.patch attached is a patch. at most it only improves performance around 10%

[jira] Commented: (LUCENE-2265) improve automaton performance by running on byte[]

2010-02-14 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833580#action_12833580 ] Robert Muir commented on LUCENE-2265: - I tested this with Hindi text as well, it gives

RE: (LUCENE-1844) Speed up junit tests

2010-02-14 Thread Steven A Rowe
Hi Uwe, On 02/14/2010 at 5:53 AM, Uwe Schindler wrote: > At least we should check all core tests to not set any static defaults > without try...finally! Are there any possibilities inside > Eclipse/other-IDEs to check this? IntelliJ has something called "structural search and replace" (SSR) - it

RE: (LUCENE-1844) Speed up junit tests

2010-02-14 Thread Uwe Schindler
That look exciting! Too bad that I have no IntelliJ, maybe we can use that somehow! - Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de eMail: u...@thetaphi.de > -Original Message- > From: Steven A Rowe [mailto:sar...@syr.edu] > Sent: Sunday, February 14, 2010

RE: (LUCENE-1844) Speed up junit tests

2010-02-14 Thread Steven A Rowe
Hi Uwe, As a committer on an open source project, you can get a free license for IntelliJ IDEA. From : Apache developers: Since ASF developers are often involved in several projects concurrently, JetBrains will provid

[jira] Resolved: (LUCENE-1941) MinPayloadFunction returns 0 when only one payload is present

2010-02-14 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved LUCENE-1941. --- Resolution: Fixed Committed trunk revision: 910034 Committed 3.0 branch revision: 910037 Com

[jira] Created: (LUCENE-2266) problem with edgengramtokenfilter and highlighter

2010-02-14 Thread Joe Calderon (JIRA)
problem with edgengramtokenfilter and highlighter - Key: LUCENE-2266 URL: https://issues.apache.org/jira/browse/LUCENE-2266 Project: Lucene - Java Issue Type: Bug Components: contrib/

[jira] Updated: (LUCENE-2266) problem with edgengramtokenfilter and highlighter

2010-02-14 Thread Joe Calderon (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Calderon updated LUCENE-2266: - Attachment: LUCENE-2266.patch > problem with edgengramtokenfilter and highlighter >

[jira] Commented: (LUCENE-2266) problem with edgengramtokenfilter and highlighter

2010-02-14 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833614#action_12833614 ] Robert Muir commented on LUCENE-2266: - Hi Joe, your patch looks correct to me, thanks!

[jira] Assigned: (LUCENE-2266) problem with edgengramtokenfilter and highlighter

2010-02-14 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir reassigned LUCENE-2266: --- Assignee: Robert Muir > problem with edgengramtokenfilter and highlighter >

[jira] Updated: (LUCENE-2266) problem with edgengramtokenfilter and highlighter

2010-02-14 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-2266: Attachment: LUCENE-2266.patch the same bug existed in both filters, and the tests for both filters

[jira] Commented: (LUCENE-2266) problem with edgengramtokenfilter and highlighter

2010-02-14 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833626#action_12833626 ] Uwe Schindler commented on LUCENE-2266: --- As this patch is really simple, I have no p

[jira] Updated: (LUCENE-2266) problem with edgengramtokenfilter and highlighter

2010-02-14 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-2266: -- Fix Version/s: 3.1 3.0.1 2.9.2 > problem with edgengramt

[jira] Resolved: (LUCENE-2266) problem with edgengramtokenfilter and highlighter

2010-02-14 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved LUCENE-2266. --- Resolution: Fixed Committed trunk revision: 910078 Committed 3.0 revision: 910080 Committed

[VOTE] Lucene Java 2.9.2 and 3.0.1 release artifacts

2010-02-14 Thread Uwe Schindler
Hallo Folks, I have posted a release candidate for both Lucene Java 2.9.2 and 3.0.1 (which both have the same bug fix level, functionality and release announcement), build from revision 910082 of the corresponding branches. Thanks for all your help! Please test them and give your votes until Th

Re: [VOTE] Lucene Java 2.9.2 and 3.0.1 release artifacts

2010-02-14 Thread Robert Muir
i checked, the demo and demo webapp works for both versions. On Sun, Feb 14, 2010 at 6:45 PM, Uwe Schindler wrote: > Hallo Folks, > > I have posted a release candidate for both Lucene Java 2.9.2 and 3.0.1 > (which both have the same bug fix level, functionality and release > announcement), build

Re: IndexWriter.init() checks for infoStream != null, redundantly?

2010-02-14 Thread Shai Erera
Ok, didn't know about that. Thanks ! On Sun, Feb 14, 2010 at 12:45 PM, Michael McCandless < luc...@mikemccandless.com> wrote: > IndexWriter has a default infoStream, so the infoStream could be > non-null during init. > > Mike > > On Sat, Feb 13, 2010 at 3:16 PM, Shai Erera wrote: > > Hi > > > >